Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Missing backticks breaking documentation in groupchat.last_speaker#3357

Merged
marklysze merged 1 commit intomicrosoft:mainfromHenryKobin:main
Aug 16, 2024

Conversation

HenryKobin
Copy link
Contributor

Why are these changes needed?

There are missing backticks in docstring causing the generated reference documentation formatting to break.

Related issue number

N/A

Checks

@marklyszemarklysze added the group chat/teamsgroup-chat-related issues labelAug 16, 2024
@marklysze
Copy link
Contributor

Changes look good, thanks@HenryKobin!

Before:
image

After:
image

@marklyszemarklysze self-requested a reviewAugust 16, 2024 03:37
Copy link
Contributor

@marklyszemarklysze left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good to go :),@qingyun-wu /@sonichi if you can assist with merge :)

@marklyszemarklysze added the documentationImprovements or additions to documentation labelAug 16, 2024
@codecov-commenter
Copy link

codecov-commenter commentedAug 16, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.44%. Comparing base(6279247) to head(d26e59f).
Report is 85 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@##             main    #3357       +/-   ##===========================================- Coverage   32.90%   20.44%   -12.46%===========================================  Files          94       95        +1       Lines       10235    10661      +426       Branches     2193     2278       +85     ===========================================- Hits         3368     2180     -1188- Misses       6580     8326     +1746+ Partials      287      155      -132
FlagCoverage Δ
unittests20.43% <ø> (-12.47%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@marklyszemarklysze added this pull request to the merge queueAug 16, 2024
Merged via the queue intomicrosoft:main with commit3fc708dAug 16, 2024
131 of 143 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@marklyszemarklyszemarklysze approved these changes

Assignees
No one assigned
Labels
documentationImprovements or additions to documentationgroup chat/teamsgroup-chat-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@HenryKobin@marklysze@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp