- Notifications
You must be signed in to change notification settings - Fork16
Update Error Boundary componentchildren prop to acceptReactNode#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR updates the AppInsightsErrorBoundary component by modifying the type of its children prop from React.ReactElement to React.ReactNode to support a wider variety of React elements.
- Allow broader children types by changing the prop type
- Enhance the flexibility of the Error Boundary component
Hello,@Karlie-777@siyuniu-ms have you been able to take a look at suggested changes within this PR? |
Closes#155