This commit wraps the tracking functionality to run outside of the Angular zone. Previously, it hindered server-side rendering and hydration, causing instability in the app. The app achieves stability when no microtasks or macrotasks are running.

On the client side, this change also prevents unnecessary view updates when asynchronous tasks are set up bytrackPageView.

arturovt force-pushed therun-outside-angular branch from6bd886c to8272658Compare

November 13, 2024 02:23

Run async stuff outside Angular

dab5a67

This commit wraps the tracking functionality to run outside of the Angular zone. Previously, it hinderedserver-side rendering and hydration, causing instability in the app. The app achieves stability when nomicrotasks or macrotasks are running.On the client side, this change also prevents unnecessary view updates when asynchronous tasks are setup by `trackPageView`.

arturovt force-pushed therun-outside-angular branch from8272658 todab5a67Compare

November 13, 2024 02:25

MSNev reviewed

Nov 13, 2024

View reviewed changes

...plicationinsights-angularplugin-js/src/lib/applicationinsights-angularplugin-js.component.ts

		@@ -186,7 +187,7 @@ export class AngularPlugin extends BaseTelemetryPlugin {
		* @param event The event that needs to be processed
		*/
		processTelemetry(event: ITelemetryItem, itemCtx?: IProcessTelemetryContext) {
		this.processNext(event, itemCtx);
		runOutsideAngular(() =>this.processNext(event, itemCtx));

Copy link

Contributor

MSNevNov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This one is likely not needed as this is called internally from all of thetrackXXX calls -- so (if I'm following your comments correctly) this should already be getting run in the "outside" context...

Although, I do concede that if something does end up calling a track call within the Angular context (like any of the automatic events (JS errors, URL change etc)) then this would be the point at which it would switch to the different async context.

My only concern with this (which is less of an issue with any SPA framework) is that once the page starts to unload all operation "should" become synchronous to avoid the loss of events. And I don't think we current expose the internal flags indicating that we have received any unload signal (unload, beforeunload, pagehide and visibilitychange events)