NotificationsYou must be signed in to change notification settings
Fork2.7k
Star23.2k

[retry-after] Clarify that header value must not use <http-date>#553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

mikeharder wants to merge1 commit intomicrosoft:vNext

base:vNext

Choose a base branch

frommikeharder:patch-1

Draft

[retry-after] Clarify that header value must not use <http-date>#553

mikeharder wants to merge1 commit intomicrosoft:vNextfrommikeharder:patch-1

Conversation

Copy link

mikeharder commentedJul 10, 2024

No description provided.

[retry-after] Clarify that header value may not use <http-date>

a515ea5

mikekistler reviewed

Jul 10, 2024

View reviewed changes

azure/Guidelines.md

		<ahref="#lro-status-monitor-no-resource-result"name="lro-status-monitor-no-resource-result">:no_entry:</a>DO NOT include a`result` property in the status monitor for a long-running operation that is not an action-type long-running operation.

		<ahref="#lro-status-monitor-retry-after"name="lro-status-monitor-retry-after">:white_check_mark:</a>DO include a`retry-after` header in the response if the operation is not complete. The value of this headershould beaninteger number of seconds that the client should wait before polling the status monitor again.
		<ahref="#lro-status-monitor-retry-after"name="lro-status-monitor-retry-after">:white_check_mark:</a>DO include a`retry-after` header in the response if the operation is not complete. The value of this headermust bea non-negativeinteger number of seconds that the client should wait before polling the status monitor again. The value of this header must not be an`<http-date>` string, even though`<http-date>` is also allowed in the HTTP spec.

Copy link

Member

mikekistlerJul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This particular guideline only applies to LRO status monitor responses, and I think we want to make this guidance apply to any time a service returnsretry-after. I recommend adding a new guideline in the section titled "HTTP Query Parameters and Header Values".