Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Update langchain to 1.x#364

Merged
ultmaster merged 12 commits intomicrosoft:mainfrom
lspinheiro:langchain_1x_update
Dec 5, 2025
Merged

Update langchain to 1.x#364
ultmaster merged 12 commits intomicrosoft:mainfrom
lspinheiro:langchain_1x_update

Conversation

@lspinheiro
Copy link
Contributor

No description provided.

Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@lspinheiro
Copy link
ContributorAuthor

@ultmaster , this PR is updating the langchain to 1.x. There were some other conflicts outside of the verl numpy version. There was also an incompatibility with openai version requirements between langchain and vllm so I opted for conflict groups instead. There is only one CI failure due to the new conflict groups. Do you think we can update the build or would prefer a different solution than the conflict groups?

Run uv sync --frozen \Using CPython 3.12.3 interpreter at: /usr/bin/python3.12Creating virtual environment at: .venvwarning: The`extra-build-dependencies` option is experimental and may change without warning. Pass`--preview-features extra-build-dependencies` to disable this warning.error: Extra`verl` and group`agents` are incompatible with the declared conflicts: {`agentlightning[verl]`,`agentlightning:agents`}

@ultmaster
Copy link
Contributor

verl must run together within the same env as langchain. It's not a hard requiement, but that's how our CI works.

Before we goes into the pain of refactoring CI, maybe you can add numpy >= 2.1.0 to override-dependency to see whether CI works. VERL might not have a strong opinion about numpy; they just falsely constrain the dependency for safety.

@ultmaster
Copy link
Contributor

Related work:#350

@lspinheiro
Copy link
ContributorAuthor

@ultmaster , I did what you suggested. Checks CI is passing. Let me know how the review goes.

fromlangchain import hub
fromlangchain.agents import AgentExecutor, create_react_agent, tool
fromlangchain.chat_models import init_chat_model
fromlangchain_classic import hub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could you migrate langchain_classic to langchain?

@ultmasterultmaster linked an issueDec 5, 2025 that may beclosed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think maybe we should eject langchain from agents. Otherwise we won't be able to install agent dependencies for many legacy workflows.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We could potentially create a langchain legacy to keep it with the torch legacy as well, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That feels way too complicated. Let's just drop the legacy version.

"agents" is a one-stop installation for all the agent-related requirements, but not the heavy requirements. For example, rag-related requirements are not included in agents.

Therefore, we should include --group langchain in "lint - slow" and tests-full and examples-spider. Those CIs rely on langchain.

For tests that have conflicts, we can disable them for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You needn't worry about legacy tests. I'll handle them. You only need to make sure the stable/latest tests have passed.

@ultmaster
Copy link
Contributor

please rerun uv lock and check in uv.lock

@lspinheiro
Copy link
ContributorAuthor

please rerun uv lock and check in uv.lock

The uv lock is up to date. The second commit (numpy > 2.x) was the last one to include changes to the uv lock.

@lspinheiro
Copy link
ContributorAuthor

please rerun uv lock and check in uv.lock

Ah, I see the conflicts. I will pull the main changes and resolve

@lspinheirolspinheiro changed the title[DRAFT] update langchain to 1.xUpdate langchain to 1.xDec 5, 2025
@ultmaster
Copy link
Contributor

ultmaster commentedDec 5, 2025
edited
Loading

I notice uv.lock is 55MB now. I don't think it makes sense. Let me pull the head and try to lock it myself.


That indeed produces 33MB! I think maybe we have introduced some conflicting groups by mistake.

@ultmaster
Copy link
Contributor

I found the correct solution. We have to remove langchain first and lock once and add langchain again to lock again. let me push it.

lspinheiro reacted with thumbs up emoji

@lspinheiro
Copy link
ContributorAuthor

I found the correct solution. We have to remove langchain first and lock once and add langchain again to lock again. let me push it.

That was a good catch. Looks like there are now some test errors that need the langchain dependency, can I move on to fix them or do you still have changes to make?

@ultmaster
Copy link
Contributor

please fix the unit-tests. Then I'll proceed to run example tests to see if there are more errors popping up.

@lspinheiro
Copy link
ContributorAuthor

@ultmaster , the tests are fixed now in CI

@ultmasterultmaster merged commitf9fe772 intomicrosoft:mainDec 5, 2025
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ultmasterultmasterultmaster left review comments

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

langchain 1.0 needed update

2 participants

@lspinheiro@ultmaster

[8]ページ先頭

©2009-2026 Movatter.jp