- Notifications
You must be signed in to change notification settings - Fork1.3k
Comments
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
lspinheiro commentedDec 4, 2025
@ultmaster , this PR is updating the langchain to 1.x. There were some other conflicts outside of the verl numpy version. There was also an incompatibility with openai version requirements between langchain and vllm so I opted for conflict groups instead. There is only one CI failure due to the new conflict groups. Do you think we can update the build or would prefer a different solution than the conflict groups? Run uv sync --frozen \Using CPython 3.12.3 interpreter at: /usr/bin/python3.12Creating virtual environment at: .venvwarning: The`extra-build-dependencies` option is experimental and may change without warning. Pass`--preview-features extra-build-dependencies` to disable this warning.error: Extra`verl` and group`agents` are incompatible with the declared conflicts: {`agentlightning[verl]`,`agentlightning:agents`} |
ultmaster commentedDec 5, 2025
verl must run together within the same env as langchain. It's not a hard requiement, but that's how our CI works. Before we goes into the pain of refactoring CI, maybe you can add numpy >= 2.1.0 to override-dependency to see whether CI works. VERL might not have a strong opinion about numpy; they just falsely constrain the dependency for safety. |
ultmaster commentedDec 5, 2025
Related work:#350 |
lspinheiro commentedDec 5, 2025
@ultmaster , I did what you suggested. Checks CI is passing. Let me know how the review goes. |
tests/tracer/test_integration.py Outdated
| fromlangchain import hub | ||
| fromlangchain.agents import AgentExecutor, create_react_agent, tool | ||
| fromlangchain.chat_models import init_chat_model | ||
| fromlangchain_classic import hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could you migrate langchain_classic to langchain?
pyproject.toml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think maybe we should eject langchain from agents. Otherwise we won't be able to install agent dependencies for many legacy workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could potentially create a langchain legacy to keep it with the torch legacy as well, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That feels way too complicated. Let's just drop the legacy version.
"agents" is a one-stop installation for all the agent-related requirements, but not the heavy requirements. For example, rag-related requirements are not included in agents.
Therefore, we should include --group langchain in "lint - slow" and tests-full and examples-spider. Those CIs rely on langchain.
For tests that have conflicts, we can disable them for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You needn't worry about legacy tests. I'll handle them. You only need to make sure the stable/latest tests have passed.
ultmaster commentedDec 5, 2025
please rerun uv lock and check in uv.lock |
lspinheiro commentedDec 5, 2025
The uv lock is up to date. The second commit (numpy > 2.x) was the last one to include changes to the uv lock. |
lspinheiro commentedDec 5, 2025
Ah, I see the conflicts. I will pull the main changes and resolve |
8e23bb7 to9e55921Compareultmaster commentedDec 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I notice uv.lock is 55MB now. I don't think it makes sense. Let me pull the head and try to lock it myself. That indeed produces 33MB! I think maybe we have introduced some conflicting groups by mistake. |
ultmaster commentedDec 5, 2025
I found the correct solution. We have to remove langchain first and lock once and add langchain again to lock again. let me push it. |
lspinheiro commentedDec 5, 2025
That was a good catch. Looks like there are now some test errors that need the langchain dependency, can I move on to fix them or do you still have changes to make? |
ultmaster commentedDec 5, 2025
please fix the unit-tests. Then I'll proceed to run example tests to see if there are more errors popping up. |
lspinheiro commentedDec 5, 2025
@ultmaster , the tests are fixed now in CI |
f9fe772 intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
No description provided.