- Notifications
You must be signed in to change notification settings - Fork920
.NET: AgentDefinition extensions method simplification#1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
.NET: AgentDefinition extensions method simplification#1967
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR refactors the agent creation API to consolidate tool specification within theAgentDefinition itself, removing the separatetools parameter from public methods. TherequireInvocableTools parameter is also removed from public methods.
Key changes:
- Public
CreateAIAgentandCreateAIAgentAsyncmethods that acceptAgentDefinitionno longer take atoolsparameter - Tools are extracted from
PromptAgentDefinition.Toolscollection instead - Two new private overloads handle the tool parameter internally
- All tests updated to add tools to the definition instead of passing them as a parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AgentsClientExtensions.cs | Refactors public API to removetools andrequireInvocableTools parameters; adds private overloads for internal tool handling; updates parameter order in some methods |
| AgentsClientExtensionsTests.cs | Updates all tests to use tools from definition instead of parameter; renames tests to reflect new behavior; adds new test cases for FunctionTools |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d55b159 intomicrosoft:feature-foundry-agentsUh oh!
There was an error while loading.Please reload this page.
…1662)* WIP* Fixed build errors (#1638)Comment and nullable type alignment* .NET: Azure.AI.Agents Package Split + Initial Extensions (#1657)* Move packages* Update nuget.config* Address Xmldoc* Remove format from branches checks* Address Xmldocs* Add more details to the implementation* Moving Agent logic to ChatClient* Adding Name and Id overrides to AzureAIAgent* Updating extensions* Add GetAiAgent extensions* Adding support for version as name can conflict 409 using the Agents API with same name* Addressing more updates to the extensions* More improvements* Remove debugging code from sample* Address copilot feedback* Apply suggestions from co-pilot code review* Update Directory.Packages.propsFix package version rollback:Azure.AI.Agents.Persistent (beta-6 => beta-7)* .NET: Add comprehensive unit tests for Microsoft.Agents.AI.AzureAIAgents extension methods (#1786)* Initial plan* Add comprehensive unit test project for Microsoft.Agents.AI.AzureAIAgentsCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Add README documenting test project and package dependency requirementsCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Fix documentation URL to use learn.microsoft.comCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Bump back AAAP 1.2.0-beta.7* Address AI generated UT's* Remove UT Readme* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* .NET: Change model to be required just for prompt agent definition specific extensions (#1812)* Remove unneeded model from extensions* Add noop justification* Update Package Nameing: V1 -> AzureAI.Persistent / V2 -> AzureAI (#1829)* .NET: Update Extensions for Strict Agent Definitions + Improvements (#1892)* Update Package Nameing: V1 -> AzureAI.Persistent / V2 -> AzureAI* Update agents and extensions to comply with strict agent definitions* More static updates* Address UT, and ResponseTool support* Improving reusability extensions* Addressing ResponseTools Unit Tests and extension setup* Adapted workaround on breaking AAA with OpenAI 2.6.0* Small updates* Remove strictness when retrieving agents, improved XmlDocs* Improve sample comments* Update dotnet/tests/Microsoft.Agents.AI.AzureAI.UnitTests/AgentsClientExtensionsTests.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestion from @CopilotCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestion from @CopilotCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address PR comments* Address UT failing* Address Copilot feedback* Address Copilot feedback* Address comment typo* Address PR feedback* Address typo* Add missing Extensions with ChatClientAgentOptions* Address comments---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Version update (#1901)* Updated package version (#1906)* .NET: Allow Declarative AIAgents Extensions (#1931)* Improve reusability of extension code and additional option to losen the strictiness of in-proc tools* Add missing UT scenarios* Add missing UT test scenarios* Normalize changes* Updated (#1948)* .NET: AgentDefinition extensions method simplification (#1967)* Update extensions methods that accepts AgentDefinition type to not be restrictive* Update Unit Tests* Revert yarn/package-lock* Revert yarn/package-lock* Address copilot feedback* Fix bad merge* .NET Workflows - WIP Declarative action update (#1761)* WIP* Fixed build errors (#1638)Comment and nullable type alignment* Sync to SDK update* Checkpoint* Checkpoint: Tests passing* Checkpoint: EndWorkflow* Add trace* .NET: Azure.AI.Agents Package Split + Initial Extensions (#1657)* Move packages* Update nuget.config* Address Xmldoc* Remove format from branches checks* Address Xmldocs* Add more details to the implementation* Moving Agent logic to ChatClient* Adding Name and Id overrides to AzureAIAgent* Updating extensions* Add GetAiAgent extensions* Adding support for version as name can conflict 409 using the Agents API with same name* Addressing more updates to the extensions* More improvements* Remove debugging code from sample* Address copilot feedback* Apply suggestions from co-pilot code review* Checkpoint* Update Directory.Packages.propsFix package version rollback:Azure.AI.Agents.Persistent (beta-6 => beta-7)* Add project reference* .NET: Add comprehensive unit tests for Microsoft.Agents.AI.AzureAIAgents extension methods (#1786)* Initial plan* Add comprehensive unit test project for Microsoft.Agents.AI.AzureAIAgentsCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Add README documenting test project and package dependency requirementsCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Fix documentation URL to use learn.microsoft.comCo-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>* Bump back AAAP 1.2.0-beta.7* Address AI generated UT's* Remove UT Readme* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* .NET: Change model to be required just for prompt agent definition specific extensions (#1812)* Remove unneeded model from extensions* Add noop justification* Update Package Nameing: V1 -> AzureAI.Persistent / V2 -> AzureAI (#1829)* Checkpoint for merge* No build errors* .NET: Update Extensions for Strict Agent Definitions + Improvements (#1892)* Update Package Nameing: V1 -> AzureAI.Persistent / V2 -> AzureAI* Update agents and extensions to comply with strict agent definitions* More static updates* Address UT, and ResponseTool support* Improving reusability extensions* Addressing ResponseTools Unit Tests and extension setup* Adapted workaround on breaking AAA with OpenAI 2.6.0* Small updates* Remove strictness when retrieving agents, improved XmlDocs* Improve sample comments* Update dotnet/tests/Microsoft.Agents.AI.AzureAI.UnitTests/AgentsClientExtensionsTests.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestion from @CopilotCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestion from @CopilotCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address PR comments* Address UT failing* Address Copilot feedback* Address Copilot feedback* Address comment typo* Address PR feedback* Address typo* Add missing Extensions with ChatClientAgentOptions* Address comments---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Updated package version (#1897)* Version update (#1901)* Checkpoint* Updated package version (#1906)* Checkpoint* Checkpoint* Checkpoint* Align with azure ai agent* Update dotnet/samples/GettingStarted/Workflows/Declarative/StudentTeacher/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/MCPToolApproval/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/DeepResearch/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Refactored external input* Update dotnet/samples/GettingStarted/Workflows/Declarative/MCPToolApproval/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Agent tools patch* Demos validated* Checkpoint* Hygiene* Checkpoint - Samples* Update dotnet/samples/GettingStarted/Workflows/Declarative/StudentTeacher/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/StudentTeacher/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Checkpoint* Checkpoint - Deep Research* Update baseline* Update* Typo* Checkpoint* Typos* Sample cleanup* Update dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/AzureAgentProvider.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/src/Microsoft.Agents.AI.AzureAI/AgentsClientExtensions.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/FunctionTools/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/StudentTeacher/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/ToolApproval/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Update dotnet/samples/GettingStarted/Workflows/Declarative/DeepResearch/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Typo* Typo* Fix input loop* Sample - Function Calling / External Input* Typo* Finessed* Checkpoint* Fix feed* Checkpoint - so close* Ding dong!* "there" **** Fixup comments* Fix sample* Code analysis* Header* Typo (variableName)* Remove dead code* Skip test (agent api ratchet)* Comment* Update dotnet/samples/GettingStarted/Workflows/Declarative/StudentTeacher/Program.csCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Typo---------Co-authored-by: Roger Barreto <19890735+rogerbarreto@users.noreply.github.com>Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>* .NET: Latest updates Pre/Post V2 Bugbash Findings (#2040)* Improve V2 logic before/after bugbash prep* Apply suggestions from code reviewCo-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>---------Co-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* .NET: Update Foundry Agents to latest 2.0.0 alpha.20251107.3 (#2050)* Update extensions for new CreateVersionOptions structure* Update unit tests* Addresss capitalized* Update AgentsClientExtensionsTests.csFix invalid cast format failure* .NET: Feature foundry agent + user agent (#2058)* Update unit tests* Add user-agent protocol calls* Update unit tests* Update unit tests with http handler confirmation* UT fix* Fix xmldoc* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address copilot feedback---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* .NET: Update Extensions to be less restrictive for GetAIAgents (#2091)* Update behavior / restrictiveness when retrieving agents* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address format* Address copilot feedback---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>* .NET Workflows - Support "structured inputs" feature for declarative workflows (#2053)* Bump version for release* .NET Workflows - Separate Foundry/AzureAI Provider into its own package (#2078)* Remove unused using directive in AzureAgentProviderRemoved unused using directive for Extensions.* .NET: Updates to Foundry Agents Package (#2125)* Remove the conversation creation always* Update unit tests + address IL + refactor* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Internalize unused methods---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Fix declarative workflows integration testcase* .NET: Feature foundry agent/agent reference extension (Python Parity with Name + Version option) (#2147)* Add agent reference extensions* Add UT covering AgentReference and ModelId* .NET: Add GettingStarted Samples for Agents V2. (#2159)* Add gettingstarted samples for Foundry Agents* Address structured outputs* Net 10 -> Net 9 Temporary* Net 10 -> Net 9 Temporary* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address missing docs + old* Drop var for samples* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Apply suggestions from code reviewCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* Address copilot feedback---------Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>* .NET: Foundry Agents V2 - Add CodeInterpreter Sample (#2180)* Adding Code Interpreter sample and AgentName naming validation* Add agent name check UT* Improve sample code* Apply suggestion* Apply suggestion* Fixed (#2190)* .NET Workflows - Add "CustomerSupport" sample (#2102)* .NET Workflows - Add sample for hosted declarative workflow (#2199)* fwiw* Less blank lines* Fixed (#2204)* Update version (#2206)* .NET: Feature foundry agent/update breaking v2.0 to v1.2 (#2212)* Migration WIP Checkpoint 1* Build + UT + Workflow passing* Address latest commits after break* Revert rename in unrelated files* Address PR comments* Class renames* Allow dotnet-format workflow on feature branchesRevert unintentional edit* .NET: Add Conformance Integration Tests for AzureAI Package (#2237)* Conformance tests added and passing* Correct namespace* Update Azure.AI.Project to latest public nuget version* .NET: Added Computer use tool sample (#2235)* Initial computer use sample implementation.* Added background thread to allow polling for long running requests.* Removed unrequired try-catch block and added missing thread for agent call.* Removed irrelevant chatOptions and updated code based on feedback.* Updated image assets and fixed response issue.* Updated based on PR comments.* Update to Azure.AI.Project---------Co-authored-by: Roger Barreto <19890735+rogerbarreto@users.noreply.github.com>* Package descriptions---------Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>Co-authored-by: Chris Rickman <crickman@microsoft.com>Co-authored-by: Stephen Toub <stoub@microsoft.com>Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>Co-authored-by: Peter Ibekwe <109177538+peibekwe@users.noreply.github.com>
Motivation and Context
AIAgent creation extensions methods that accept an
AgentDefinitionwill not require invocabletoolsto be provided and will require the caller to handle any invocable tool request manually.As part of this PR was addressed a small but where
FunctionTools.AsAIToolsweren't being validated properly.