Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Centralize app version info in project file for maintainability#2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
AndrewKeepCoding wants to merge8 commits intomicrosoft:main
base:main
Choose a base branch
Loading
fromAndrewKeepCoding:centralizing-app-version

Conversation

@AndrewKeepCoding
Copy link
Contributor

Description

This PR centralizes the app version management by introducing aVersion property in the app project file.

Motivation and Context

Currently, we are manually updating these files to bump the app version, which is error-prone and easy to miss.

  • Package.appxmanifest
  • Package.Dev.appxmanifest
  • AssemblyInfo.cs

Closes#2054.

How Has This Been Tested?

Ran the app and confirmed the changes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgnmarcelwgnenabled auto-merge (squash)October 28, 2025 14:48
@marcelwgn
Copy link
Contributor

Thank you for fixing this and sorry for the delay in reviewing this.

@AndrewKeepCoding
Copy link
ContributorAuthor

Thanks@marcelwgn !
It looks like the CI is failing on WinUI-Gallery-PRValidation, but I don't have access to view the details. Would you mind taking a look when you get a chance?

@marcelwgn
Copy link
Contributor

Looks like something funny with the nuget restore, let me retry

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn
Copy link
Contributor

Nuget is still complaining, I will take a look another time. The changes in here dont seem like they should cause nuget restore to fail

AndrewKeepCoding reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@marcelwgnmarcelwgnmarcelwgn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Centralize app version

2 participants

@AndrewKeepCoding@marcelwgn
[8]ページ先頭
©2009-2025 Movatter.jp