Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4900a8d

Browse files
committed
Merged PR 33420: Fix pausing on CanvasAnimatedControl and move it out of experimental stage
This PR fixes pausing/unpausing on CanvasAnimatedControl which was due to us shutting down the dispatcher prematurely. With this, we are also removing CACs experimental tag.----#### AI description (iteration 1)#### PR ClassificationBug fix and code cleanup#### PR SummaryThis pull request fixes the pausing issue on `CanvasAnimatedControl` and moves it out of the experimental stage.- `build/Win2D.cs.props`: Removed the exclusion of experimental warnings for `CanvasAnimatedControl`.- `winrt/lib/xaml/GameLoopThread.cpp`: Adjusted the shutdown sequence of the dispatcher queue to ensure proper cleanup.- `winrt/lib/xaml/CanvasAnimatedControl.abi.idl`: Removed the `[experimental]` attribute from `CanvasAnimatedControl`.
1 parent59eda0e commit4900a8d

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

‎build/Win2D.cs.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
<WarningLevel>4</WarningLevel>
1717
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1818
<TargetPlatformVersion>10.0.19041.0</TargetPlatformVersion>
19-
20-
<!-- Don't fail the build for [Experimental] warnings (eg. for CanvasAnimatedControl)-->
21-
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS8305</WarningsNotAsErrors>
2219
</PropertyGroup>
2320
<PropertyGroup>
2421
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>

‎winrt/lib/xaml/CanvasAnimatedControl.abi.idl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,6 @@ namespace Microsoft.Graphics.Canvas.UI.Xaml
281281
}
282282

283283
[version(VERSION), activatable(VERSION), marshaling_behavior(agile), threading(both)]
284-
[experimental]
285284
runtimeclass CanvasAnimatedControl : Microsoft.UI.Xaml.Controls.UserControl
286285
{
287286
[default] interface ICanvasAnimatedControl;

‎winrt/lib/xaml/GameLoopThread.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,6 @@ class GameLoopThread : public IGameLoopThread
260260

261261
lock.unlock();
262262
ThrowIfFailed(As<IDispatcherQueue3>(m_dispatcherQueue)->RunEventLoop());
263-
ComPtr<IAsyncAction> action;
264-
m_dispatcherQueueController->ShutdownQueueAsync(&action);
265263
lock.lock();
266264

267265
m_dispatcherStarted =false;
@@ -271,6 +269,8 @@ class GameLoopThread : public IGameLoopThread
271269

272270
// Cancel any remaining actions
273271
CancelActions(lock);
272+
ComPtr<IAsyncAction> action;
273+
m_dispatcherQueueController->ShutdownQueueAsync(&action);
274274

275275
lock.unlock();
276276
m_client->OnGameLoopStopped();

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp