- Notifications
You must be signed in to change notification settings - Fork460
Comparing changes
Open a pull request
base repository:microsoft/VFSForGit
Uh oh!
There was an error while loading.Please reload this page.
base:v1.0.24074.1
head repository:microsoft/VFSForGit
Uh oh!
There was an error while loading.Please reload this page.
compare:v1.0.24298.1
- 17commits
- 11files changed
- 4contributors
Commits on Mar 8, 2024
Properly quote sc.exe create's binPath argument
If the binPath isn't quoted, sc.exe will first look for a file at C:\Program.Starting that will yield CreateProcess error 193 (aka invalid Win32 program).By properly quoting the binPath, we guarantee that the correct file will be loaded.
winstliu committedMar 8, 2024
Commits on Aug 26, 2024
Update the InnoSetup dependency to a newer version
The primary reason is that Component Detection(https://github.com/microsoft/component-detection) pointed out that theversion we used is missing legal information.As ofclearlydefined/curated-data#23677, version6.2.1 of this package has a documented license. Therefore, this issueshould be hereby resolved.Besides, it's always good to stay up to date with dependencies.Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho committedAug 26, 2024 Update the LibGit2Sharp dependency to a newer version
The primary reason is that Component Detection(https://github.com/microsoft/component-detection) pointed out that theversion we used is missing legal information.Noticing thathttps://www.nuget.org/packages/LibGit2Sharp.NativeBinaries/2.0.278/Licenseshows only a link into the repository, but the full license is shown athttps://www.nuget.org/packages/LibGit2Sharp.NativeBinaries/2.0.322/Licensethis issue should be hereby resolved.Besides, it's always good to stay up to date with dependencies.Since libgit2 is very careful about backwards-compatibility (andtherefore LibGit2Sharp, too), this update should not result in anychange of behavior.Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho committedAug 26, 2024 Update all remaining dependencies to their latest stable versions
Now that we addressed the Component Detection issues, let's just goahead and proactively update the remaining dependencies, too.Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Merge pull request#1815from microsoft/update-dependencies
Update dependencies
Commits on Oct 24, 2024
ci: update Actions to newer versions
The v2 version of `upload-artifact`/`download-artifact` is no longersupported and stopped working. Let's update to v4, which _does_ work.Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho committedOct 24, 2024 ci: ask Dependabot to take care of updating GitHub Actions
Every once in a while, the GitHub Actions we use (such as `checkout`,`upload-artifact`, etc) require updates as the old versions stopworking.Let's ask Dependabot to take care of this tedious task.Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Handle nested failures in HttpRequestException
`HttpClientHandler` will automatically resubmit an HTTP request thatfails in certain circumstances. One such circumstance is when`UseDefaultCredentials` is set to `true``, alternative credentials wereprovided on the request, and the request failed with "401 Unauthorized",then it will resubmit using the default credentials. If an exception isthrown when getting the default credentials that exception is nothandled, but is wrapped in `HttpRequestExceptio`n and thrown by`SendAsync` instead of returning the original response with the failingstatus code. See the following code snippet from `HttpWebRequest`:https://referencesource.microsoft.com/#System/net/System/Net/HttpWebRequest.cs,5535When this happens in GVFS, the result is that GVFS does not recognizethe failure as being authentication related, so it does not refresh thecredential. Instead, it loops through all its retries, and eventuallyfails the request. This is typically visible to users as a file systemexception (e.g. file not found) if the GVFS trigger was accessing avirtual file or other operation on an individual file, or various errors(including "this repository requires the GVFS protocol") for a `gitpull`. The symptoms will continue for the user until they remount theGVFS enlistment, which forces GVFS to refresh its credential.This commit adds an exception handler for `HttpRequestException`` to`client.SendAsync`, which attempts to find the original failed responseembedded in the inner exception properties. If it does so, it logs awarning and continues processing using the original failed response,which will trigger the logic for handling the various possible statuscodes. If it can't extract the original failed response, then it willlet the exception bubble up.Signed-off-by: Tyrie Vella <tyrielv@gmail.com>Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Merge pull request#1806from winstliu/user/winstonliu/fix-sc-create-…
…argumentsPoint GVFS.Service to the correct executable when C:\Program exists
Merge pull request#1816from tyrielv/nested-401
Handle nested failures in HttpRequestException
build(deps): bump actions/setup-dotnet from 1 to 4
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 1 to 4.- [Release notes](https://github.com/actions/setup-dotnet/releases)- [Commits](actions/setup-dotnet@v1...v4)---updated-dependencies:- dependency-name: actions/setup-dotnet dependency-type: direct:production update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump actions/checkout from 2 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.- [Release notes](https://github.com/actions/checkout/releases)- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)- [Commits](actions/checkout@v2...v4)---updated-dependencies:- dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump microsoft/setup-msbuild from 1.0.2 to 2.0.0
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.0.2 to 2.0.0.- [Release notes](https://github.com/microsoft/setup-msbuild/releases)- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)- [Commits](microsoft/setup-msbuild@v1.0.2...v2.0.0)---updated-dependencies:- dependency-name: microsoft/setup-msbuild dependency-type: direct:production update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request#1818from microsoft/dependabot/github_actions/act…
…ions/setup-dotnet-4build(deps): bump actions/setup-dotnet from 1 to 4
Merge pull request#1819from microsoft/dependabot/github_actions/act…
…ions/checkout-4build(deps): bump actions/checkout from 2 to 4
Merge pull request#1820from microsoft/dependabot/github_actions/mic…
…rosoft/setup-msbuild-2.0.0build(deps): bump microsoft/setup-msbuild from 1.0.2 to 2.0.0
Merge pull request#1821from microsoft/milestones/m195
[Release] Milestones M195
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v1.0.24074.1...v1.0.24298.1
Uh oh!
There was an error while loading.Please reload this page.