Commit1d0af97

and

authored

ATA:node: module resolution (#3191)

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

1 parentce2f2e9 commit1d0af97Copy full SHA for 1d0af97

File tree

+12

-1

lines changed

+12

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+"@typescript/ata":patch`
	`3`	`+---`
	`4`	`+`
	`5`	+Always treat`node:` modules as Node, expand list of known Node modules

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {`
`24`	`24`	`"http2",`
`25`	`25`	`"https",`
`26`	`26`	`"inspector",`
	`27`	`+"inspector/promises",`
`27`	`28`	`"module",`
`28`	`29`	`"net",`
`29`	`30`	`"os",`
`@@ -57,7 +58,7 @@ export const mapModuleNameToModule = (moduleSpecifier: string) => {`
`57`	`58`	`"zlib",`
`58`	`59`	`]`
`59`	`60`
`60`		`-if(builtInNodeMods.includes(moduleSpecifier.replace("node:",""))){`
	`61`	`+if(moduleSpecifier.indexOf("node:")===0\|\|builtInNodeMods.includes(moduleSpecifier)){`
`61`	`62`	`return"node"`
`62`	`63`	`}`
`63`	`64`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,11 @@ describe(mapModuleNameToModule, () => {`
`9`	`9`	`expect(mapModuleNameToModule("node:fs")).toEqual("node")`
`10`	`10`	`})`
`11`	`11`
	`12`	`+it("handles mandatorily-prefixed node: identifiers",()=>{`
	`13`	`+expect(mapModuleNameToModule("node:test")).toEqual("node")`
	`14`	`+expect(mapModuleNameToModule("test")).toEqual("test")`
	`15`	`+})`
	`16`	`+`
`12`	`17`	`it("strips module filepaths",()=>{`
`13`	`18`	`expect(mapModuleNameToModule("lodash/identity")).toEqual("lodash")`
`14`	`19`	`expect(mapModuleNameToModule("@org/lodash/identity")).toEqual("@org/lodash")`

Comments

(0)