- Notifications
You must be signed in to change notification settings - Fork13.2k
Open
Conversation
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
Updates dev tooling dependencies (notably ESLint) to address some security audit items and adjust in-repo lint tooling/config to match the new major versions.
Changes:
- Bump ESLint /
@eslint/jsand related lint dependencies; removeeslint-formatter-autolinkable-stylish. - Update custom ESLint rules to use
context.sourceCode(ESLint v10 API) and fix JSDoc typing forunsetsentinel. - Adjust ESLint flat config to match new plugin config shape and disable newly-added core rules.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/eslint/rules/jsdoc-format.cjs | Switch tocontext.sourceCode for ESLint v10 compatibility. |
| scripts/eslint/rules/argument-trivia.cjs | Updatememoize JSDoc type and usecontext.sourceCode. |
| scripts/build/utils.mjs | Updatememoize JSDoc type to usetypeof unset. |
| package.json | Upgrade lint/tooling dependencies; remove formatter dependency. |
| knip.jsonc | Remove deleted formatter fromignoreDependencies. |
| eslint.config.mjs | Update regexp plugin config reference; disable new ESLint v10 rules. |
| Herebyfile.mjs | Remove custom formatter selection fromlint task invocation. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
DanielRosenwasser approved these changesFeb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some audit issues, but not all.
This pulls in the latest eslint. I've removed
eslint-autolinkable-stylishwhich requires an override to make work with eslint v10, but given VS Code autolinks eslint's default output, I don't think we need it anymore.