- Notifications
You must be signed in to change notification settings - Fork13.2k
fix(lib): reorder Array#reduce/reduceRight overloads in lib.d.ts#63064
Open
taronsung wants to merge 4 commits intomicrosoft:mainfrom
Open
fix(lib): reorder Array#reduce/reduceRight overloads in lib.d.ts#63064taronsung wants to merge 4 commits intomicrosoft:mainfrom
taronsung wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Reorder the overload declarations for reduce and reduceRight in bothReadonlyArray<T> and Array<T> interfaces so the generic <U> overload(with initialValue: U) is checked before the same-type overload(with initialValue: T).This fixes incorrect type inference when calling reduce/reduceRightwith an initial value of a different type than the array elements.Fixesmicrosoft#7014
Author
taronsung commentedJan 29, 2026
@microsoft-github-policy-service agree |
The overload order change affects the displayed type signature andimproves type inference in some cases (e.g., anyInferenceAnonymousFunctionsnow correctly infers any[] instead of any when reduce is called with []as the initial value).
c9dc0ef to3efe7e1Compare3efe7e1 to4601242Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorder the overload declarations for
reduceandreduceRightin bothReadonlyArray<T>andArray<T>interfaces so the generic<U>overload (withinitialValue: U) is checked before the same-type overload (withinitialValue: T).Problem
When calling
reducewith an initial value of a different type than the array elements, TypeScript incorrectly infers the return type. This is because TypeScript checks overloads in declaration order, and theinitialValue: Toverload matches before the generic<U>overload gets a chance.Example from#7014:
Solution
Swap the order of the two overloads that take an
initialValueparameter:reduce(cb, initialValue: T)thenreduce<U>(cb, initialValue: U)reduce<U>(cb, initialValue: U)thenreduce(cb, initialValue: T)The same change is applied to both
reduceandreduceRightin bothReadonlyArray<T>andArray<T>.Fixes#7014