NotificationsYou must be signed in to change notification settings
Fork13.2k
Star107k

Fixed`silentNeverType` leak by propagating it through`getIndexType`#62825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

Andarist wants to merge2 commits intomicrosoft:main

base:main

Choose a base branch

fromAndarist:fix/silent-never-leak-index-type

Draft

Fixed`silentNeverType` leak by propagating it through`getIndexType`#62825

Andarist wants to merge2 commits intomicrosoft:mainfromAndarist:fix/silent-never-leak-index-type

+1,933 −1

Conversation

Copy link

Contributor

Andarist commentedDec 2, 2025

fixes#62824

github-project-automationbot added this toPR Backlog

Dec 2, 2025

github-project-automationbot moved this toNot started inPR Backlog

Dec 2, 2025

typescript-bot added the For Uncommitted BugPR for untriaged, rejected, closed or missing bug label

Dec 2, 2025

FixedsilentNeverType leak by propagating it throughgetIndexType

59bda8f

Andarist force-pushed thefix/silent-never-leak-index-type branch from7565a32 to59bda8fCompare

December 2, 2025 22:11

typescript-bot added For Backlog BugPRs that fix a backlog bug and removed For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

Dec 3, 2025

add tests

2af1bf0

jakebailey approved these changes

Dec 5, 2025

View reviewed changes

github-project-automationbot moved this fromNot started toNeeds merge inPR Backlog

Dec 5, 2025

Copy link

Member

jakebailey commentedDec 5, 2025

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedDec 5, 2025•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedDec 5, 2025

Hey@jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedDec 5, 2025

@jakebailey Here are the results of running the user tests with tsc comparingmain andrefs/pull/62825/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

Copy link

Collaborator

typescript-bot commentedDec 5, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,387	_50,387	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,644k (± 0.71%)}	_{196,209k (± 0.13%)}	_~	_195,779k	_196,520k	_{p=0.423 n=6}
_{Parse Time}	_{1.59s (± 1.73%)}	_{1.60s (± 1.23%)}	_~	_1.57s	_1.62s	_{p=0.368 n=6}
_{Bind Time}	_{0.91s (± 1.89%)}	_{0.90s (± 1.66%)}	_~	_0.89s	_0.93s	_{p=0.563 n=6}
_{Check Time}	_{11.95s (± 0.68%)}	_{11.98s (± 0.62%)}	_~	_11.90s	_12.10s	_{p=0.336 n=6}
_{Emit Time}	_{3.36s (± 3.63%)}	_{3.47s (± 5.18%)}	_~	_3.27s	_3.71s	_{p=0.199 n=6}
_{Total Time}	_{17.81s (± 0.73%)}	_{17.96s (± 0.69%)}	_~	_17.82s	_18.14s	_{p=0.128 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_956,050	_956,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_415,908	_415,908	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,255,236k (± 0.00%)}	_{1,255,185k (± 0.01%)}	_~	_1,255,074k	_1,255,251k	_{p=0.128 n=6}
_{Parse Time}	_{7.97s (± 0.88%)}	_{8.03s (± 0.53%)}	_~	_7.98s	_8.09s	_{p=0.199 n=6}
_{Bind Time}	_{2.34s (± 0.63%)}	_{2.34s (± 0.54%)}	_~	_2.32s	_2.35s	_{p=0.869 n=6}
_{Check Time}	_{38.50s (± 0.27%)}	_{38.60s (± 0.41%)}	_~	_38.29s	_38.75s	_{p=0.092 n=6}
_{Emit Time}	_{17.79s (± 0.63%)}	_{17.78s (± 0.77%)}	_~	_17.68s	_17.98s	_{p=0.687 n=6}
_{Total Time}	_{66.60s (± 0.26%)}	_{66.74s (± 0.31%)}	_~	_66.38s	_66.96s	_{p=0.229 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,722,130	_2,722,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_937,535	_937,535	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,051,229k (± 0.01%)}	_{3,051,154k (± 0.00%)}	_~	_3,051,020k	_3,051,367k	_{p=0.575 n=6}
_{Parse Time}	_{10.45s (± 0.39%)}	_{10.47s (± 0.54%)}	_~	_10.40s	_10.53s	_{p=0.871 n=6}
_{Bind Time}	_{2.80s (± 0.98%)}	_{2.82s (± 0.47%)}	_~	_2.80s	_2.84s	_{p=0.418 n=6}
_{Check Time}	_{114.33s (± 1.38%)}	_{112.23s (± 0.47%)}	_{-2.10s (- 1.83%)}	_111.52s	_113.07s	_{p=0.020 n=6}
_{Emit Time}	_{0.38s (± 2.74%)}	_{0.38s (± 1.08%)}	_~	_0.37s	_0.38s	_{p=0.924 n=6}
_{Total Time}	_{127.96s (± 1.25%)}	_{125.90s (± 0.42%)}	_{-2.06s (- 1.61%)}	_125.24s	_126.74s	_{p=0.016 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,049	_1,252,049	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,840	_259,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,003,894k (± 9.90%)}	_{3,125,587k (± 0.03%)}	_~	_3,124,430k	_3,126,583k	_{p=0.575 n=6}
_{Parse Time}	_{6.61s (± 1.43%)}	_{6.71s (± 0.82%)}	_{+0.10s (+ 1.54%)}	_6.62s	_6.77s	_{p=0.045 n=6}
_{Bind Time}	_{2.23s (± 1.68%)}	_{2.18s (± 1.32%)}	_{-0.05s (- 2.09%)}	_2.15s	_2.23s	_{p=0.024 n=6}
_{Check Time}	_{43.03s (± 0.41%)}	_{43.09s (± 0.27%)}	_~	_43.01s	_43.32s	_{p=0.575 n=6}
_{Emit Time}	_{3.52s (± 2.45%)}	_{3.42s (± 2.80%)}	_~	_3.28s	_3.54s	_{p=0.128 n=6}
_{Total Time}	_{55.39s (± 0.29%)}	_{55.42s (± 0.17%)}	_~	_55.31s	_55.53s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,252,049	_1,252,049	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,840	_259,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,188,530k (± 0.02%)}	_{3,188,965k (± 0.02%)}	_~	_3,188,285k	_3,189,603k	_{p=0.298 n=6}
_{Parse Time}	_{6.81s (± 0.81%)}	_{6.83s (± 0.77%)}	_~	_6.76s	_6.88s	_{p=0.575 n=6}
_{Bind Time}	_{2.25s (± 0.93%)}	_{2.25s (± 1.75%)}	_~	_2.17s	_2.28s	_{p=0.872 n=6}
_{Check Time}	_{43.19s (± 0.36%)}	_{43.18s (± 0.28%)}	_~	_43.07s	_43.40s	_{p=1.000 n=6}
_{Emit Time}	_{3.48s (± 1.21%)}	_{3.52s (± 1.48%)}	_~	_3.45s	_3.58s	_{p=0.298 n=6}
_{Total Time}	_{55.73s (± 0.32%)}	_{55.77s (± 0.16%)}	_~	_55.65s	_55.89s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_264,682	_264,682	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,051	_104,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{443,376k (± 0.00%)}	_{443,369k (± 0.01%)}	_~	_443,308k	_443,447k	_{p=0.689 n=6}
_{Parse Time}	_{3.51s (± 0.83%)}	_{3.53s (± 0.77%)}	_~	_3.49s	_3.57s	_{p=0.469 n=6}
_{Bind Time}	_{1.37s (± 1.34%)}	_{1.37s (± 1.28%)}	_~	_1.34s	_1.39s	_{p=0.685 n=6}
_{Check Time}	_{19.19s (± 0.58%)}	_{19.17s (± 0.24%)}	_~	_19.12s	_19.22s	_{p=1.000 n=6}
_{Emit Time}	_{1.55s (± 1.49%)}	_{1.53s (± 1.22%)}	_~	_1.51s	_1.56s	_{p=0.226 n=6}
_{Total Time}	_{25.63s (± 0.40%)}	_{25.60s (± 0.24%)}	_~	_25.51s	_25.68s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,493	_225,493	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,373	_94,373	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,169k (± 0.02%)}	_{370,203k (± 0.04%)}	_~	_370,102k	_370,457k	_{p=1.000 n=6}
_{Parse Time}	_{2.84s (± 0.79%)}	_{2.84s (± 0.91%)}	_~	_2.81s	_2.88s	_{p=0.746 n=6}
_{Bind Time}	_{1.64s (± 1.12%)}	_{1.65s (± 1.31%)}	_~	_1.62s	_1.68s	_{p=0.217 n=6}
_{Check Time}	_{16.58s (± 0.41%)}	_{16.65s (± 0.33%)}	_~	_16.57s	_16.70s	_{p=0.127 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.06s (± 0.37%)}	_{21.15s (± 0.32%)}	_~	_21.08s	_21.26s	_{p=0.128 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_4,080,068	_4,080,068	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,285,601	_1,285,601	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,865,387k (± 0.00%)}	_{3,865,419k (± 0.00%)}	_~	_3,865,289k	_3,865,533k	_{p=0.521 n=6}
_{Parse Time}	_{12.89s (± 0.27%)}	_{12.87s (± 0.18%)}	_~	_12.85s	_12.90s	_{p=0.418 n=6}
_{Bind Time}	_{4.38s (± 0.44%)}	_{4.38s (± 0.49%)}	_~	_4.35s	_4.41s	_{p=0.935 n=6}
_{Check Time}	_{94.13s (± 0.31%)}	_{94.94s (± 1.74%)}	_~	_94.04s	_98.26s	_{p=0.471 n=6}
_{Emit Time}	_{31.48s (± 0.31%)}	_{32.30s (± 6.15%)}	_~	_31.38s	_36.36s	_{p=0.521 n=6}
_{Total Time}	_{142.88s (± 0.23%)}	_{144.49s (± 2.52%)}	_~	_142.83s	_151.89s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₀	₄₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_380,702	_380,702	_~	_~	_~	_{p=1.000 n=6}
_Types	_166,804	_166,804	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{540,806k (± 0.02%)}	_{540,903k (± 0.02%)}	_~	_540,772k	_541,050k	_{p=0.378 n=6}
_{Parse Time}	_{4.73s (± 0.67%)}	_{4.74s (± 0.90%)}	_~	_4.68s	_4.80s	_{p=0.747 n=6}
_{Bind Time}	_{2.03s (± 1.33%)}	_{2.04s (± 1.09%)}	_~	_2.01s	_2.06s	_{p=0.462 n=6}
_{Check Time}	_{22.98s (± 0.46%)}	_{23.02s (± 0.56%)}	_~	_22.91s	_23.26s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.73s (± 0.39%)}	_{29.79s (± 0.46%)}	_~	_29.67s	_30.05s	_{p=0.630 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₅₅	_{🔻+25 (+83.33%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_692,951	_693,344	_{+393 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_Types	_210,424	_210,839	_{+415 (+ 0.20%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{588,940k (± 0.03%)}	_{589,393k (± 0.02%)}	_{+454k (+ 0.08%)}	_589,281k	_589,497k	_{p=0.005 n=6}
_{Parse Time}	_{4.18s (± 0.81%)}	_{4.20s (± 0.66%)}	_~	_4.16s	_4.23s	_{p=0.466 n=6}
_{Bind Time}	_{1.42s (± 0.44%)}	_{1.42s (± 1.60%)}	_~	_1.40s	_1.46s	_{p=0.676 n=6}
_{Check Time}	_{21.49s (± 1.68%)}	_{21.52s (± 2.47%)}	_~	_20.84s	_22.20s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=0.595 n=6}
_{Total Time}	_{27.09s (± 1.31%)}	_{27.15s (± 2.04%)}	_~	_26.44s	_27.82s	_{p=0.471 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Member

jakebailey commentedDec 5, 2025

Big xstate regression it seems

Copy link

Collaborator

typescript-bot commentedDec 5, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/62825/merge:

Everything looks good!

Copy link

Member

jakebailey commentedDec 5, 2025

@typescript-bot pack this

Copy link

Collaborator

typescript-bot commentedDec 5, 2025•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

Copy link

Collaborator

typescript-bot commentedDec 5, 2025•
edited
Loading

Hey@jakebailey, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166714/artifacts?artifactName=tgz&fileId=1265CC202DCC49DEA2B1D246A939D00563E44CC67B2EE06ABBB5368D2A608AD602&fileName=/typescript-6.0.0-insiders.20251205.tgz"    }}

and then runningnpm install.

There is also a playgroundfor this build and annpm module you can use via"typescript": "npm:@typescript-deploys/pr-build@6.0.0-pr-62825-9".;

Andarist marked this pull request as draft

December 6, 2025 17:03

Labels

For Backlog Bug

PRs that fix a backlog bug

Movatterモバイル変換

FixedsilentNeverType leak by propagating it throughgetIndexType#62825

Are you sure you want to change the base?

FixedsilentNeverType leak by propagating it throughgetIndexType#62825

Conversation

Andarist commentedDec 2, 2025

Uh oh!

jakebailey commentedDec 5, 2025

Uh oh!

typescript-bot commentedDec 5, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedDec 5, 2025

Uh oh!

typescript-bot commentedDec 5, 2025

Uh oh!

typescript-bot commentedDec 5, 2025

tsc

Uh oh!

jakebailey commentedDec 5, 2025

Uh oh!

typescript-bot commentedDec 5, 2025

Uh oh!

jakebailey commentedDec 5, 2025

Uh oh!

typescript-bot commentedDec 5, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedDec 5, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fixed`silentNeverType` leak by propagating it through`getIndexType`#62825

Fixed`silentNeverType` leak by propagating it through`getIndexType`#62825

typescript-bot commentedDec 5, 2025•
edited
Loading

typescript-bot commentedDec 5, 2025•
edited
Loading

typescript-bot commentedDec 5, 2025•
edited
Loading