Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix completions for generic overloads with mixed function/object parameters#62763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
PaulyBearCoding wants to merge1 commit intomicrosoft:main
base:main
Choose a base branch
Loading
fromPaulyBearCoding:fix-62693-generic-overload-completions

Conversation

@PaulyBearCoding
Copy link

Fixes#62693

Problem

When a generic function has overloads with mixed parameter types (function vs object literal), TypeScript shows incorrect completions for object literals. For example:

declarefunctiontask<T>(make:()=>T):voiddeclarefunctiontask<T>(arg:{make:()=>T}):voidtask({// BUG: Shows bind, call, apply instead of "make"})

The editor shows function properties (bind, call, apply) instead of the expected object property "make".

Root Cause

During completion, generic type inference is blocked (type parameters are unknown). WhenchooseOverload evaluates candidates, it:

  1. Attempts to resolve the function-type overload first
  2. Cannot inferT during completion context
  3. Falls back to treating the object literal as a function type
  4. Returns function properties instead of object properties

The issue occurs because overload selection doesn't account for the syntactic context (completing an object literal) when generic inference is unavailable.

Solution

The fix tracks which argument position is being completed and uses this information during overload resolution to prefer object-type overloads when completing object literals.

Changes

types.ts (line 6311):
AddedcompletionArgumentIndex to NodeLinks to track which argument is being completed.

checker.ts (lines 32072-32076):
Store the argument index when inference is blocked during completion:

if(isInferencePartiallyBlocked){links.completionArgumentIndex=argIndex;}

checker.ts (lines 36728-36832):
EnhancedchooseOverload to:

  1. Detect when completing an object literal at argument position 0
  2. Skip overload candidates with function-type parameters
  3. Accept object-type overload candidates even if the literal is incomplete

This allows the type checker to select the correct overload based on syntactic context rather than relying solely on type inference.

Why This Works

The fix is surgical and only affects generic overload resolution during completion:

  • Targeted scope: Only triggers for object literals at argument 0 with blocked inference
  • Preserved behavior: Non-generic overloads and other arguments remain unchanged
  • Syntactic guidance: Uses the object literal syntax to disambiguate overloads when type inference is unavailable

The approach respects TypeScript's existing completion infrastructure while providing better overload selection for this specific edge case.

Testing

Added comprehensive test coverage incompletionForGenericOverloadObjectLiteral.ts:

  • Generic function-first overload (the bug)
  • Generic object-first overload (control)
  • Non-generic overload (control)
  • Multiple type parameters with optional properties (rigorous)

All tests verify that object properties appear in completions and function properties (bind, call, apply) are correctly excluded.

Test results: 99,000 passing, 0 regressions

…metersFixesmicrosoft#62693## ProblemWhen a generic function has overloads with mixed parameter types (function vs object literal), TypeScript shows incorrect completions for object literals. For example:```typescriptdeclare function task<T>(make: () => T): voiddeclare function task<T>(arg: {make: () => T}): voidtask({    // BUG: Shows bind, call, apply instead of "make"})```The editor shows function properties (bind, call, apply) instead of the expected object property "make".## Root CauseDuring completion, generic type inference is blocked (type parameters are unknown). When `chooseOverload` evaluates candidates, it:1. Attempts to resolve the function-type overload first2. Cannot infer `T` during completion context3. Falls back to treating the object literal as a function type4. Returns function properties instead of object propertiesThe issue occurs because overload selection doesn't account for the syntactic context (completing an object literal) when generic inference is unavailable.## SolutionThe fix tracks which argument position is being completed and uses this information during overload resolution to prefer object-type overloads when completing object literals.### Changes**types.ts (line 6311):**Added `completionArgumentIndex` to NodeLinks to track which argument is being completed.**checker.ts (lines 32072-32076):**Store the argument index when inference is blocked during completion:```typescriptif (isInferencePartiallyBlocked) {    links.completionArgumentIndex = argIndex;}```**checker.ts (lines 36728-36832):**Enhanced `chooseOverload` to:1. Detect when completing an object literal at argument position 02. Skip overload candidates with function-type parameters3. Accept object-type overload candidates even if the literal is incompleteThis allows the type checker to select the correct overload based on syntactic context rather than relying solely on type inference.## Why This WorksThe fix is surgical and only affects generic overload resolution during completion:- **Targeted scope:** Only triggers for object literals at argument 0 with blocked inference- **Preserved behavior:** Non-generic overloads and other arguments remain unchanged- **Syntactic guidance:** Uses the object literal syntax to disambiguate overloads when type inference is unavailableThe approach respects TypeScript's existing completion infrastructure while providing better overload selection for this specific edge case.## TestingAdded comprehensive test coverage in `completionForGenericOverloadObjectLiteral.ts`:- Generic function-first overload (the bug)- Generic object-first overload (control)- Non-generic overload (control)- Multiple type parameters with optional properties (rigorous)All tests verify that object properties appear in completions and function properties (bind, call, apply) are correctly excluded.Test results: 99,000 passing, 0 regressions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Status: Not started

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intellisense displays function props instead of object's in generic function overload

1 participant

@PaulyBearCoding

[8]ページ先頭

©2009-2025 Movatter.jp