- Notifications
You must be signed in to change notification settings - Fork13.1k
Implement TypeScript 6.0 deprecation ofmodule
keyword for namespace declarations#62390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge13 commits intomainChoose a base branch fromcopilot/fix-62211
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
Changes from1 commit
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
88b137f
Initial plan
Copilot7cbbb7e
Implement TypeScript 6.0 deprecation of module keyword for namespaces
Copilot381d4a6
Apply code formatting
Copilotdcfee6e
Update test baselines for module keyword deprecation errors
Copilot3a60026
Remove version comparison logic and fix diagnostic message ordering
Copilot0ebcdd1
Update test files to use namespace instead of module keyword
Copilote6ee96d
Fix lint errors by removing unused imports and apply formatting
Copilot8387013
Update additional test files with comprehensive module-to-namespace r…
Copilot492692e
Fix code style and update test files to use namespace instead of module
Copilote93fa38
Update remaining test files to use namespace instead of module keyword
Copilot6e09dc2
Update baselines
RyanCavanaugh116285f
Update remaining test files to replace module with namespace declarat…
Copilot3e0cdbd
Fix all remaining module declarations in test files
CopilotFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update remaining test files to use namespace instead of module keyword
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commite93fa3800cf94c84583de2694bd07eba1a491c22
There are no files selected for viewing
84 changes: 0 additions & 84 deletionstests/baselines/reference/augmentExportEquals5.errors.txt
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
2 changes: 1 addition & 1 deletiontests/baselines/reference/augmentExportEquals5.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletionstests/baselines/reference/augmentExportEquals5.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 changes: 1 addition & 6 deletionstests/baselines/reference/augmentExportEquals5.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
40 changes: 20 additions & 20 deletionstests/cases/compiler/aliasBug.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
// @module: commonjs | ||
namespace foo { | ||
export class Provide { | ||
} | ||
export namespace bar { exportnamespace baz {export class boo {}}} | ||
} | ||
import provide = foo; | ||
import booz = foo.bar.baz; | ||
var p = new provide.Provide(); | ||
function use() { | ||
var p1: provide.Provide; // error here, but should be okay | ||
var p2: foo.Provide; | ||
var p3:booz.bar; | ||
var p22 = new provide.Provide(); | ||
} |
58 changes: 29 additions & 29 deletionstests/cases/compiler/aliasErrors.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,29 @@ | ||
namespace foo { | ||
export class Provide { | ||
} | ||
export namespace bar { exportnamespace baz {export class boo {}}} | ||
} | ||
import provide = foo; | ||
import booz = foo.bar.baz; | ||
import beez = foo.bar; | ||
import m = no; | ||
import m2 = no.mod; | ||
import n = 5; | ||
import o = "s"; | ||
import q = null; | ||
import r = undefined; | ||
var p = new provide.Provide(); | ||
function use() { | ||
beez.baz.boo; | ||
var p1: provide.Provide; | ||
var p2: foo.Provide; | ||
var p3:booz.bar; | ||
var p22 = new provide.Provide(); | ||
} | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.