NotificationsYou must be signed in to change notification settings
Fork12.9k
Star105k

fix(Intl): make Intl.Collator.compare a getter that returns a bound function (#62048)#62052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ahsansheikh94 wants to merge2 commits intomicrosoft:main

base:main

Choose a base branch

fromahsansheikh94:fix-intl-collator-compare-type

Open

fix(Intl): make Intl.Collator.compare a getter that returns a bound function (#62048)#62052

ahsansheikh94 wants to merge2 commits intomicrosoft:mainfromahsansheikh94:fix-intl-collator-compare-type

Conversation

Copy link

ahsansheikh94 commentedJul 12, 2025•
edited
Loading

What this PR does

This PR updates the type definition forIntl.Collator.prototype.compare to align with the ECMAScript specification.

Previously, compare was declared as a method:
compare(x: string, y: string): number;

According to the spec, it is agetter that returns a bound function:
get compare(): (this: void, x: string, y: string) => number;

Changing this to a getter would cause conflicts with the existing implementations as pointed out by@Renegade334.
Instead adding athis: void gets the job done.

Changes made

Updated theIntl.Collator interface insrc/lib/es5.d.ts:
Added a new conformance test intests/cases/conformance/intl/collatorCompareBoundFunction.ts