- Notifications
You must be signed in to change notification settings - Fork12.9k
Fix JSDoc @import crashes in getCompletionEntryDetails#62028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/fix-62027
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
@import
causesgetCompletionEntryDetails
to crashCopilot finished work on behalf ofRyanCavanaughJuly 9, 2025 16:28
louwers left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Needs a regression test?
louwers commentedJul 9, 2025
Seems to work. |
louwers commentedJul 16, 2025
@RyanCavanaugh Could you nudge Copilot to add a unit test? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The completion system was crashing when trying to get completion entry details for JSDoc
@import
statements. Consider:The error was:
Root Cause:
The completion system tries to promote type-only imports to regular imports when they are used in value contexts. For JSDoc
@import
statements, this promotion logic incorrectly assumed the import had atype
keyword that could be found and removed, but JSDoc imports don't have this structure - they are inherently type-only.Solution:
Added a check in
promoteImportClause
function to skip type keyword deletion for JSDoc imports:This allows JSDoc imports to be safely handled during the completion promotion process without attempting to remove a non-existent
type
keyword.Fixes#62027.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.