NotificationsYou must be signed in to change notification settings
Fork12.9k
Star105k

Force inclusion of ES6, DOM.Iterable#62025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

jakebailey wants to merge4 commits intomicrosoft:main

base:main

Choose a base branch

fromjakebailey:force-es6-dom-iterable

Draft

Force inclusion of ES6, DOM.Iterable#62025

jakebailey wants to merge4 commits intomicrosoft:mainfromjakebailey:force-es6-dom-iterable

Conversation

Copy link

Member

jakebailey commentedJul 9, 2025

Playing around for#54500

jakebailey added4 commits

July 8, 2025 21:41

Force inclusion of ES6, DOM iterable variants

b5278c6

not async

4cb902d

Skip self ref

93e344b

Accept baselines

7c3f618

typescript-bot assignedjakebailey

Jul 9, 2025

typescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

Jul 9, 2025

Copy link

MemberAuthor

jakebailey commentedJul 9, 2025

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedJul 9, 2025•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

jakebailey changed the title~~Force inclusion of ES6, DOM.iterable~~Force inclusion of ES6, DOM.Iterable

Jul 9, 2025

Copy link

Collaborator

typescript-bot commentedJul 9, 2025

Hey@jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Changes are too big to display here, please checkthe log.

You can check the log here.

Copy link

Collaborator

typescript-bot commentedJul 9, 2025

@jakebailey Here are the results of running the user tests with tsc comparingmain andrefs/pull/62025/merge:

Everything looks good!

Copy link

Collaborator

typescript-bot commentedJul 9, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_78,849	_{🔻+16,479 (+26.42%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,386	_56,396	_{🔻+6,010 (+11.93%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{194,841k (± 1.01%)}	_{206,173k (± 0.95%)}	_{🔻+11,333k (+ 5.82%)}	_204,375k	_207,997k	_{p=0.005 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.34s (± 0.38%)}	_{+0.04s (+ 2.81%)}	_1.34s	_1.35s	_{p=0.004 n=6}
_{Bind Time}	_0.73s	_{0.74s (± 0.55%)}	_{+0.01s (+ 1.14%)}	_0.73s	_0.74s	_{p=0.007 n=6}
_{Check Time}	_{9.74s (± 0.38%)}	_{10.29s (± 0.33%)}	_{🔻+0.56s (+ 5.72%)}	_10.24s	_10.34s	_{p=0.005 n=6}
_{Emit Time}	_{2.73s (± 0.36%)}	_{2.75s (± 1.10%)}	_~	_2.71s	_2.79s	_{p=0.462 n=6}
_{Total Time}	_{14.51s (± 0.24%)}	_{15.12s (± 0.31%)}	_{🔻+0.61s (+ 4.23%)}	_15.07s	_15.20s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₇	₅₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,912	_948,912	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,889	_410,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,421k (± 0.00%)}	_{1,226,408k (± 0.00%)}	_~	_1,226,342k	_1,226,467k	_{p=1.000 n=6}
_{Parse Time}	_{6.51s (± 0.91%)}	_{6.51s (± 0.50%)}	_~	_6.46s	_6.55s	_{p=0.423 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_1.88s	_~	_~	_~	_{p=0.071 n=6}
_{Check Time}	_{32.04s (± 0.33%)}	_{32.01s (± 0.24%)}	_~	_31.91s	_32.10s	_{p=0.936 n=6}
_{Emit Time}	_{14.88s (± 0.60%)}	_{14.85s (± 0.71%)}	_~	_14.74s	_15.05s	_{p=0.688 n=6}
_{Total Time}	_{55.30s (± 0.35%)}	_{55.25s (± 0.32%)}	_~	_55.04s	_55.52s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,510,641	_2,510,641	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,802	_892,802	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,805,600k (± 0.00%)}	_{2,805,651k (± 0.00%)}	_~	_2,805,594k	_2,805,683k	_{p=0.065 n=6}
_{Parse Time}	_{8.70s (± 0.50%)}	_{8.71s (± 0.21%)}	_~	_8.68s	_8.73s	_{p=0.567 n=6}
_{Bind Time}	_{2.24s (± 0.34%)}	_{2.24s (± 0.71%)}	_~	_2.22s	_2.26s	_{p=0.801 n=6}
_{Check Time}	_{84.74s (± 0.24%)}	_{84.86s (± 0.38%)}	_~	_84.32s	_85.23s	_{p=0.378 n=6}
_{Emit Time}	_0.30s	_{0.30s (± 1.35%)}	_~	_0.30s	_0.31s	_{p=0.405 n=6}
_{Total Time}	_{95.99s (± 0.21%)}	_{96.11s (± 0.32%)}	_~	_95.59s	_96.42s	_{p=0.296 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,048	_1,227,053	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,470	_267,471	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,363,209k (± 0.02%)}	_{2,484,866k (±11.99%)}	_~	_2,362,796k	_3,093,893k	_{p=0.689 n=6}
_{Parse Time}	_{5.25s (± 1.18%)}	_{5.26s (± 1.68%)}	_~	_5.21s	_5.44s	_{p=1.000 n=6}
_{Bind Time}	_{1.78s (± 0.83%)}	_{1.78s (± 0.59%)}	_~	_1.76s	_1.79s	_{p=0.413 n=6}
_{Check Time}	_{35.34s (± 0.20%)}	_{35.41s (± 0.36%)}	_~	_35.20s	_35.56s	_{p=0.230 n=6}
_{Emit Time}	_{2.98s (± 1.42%)}	_{3.01s (± 1.87%)}	_~	_2.96s	_3.11s	_{p=0.630 n=6}
_{Total Time}	_{45.36s (± 0.30%)}	_{45.46s (± 0.43%)}	_~	_45.19s	_45.79s	_{p=0.199 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,048	_1,227,053	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,470	_267,471	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,919,572k (±12.87%)}	_{2,919,431k (±12.83%)}	_~	_2,433,605k	_3,162,656k	_{p=0.575 n=6}
_{Parse Time}	_{6.84s (± 1.56%)}	_{6.87s (± 1.63%)}	_~	_6.72s	_7.03s	_{p=0.689 n=6}
_{Bind Time}	_{2.19s (± 0.82%)}	_{2.20s (± 2.38%)}	_~	_2.12s	_2.26s	_{p=0.469 n=6}
_{Check Time}	_{42.98s (± 0.51%)}	_{42.93s (± 0.63%)}	_~	_42.51s	_43.22s	_{p=0.936 n=6}
_{Emit Time}	_{3.52s (± 2.64%)}	_{3.50s (± 2.67%)}	_~	_3.37s	_3.61s	_{p=0.810 n=6}
_{Total Time}	_{55.52s (± 0.69%)}	_{55.49s (± 0.64%)}	_~	_54.98s	_55.88s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,553	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,156	_107,157	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,930k (± 0.00%)}	_{441,933k (± 0.02%)}	_~	_441,827k	_442,059k	_{p=0.873 n=6}
_{Parse Time}	_{3.52s (± 1.25%)}	_{3.54s (± 1.32%)}	_~	_3.47s	_3.59s	_{p=0.374 n=6}
_{Bind Time}	_{1.32s (± 1.34%)}	_{1.32s (± 1.00%)}	_~	_1.31s	_1.34s	_{p=0.546 n=6}
_{Check Time}	_{18.91s (± 0.43%)}	_{18.96s (± 0.43%)}	_~	_18.87s	_19.09s	_{p=0.423 n=6}
_{Emit Time}	_{1.52s (± 0.77%)}	_{1.54s (± 1.46%)}	_~	_1.52s	_1.57s	_{p=0.084 n=6}
_{Total Time}	_{25.27s (± 0.31%)}	_{25.36s (± 0.40%)}	_~	_25.26s	_25.52s	_{p=0.108 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,165k (± 0.01%)}	_{371,143k (± 0.02%)}	_~	_371,043k	_371,208k	_{p=0.575 n=6}
_{Parse Time}	_{3.59s (± 1.04%)}	_{3.60s (± 2.05%)}	_~	_3.47s	_3.66s	_{p=0.520 n=6}
_{Bind Time}	_{1.99s (± 1.00%)}	_{1.97s (± 0.53%)}	_{-0.03s (- 1.26%)}	_1.95s	_1.98s	_{p=0.035 n=6}
_{Check Time}	_{20.43s (± 0.23%)}	_{20.43s (± 0.41%)}	_~	_20.34s	_20.56s	_{p=0.687 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.02s (± 0.17%)}	_{26.00s (± 0.45%)}	_~	_25.88s	_26.16s	_{p=0.574 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,500,100	_3,500,100	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,179,991	_1,179,991	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,546,365k (± 0.01%)}	_{3,546,206k (± 0.00%)}	_~	_3,545,985k	_3,546,386k	_{p=0.471 n=6}
_{Parse Time}	_{15.02s (± 0.75%)}	_{15.00s (± 0.79%)}	_~	_14.86s	_15.17s	_{p=0.748 n=6}
_{Bind Time}	_{5.01s (± 2.43%)}	_{5.00s (± 2.55%)}	_~	_4.86s	_5.15s	_{p=0.936 n=6}
_{Check Time}	_{99.62s (± 1.77%)}	_{99.10s (± 1.36%)}	_~	_98.11s	_101.68s	_{p=0.810 n=6}
_{Emit Time}	_{30.16s (± 0.54%)}	_{30.16s (± 1.86%)}	_~	_29.03s	_30.48s	_{p=0.173 n=6}
_{Total Time}	_{149.80s (± 1.25%)}	_{149.25s (± 1.04%)}	_~	_147.42s	_152.06s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_318,567	_319,853	_{+1,286 (+ 0.40%)}	_~	_~	_{p=0.001 n=6}
_Types	_137,774	_138,310	_{+536 (+ 0.39%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{474,039k (± 0.03%)}	_{475,700k (± 0.03%)}	_{+1,661k (+ 0.35%)}	_475,498k	_475,821k	_{p=0.005 n=6}
_{Parse Time}	_{4.28s (± 0.50%)}	_{4.31s (± 0.96%)}	_~	_4.25s	_4.37s	_{p=0.198 n=6}
_{Bind Time}	_{1.78s (± 1.27%)}	_{1.79s (± 0.96%)}	_~	_1.76s	_1.81s	_{p=0.365 n=6}
_{Check Time}	_{20.59s (± 0.43%)}	_{20.82s (± 0.43%)}	_{+0.23s (+ 1.14%)}	_20.71s	_20.92s	_{p=0.010 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.65s (± 0.40%)}	_{26.92s (± 0.31%)}	_{+0.27s (+ 1.03%)}	_26.79s	_27.01s	_{p=0.008 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_666,092	_666,742	_{+650 (+ 0.10%)}	_~	_~	_{p=0.001 n=6}
_Types	_199,363	_199,365	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{571,550k (± 0.02%)}	_{572,331k (± 0.02%)}	_{+781k (+ 0.14%)}	_572,223k	_572,527k	_{p=0.005 n=6}
_{Parse Time}	_{4.26s (± 0.46%)}	_{4.26s (± 0.45%)}	_~	_4.24s	_4.29s	_{p=1.000 n=6}
_{Bind Time}	_{1.32s (± 1.11%)}	_{1.34s (± 1.05%)}	_~	_1.32s	_1.36s	_{p=0.073 n=6}
_{Check Time}	_{20.09s (± 1.56%)}	_{20.43s (± 1.85%)}	_~	_19.91s	_20.71s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.67s (± 1.25%)}	_{26.03s (± 1.50%)}	_~	_25.52s	_26.35s	_{p=0.173 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedJul 9, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/62025/merge:

Something interesting changed - please have a look.

Details

BuilderIO/mitosis

17 of 25 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.build.json

error TS2345: Argument of type '{ code: { bindings: Record<string, string>; actions: { [key: string]: string; }; }; properties: Dictionary<any> | undefined; bindings: Record<string, string>; ... 7 more ...; tagName: string | undefined; }' is not assignable to parameter of type 'Partial<BuilderElement>'.
- packages/core/src/generators/builder/generator.ts#L784 inpackages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

test/tsconfig.json

error TS2536: Type 'T' cannot be used to index type 'DOMStringMap'.
- src/BootstrapModalManager.tsx#L32
- src/BootstrapModalManager.tsx#L34

Labels

Author: Team For Uncommitted Bug

PR for untriaged, rejected, closed or missing bug

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Force inclusion of ES6, DOM.Iterable#62025

Are you sure you want to change the base?

Force inclusion of ES6, DOM.Iterable#62025

Uh oh!

Conversation

jakebailey commentedJul 9, 2025

Uh oh!

jakebailey commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025•
edited
Loading

Uh oh!

Uh oh!

typescript-bot commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025

tsc

Uh oh!

typescript-bot commentedJul 9, 2025

BuilderIO/mitosis

packages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

tsconfig.json

test/tsconfig.json

Uh oh!

Uh oh!

Movatterモバイル変換

Force inclusion of ES6, DOM.Iterable#62025

Are you sure you want to change the base?

Force inclusion of ES6, DOM.Iterable#62025

Uh oh!

Conversation

jakebailey commentedJul 9, 2025

Uh oh!

jakebailey commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025

Uh oh!

typescript-bot commentedJul 9, 2025

tsc

Uh oh!

typescript-bot commentedJul 9, 2025

BuilderIO/mitosis

packages/core/tsconfig.build.json

react-bootstrap/react-bootstrap

tsconfig.json

test/tsconfig.json

Uh oh!

Uh oh!

typescript-bot commentedJul 9, 2025•
edited
Loading