- Notifications
You must be signed in to change notification settings - Fork12.9k
Fix diagnostic code 69010 typo to 6910#62007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
69010 may be typo of6910?RyanCavanaugh commentedJul 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Not ideal to edit the lcl files but it doesn't really matter. LGTM. Edit: Nah let's keep the git history clean on those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Revert all changes to the LCL files, these should not be edited by us
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Reverted all LCL file changes as requested. The main diagnosticMessages.json file still contains the fix (code 6910), but all LCL files have been restored to their original state.dc0ec58 |
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes a typo in the diagnostic code from 69010 to 6910 in the diagnosticMessages.json file.
Issue
The diagnostic message
"module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"had code 69010, which appears to be a typo based on the sequential numbering pattern of surrounding diagnostic codes:"trueifcomposite,falseotherwise""module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"←Should be 6910"Computed from the list of input files""Platform specific"Changes Made
src/compiler/diagnosticMessages.jsonsrc/loc/lcl/to use the correct code 6910Verification
The fix is minimal and surgical - only changing the diagnostic code number while preserving all functionality and maintaining the sequential numbering pattern.
Fixes#61971.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.