- Notifications
You must be signed in to change notification settings - Fork12.9k
Restructure CI to prepare for required checks and merge queues#61978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jakebailey wants to merge3 commits intomicrosoft:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR restructures the GitHub Actions CI workflow to support merge queues with a subset of checks and to enforce required checks before merging.
- Introduces a
merge_groupevent trigger for queue-based merges. - Refactors the testing matrix into a single
matrix.configarray with per-item skip flags. - Adds a final
requiredjob that fails if any needed job did not succeed or was not skipped.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:15
- Remove or clarify this commented-out
release-*branch entry undermerge_group. If release branches should also go through merge queues, uncomment it or document the intention to avoid confusion.
# - release-*.github/workflows/ci.yml:31
- [nitpick] The matrix.config section contains many nearly identical entries. Consider using YAML anchors or a small generation script to DRY up the repeated OS/node-version combinations and reduce maintenance overhead.
config:Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This pulls the same method I used in tsgo to add required checks, plus merge queues using only a subset of the checks. Annoying in this repo where we have such a large matrix to write out, but oh well. Supporting this many versions of Node is a temporary problem if anything.
Also, while here, test Node 24.