NotificationsYou must be signed in to change notification settings
Fork12.9k
Star105k

Do not set`valueDeclaration` for intersection properties when one symbol does not have a`valueDeclaration`#61872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

mdm317 wants to merge2 commits intomicrosoft:main

base:main

Choose a base branch

frommdm317:fix-61743-

Open

Do not set`valueDeclaration` for intersection properties when one symbol does not have a`valueDeclaration`#61872

mdm317 wants to merge2 commits intomicrosoft:mainfrommdm317:fix-61743-

Conversation

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

InisConflictingPrivateProperty, if symbols are not uniform and has private properties, determine property is conflict

    function isConflictingPrivateProperty(prop: Symbol) {        // Return true for a synthetic property with multiple declarations, at least one of which is private.        return !prop.valueDeclaration && !!(getCheckFlags(prop) & CheckFlags.ContainsPrivate);    }

Currently, a intersection/uniform property is treated as uniform when one source property has a valueDeclaration, while another source property(mapped type) does not.
I think we should treat such properties as non-uniform instead.

Copy link

Author

mdm317 commentedJun 15, 2025

@microsoft-github-policy-service agree

format

41b6e2a

mdm317 marked this pull request as ready for review

June 15, 2025 16:20

Copy link

Member

jakebailey commentedJun 30, 2025

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedJun 30, 2025•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedJun 30, 2025

Hey@jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedJun 30, 2025

@jakebailey Here are the results of running the user tests with tsc comparingmain andrefs/pull/61872/merge:

Everything looks good!

Copy link

Collaborator

typescript-bot commentedJun 30, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,961k (± 0.76%)}	_{195,909k (± 0.73%)}	_~	_193,004k	_196,672k	_{p=0.575 n=6}
_{Parse Time}	_{1.58s (± 1.68%)}	_{1.60s (± 1.52%)}	_~	_1.56s	_1.63s	_{p=0.366 n=6}
_{Bind Time}	_{0.88s (± 1.24%)}	_{0.87s (± 1.34%)}	_~	_0.85s	_0.88s	_{p=0.170 n=6}
_{Check Time}	_{11.76s (± 0.64%)}	_{11.78s (± 0.42%)}	_~	_11.71s	_11.85s	_{p=0.748 n=6}
_{Emit Time}	_{3.34s (± 3.42%)}	_{3.34s (± 3.63%)}	_~	_3.27s	_3.58s	_{p=0.683 n=6}
_{Total Time}	_{17.57s (± 0.96%)}	_{17.59s (± 0.68%)}	_~	_17.48s	_17.82s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,753	_948,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,846	_410,846	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,205k (± 0.00%)}	_{1,225,206k (± 0.00%)}	_~	_1,225,173k	_1,225,238k	_{p=0.630 n=6}
_{Parse Time}	_{7.90s (± 0.73%)}	_{7.98s (± 0.51%)}	_{+0.07s (+ 0.93%)}	_7.93s	_8.04s	_{p=0.037 n=6}
_{Bind Time}	_{2.29s (± 0.36%)}	_{2.28s (± 0.37%)}	_~	_2.27s	_2.29s	_{p=0.120 n=6}
_{Check Time}	_{38.09s (± 0.42%)}	_{38.10s (± 0.25%)}	_~	_38.03s	_38.28s	_{p=0.808 n=6}
_{Emit Time}	_{17.82s (± 0.49%)}	_{17.85s (± 0.54%)}	_~	_17.74s	_17.98s	_{p=0.748 n=6}
_{Total Time}	_{66.11s (± 0.36%)}	_{66.20s (± 0.16%)}	_~	_66.09s	_66.36s	_{p=0.471 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,509,183	_2,509,183	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,716	_892,716	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,804,513k (± 0.00%)}	_{2,804,431k (± 0.00%)}	_~	_2,804,343k	_2,804,572k	_{p=0.093 n=6}
_{Parse Time}	_{10.46s (± 0.24%)}	_{10.46s (± 0.16%)}	_~	_10.43s	_10.47s	_{p=0.935 n=6}
_{Bind Time}	_{2.71s (± 1.01%)}	_{2.73s (± 0.55%)}	_~	_2.70s	_2.74s	_{p=0.622 n=6}
_{Check Time}	_{100.98s (± 1.03%)}	_{101.23s (± 1.15%)}	_~	_100.05s	_103.13s	_{p=0.873 n=6}
_{Emit Time}	_{0.36s (± 2.24%)}	_{0.37s (± 2.29%)}	_~	_0.35s	_0.37s	_{p=0.485 n=6}
_{Total Time}	_{114.52s (± 0.91%)}	_{114.78s (± 1.01%)}	_~	_113.58s	_116.66s	_{p=0.688 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,853,238k (±13.21%)}	_{2,975,326k (±10.02%)}	_~	_2,365,962k	_3,098,033k	_{p=0.378 n=6}
_{Parse Time}	_{8.25s (± 1.50%)}	_{8.27s (± 1.82%)}	_~	_7.97s	_8.38s	_{p=0.688 n=6}
_{Bind Time}	_{2.68s (± 1.74%)}	_{2.65s (± 1.80%)}	_~	_2.59s	_2.71s	_{p=0.471 n=6}
_{Check Time}	_{53.00s (± 0.54%)}	_{53.18s (± 0.17%)}	_~	_53.07s	_53.31s	_{p=0.575 n=6}
_{Emit Time}	_{4.31s (± 2.19%)}	_{4.31s (± 1.95%)}	_~	_4.23s	_4.44s	_{p=0.630 n=6}
_{Total Time}	_{68.26s (± 0.65%)}	_{68.41s (± 0.33%)}	_~	_68.10s	_68.68s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,430,272k (± 0.02%)}	_{2,551,834k (±11.63%)}	_~	_2,429,873k	_3,158,365k	_{p=0.230 n=6}
_{Parse Time}	_{5.40s (± 0.83%)}	_{5.38s (± 1.35%)}	_~	_5.31s	_5.52s	_{p=0.520 n=6}
_{Bind Time}	_{1.83s (± 0.80%)}	_{1.83s (± 1.17%)}	_~	_1.80s	_1.86s	_{p=0.745 n=6}
_{Check Time}	_{35.27s (± 0.34%)}	_{35.25s (± 0.78%)}	_~	_35.05s	_35.80s	_{p=0.230 n=6}
_{Emit Time}	_{3.04s (± 1.52%)}	_{3.05s (± 1.05%)}	_~	_3.00s	_3.09s	_{p=0.686 n=6}
_{Total Time}	_{45.54s (± 0.26%)}	_{45.51s (± 0.74%)}	_~	_45.32s	_46.19s	_{p=0.261 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,548	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,156	_107,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,920k (± 0.03%)}	_{441,879k (± 0.01%)}	_~	_441,822k	_441,921k	_{p=1.000 n=6}
_{Parse Time}	_{3.52s (± 0.80%)}	_{3.54s (± 0.97%)}	_~	_3.51s	_3.59s	_{p=0.368 n=6}
_{Bind Time}	_{1.32s (± 1.04%)}	_{1.32s (± 0.62%)}	_~	_1.31s	_1.33s	_{p=0.932 n=6}
_{Check Time}	_{18.85s (± 0.38%)}	_{18.93s (± 0.50%)}	_~	_18.84s	_19.08s	_{p=0.261 n=6}
_{Emit Time}	_{1.54s (± 1.35%)}	_{1.52s (± 1.73%)}	_~	_1.50s	_1.56s	_{p=0.366 n=6}
_{Total Time}	_{25.23s (± 0.39%)}	_{25.31s (± 0.48%)}	_~	_25.18s	_25.51s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,081k (± 0.01%)}	_{371,190k (± 0.04%)}	_~	_371,056k	_371,381k	_{p=0.173 n=6}
_{Parse Time}	_{2.86s (± 1.75%)}	_{2.88s (± 0.92%)}	_~	_2.86s	_2.92s	_{p=0.871 n=6}
_{Bind Time}	_{1.58s (± 0.48%)}	_{1.60s (± 1.21%)}	_{+0.02s (+ 1.26%)}	_1.58s	_1.63s	_{p=0.046 n=6}
_{Check Time}	_{16.36s (± 0.25%)}	_{16.35s (± 0.17%)}	_~	_16.32s	_16.40s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.81s (± 0.27%)}	_{20.84s (± 0.12%)}	_~	_20.80s	_20.87s	_{p=0.376 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,499,297	_3,499,297	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,177,214	_1,177,214	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,549,844k (± 0.01%)}	_{3,549,901k (± 0.00%)}	_~	_3,549,714k	_3,550,073k	_{p=0.471 n=6}
_{Parse Time}	_{15.06s (± 0.73%)}	_{15.16s (± 0.60%)}	_~	_15.04s	_15.27s	_{p=0.093 n=6}
_{Bind Time}	_{4.91s (± 0.62%)}	_{4.87s (± 0.30%)}	_{-0.04s (- 0.75%)}	_4.85s	_4.89s	_{p=0.007 n=6}
_{Check Time}	_{96.45s (± 3.21%)}	_{95.93s (± 3.23%)}	_~	_93.85s	_101.70s	_{p=0.471 n=6}
_{Emit Time}	_{31.07s (± 7.59%)}	_{31.07s (± 7.99%)}	_~	_29.41s	_35.90s	_{p=0.810 n=6}
_{Total Time}	_{147.48s (± 3.50%)}	_{147.03s (± 2.46%)}	_~	_143.59s	_152.71s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_318,019	_318,019	_~	_~	_~	_{p=1.000 n=6}
_Types	_137,705	_137,705	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{472,117k (± 0.02%)}	_{472,204k (± 0.03%)}	_~	_472,028k	_472,417k	_{p=0.298 n=6}
_{Parse Time}	_{4.32s (± 0.47%)}	_{4.36s (± 0.76%)}	_~	_4.32s	_4.41s	_{p=0.050 n=6}
_{Bind Time}	_{1.76s (± 2.00%)}	_{1.76s (± 1.29%)}	_~	_1.73s	_1.79s	_{p=0.744 n=6}
_{Check Time}	_{20.65s (± 0.50%)}	_{20.72s (± 0.26%)}	_~	_20.64s	_20.77s	_{p=0.227 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.73s (± 0.44%)}	_{26.83s (± 0.24%)}	_~	_26.75s	_26.90s	_{p=0.128 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_665,978	_665,978	_~	_~	_~	_{p=1.000 n=6}
_Types	_199,345	_199,345	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{570,406k (± 0.01%)}	_{570,405k (± 0.01%)}	_~	_570,284k	_570,540k	_{p=0.689 n=6}
_{Parse Time}	_{4.28s (± 0.38%)}	_{4.26s (± 0.47%)}	_~	_4.24s	_4.29s	_{p=0.157 n=6}
_{Bind Time}	_{1.33s (± 0.57%)}	_{1.33s (± 1.46%)}	_~	_1.31s	_1.36s	_{p=0.742 n=6}
_{Check Time}	_{19.91s (± 0.31%)}	_{19.86s (± 0.25%)}	_~	_19.78s	_19.91s	_{p=0.127 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.52s (± 0.27%)}	_{25.45s (± 0.28%)}	_~	_25.35s	_25.54s	_{p=0.128 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedJul 1, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/61872/merge:

Everything looks good!

Labels

For Backlog Bug

PRs that fix a backlog bug

3 participants

		@@ -15547,7 +15547,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
		let firstValueDeclaration: Declaration \| undefined;
		let hasNonUniformValueDeclaration = false;
		for (const prop of props) {
		if (!firstValueDeclaration) {
		if(!prop.valueDeclaration){

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not set`valueDeclaration` for intersection properties when one symbol does not have a`valueDeclaration`#61872

Are you sure you want to change the base?

Do not set`valueDeclaration` for intersection properties when one symbol does not have a`valueDeclaration`#61872

Uh oh!

Conversation

mdm317 commentedJun 15, 2025

Uh oh!