NotificationsYou must be signed in to change notification settings
Fork12.9k
Star105k

Computed names in declarations files are resolved even when non-literal, preserve computed names when expressions are entity names#60052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

weswigham merged 11 commits intomicrosoft:mainfromweswigham:computed-names-in-declarations-files-are-resolved

Jan 24, 2025

Merged

Computed names in declarations files are resolved even when non-literal, preserve computed names when expressions are entity names#60052

weswigham merged 11 commits intomicrosoft:mainfromweswigham:computed-names-in-declarations-files-are-resolved

Jan 24, 2025

Conversation

Copy link

Member

weswigham commentedSep 24, 2024

This PR basically removes the grammar error requiring computed names in declaration files/other contexts resolve to literal types, and allows them to resolve to whatever so long as they're an entity name expression (a.b.c), and endeavors in declaration emit to preserve those input computed names that imply index signatures wherever possible. This clears the way forisolatedDeclarations to allowalways emitting a computed property name on the output for a computed property name on the input, so long as the expression is an entity name expression.

typescript-bot assignedweswigham

Sep 24, 2024

typescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

Sep 24, 2024

Copy link

MemberAuthor

weswigham commentedSep 24, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedSep 24, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedSep 24, 2024

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document themon our wiki's API Breaking Changes page.

Also, please make sure@DanielRosenwasser and@RyanCavanaugh are aware of the changes, just as a heads up.

Copy link

Collaborator

typescript-bot commentedSep 24, 2024

Hey@weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedSep 24, 2024

@weswigham Here are the results of running the user tests with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 inpackages/effect/tsconfig.test.json
- packages/effect/test/Sink/constructors.test.ts#L93 inpackages/effect/tsconfig.test.json

tsconfig.base.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 intsconfig.base.json
- packages/effect/test/Sink/constructors.test.ts#L93 intsconfig.base.json
[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 intsconfig.base.json

packages/schema/dtslint/tsconfig.json

[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 inpackages/schema/dtslint/tsconfig.json

Copy link

Collaborator

typescript-bot commentedSep 24, 2024

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,214k (± 0.82%)}	_{195,011k (± 0.98%)}	_~	_192,422k	_196,310k	_{p=0.298 n=6}
_{Parse Time}	_{1.93s (± 0.89%)}	_{1.96s (± 0.42%)}	_{+0.03s (+ 1.64%)}	_1.95s	_1.97s	_{p=0.006 n=6}
_{Bind Time}	_{1.05s (± 0.79%)}	_{1.07s (± 0.98%)}	_~	_1.05s	_1.08s	_{p=0.122 n=6}
_{Check Time}	_{13.98s (± 0.48%)}	_{13.97s (± 0.27%)}	_~	_13.91s	_14.00s	_{p=0.872 n=6}
_{Emit Time}	_{4.09s (± 4.96%)}	_{4.04s (± 3.26%)}	_~	_3.97s	_4.31s	_{p=0.572 n=6}
_{Total Time}	_{21.05s (± 0.79%)}	_{21.03s (± 0.54%)}	_~	_20.94s	_21.25s	_{p=0.686 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,040k (± 0.00%)}	_{1,224,060k (± 0.00%)}	_~	_1,224,033k	_1,224,144k	_{p=0.689 n=6}
_{Parse Time}	_{6.62s (± 0.57%)}	_{6.61s (± 0.67%)}	_~	_6.56s	_6.69s	_{p=0.688 n=6}
_{Bind Time}	_{1.87s (± 0.22%)}	_{1.87s (± 0.40%)}	_~	_1.86s	_1.88s	_{p=1.000 n=6}
_{Check Time}	_{31.30s (± 0.25%)}	_{31.41s (± 0.34%)}	_~	_31.27s	_31.56s	_{p=0.064 n=6}
_{Emit Time}	_{15.05s (± 0.41%)}	_{15.03s (± 0.28%)}	_~	_14.98s	_15.07s	_{p=0.288 n=6}
_{Total Time}	_{54.84s (± 0.25%)}	_{54.93s (± 0.31%)}	_~	_54.68s	_55.14s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,652	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_936,037	_936,038	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,731k (± 0.00%)}	_{2,351,955k (± 0.00%)}	_{+224k (+ 0.01%)}	_2,351,914k	_2,351,986k	_{p=0.005 n=6}
_{Parse Time}	_{9.29s (± 0.33%)}	_{9.29s (± 0.22%)}	_~	_9.26s	_9.32s	_{p=0.871 n=6}
_{Bind Time}	_{2.14s (± 0.35%)}	_{2.14s (± 0.55%)}	_~	_2.12s	_2.15s	_{p=0.933 n=6}
_{Check Time}	_{73.26s (± 0.29%)}	_{73.48s (± 0.76%)}	_~	_73.00s	_74.46s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (± 3.19%)}	_{0.27s (± 3.31%)}	_~	_0.26s	_0.28s	_{p=0.113 n=6}
_{Total Time}	_{84.97s (± 0.27%)}	_{85.17s (± 0.66%)}	_~	_84.68s	_86.18s	_{p=0.688 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,396	_{+340 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_265,020	_{+50 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,404,455k (± 0.03%)}	_{2,405,163k (± 0.03%)}	_{+708k (+ 0.03%)}	_2,404,332k	_2,405,839k	_{p=0.045 n=6}
_{Parse Time}	_{5.12s (± 0.51%)}	_{5.12s (± 0.43%)}	_~	_5.08s	_5.14s	_{p=1.000 n=6}
_{Bind Time}	_{1.90s (± 0.47%)}	_{1.91s (± 0.39%)}	_~	_1.90s	_1.92s	_{p=0.149 n=6}
_{Check Time}	_{34.91s (± 0.30%)}	_{34.95s (± 0.37%)}	_~	_34.70s	_35.07s	_{p=0.422 n=6}
_{Emit Time}	_{3.02s (± 3.84%)}	_{2.99s (± 0.89%)}	_~	_2.95s	_3.03s	_{p=0.748 n=6}
_{Total Time}	_{44.97s (± 0.45%)}	_{44.98s (± 0.33%)}	_~	_44.70s	_45.11s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,396	_{+340 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_265,020	_{+50 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,478,660k (± 0.02%)}	_{2,479,162k (± 0.02%)}	_~	_2,478,578k	_2,480,282k	_{p=0.093 n=6}
_{Parse Time}	_{6.37s (± 0.30%)}	_{6.35s (± 0.94%)}	_~	_6.25s	_6.41s	_{p=1.000 n=6}
_{Bind Time}	_{2.05s (± 0.57%)}	_{2.06s (± 0.60%)}	_~	_2.04s	_2.07s	_{p=0.625 n=6}
_{Check Time}	_{41.61s (± 0.92%)}	_{41.82s (± 0.83%)}	_~	_41.44s	_42.19s	_{p=0.298 n=6}
_{Emit Time}	_{3.58s (± 1.28%)}	_{3.67s (± 3.57%)}	_~	_3.51s	_3.85s	_{p=0.173 n=6}
_{Total Time}	_{53.63s (± 0.71%)}	_{53.92s (± 0.58%)}	_~	_53.50s	_54.21s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,936	_261,221	_{+285 (+ 0.11%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,385	_106,435	_{+50 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,588k (± 0.03%)}	_{436,904k (± 0.01%)}	_{+316k (+ 0.07%)}	_436,835k	_436,951k	_{p=0.005 n=6}
_{Parse Time}	_{2.85s (± 0.31%)}	_{2.86s (± 0.97%)}	_~	_2.83s	_2.90s	_{p=0.683 n=6}
_{Bind Time}	_{1.08s (± 1.43%)}	_{1.07s (± 1.40%)}	_~	_1.06s	_1.09s	_{p=0.423 n=6}
_{Check Time}	_{15.37s (± 0.35%)}	_{15.46s (± 0.25%)}	_{+0.09s (+ 0.56%)}	_15.39s	_15.51s	_{p=0.020 n=6}
_{Emit Time}	_{1.28s (± 1.45%)}	_{1.29s (± 1.61%)}	_~	_1.26s	_1.32s	_{p=0.744 n=6}
_{Total Time}	_{20.58s (± 0.30%)}	_{20.68s (± 0.36%)}	_~	_20.56s	_20.75s	_{p=0.065 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,841k (± 0.02%)}	_{370,962k (± 0.02%)}	_{+121k (+ 0.03%)}	_370,873k	_371,066k	_{p=0.013 n=6}
_{Parse Time}	_{2.76s (± 1.24%)}	_{2.79s (± 0.67%)}	_~	_2.76s	_2.81s	_{p=0.259 n=6}
_{Bind Time}	_{1.57s (± 1.38%)}	_{1.58s (± 1.06%)}	_~	_1.56s	_1.60s	_{p=0.463 n=6}
_{Check Time}	_{15.78s (± 0.40%)}	_{15.77s (± 0.22%)}	_~	_15.73s	_15.82s	_{p=0.467 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.11s (± 0.44%)}	_{20.14s (± 0.12%)}	_~	_20.12s	_20.18s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,775	_3,099,775	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,068,973	_1,068,973	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,196,811k (± 0.00%)}	_{3,197,123k (± 0.00%)}	_{+312k (+ 0.01%)}	_3,197,050k	_3,197,255k	_{p=0.005 n=6}
_{Parse Time}	_{17.20s (± 0.22%)}	_{17.23s (± 0.41%)}	_~	_17.17s	_17.37s	_{p=0.332 n=6}
_{Bind Time}	_{5.42s (± 2.44%)}	_{5.39s (± 2.61%)}	_~	_5.27s	_5.58s	_{p=0.936 n=6}
_{Check Time}	_{100.10s (± 0.42%)}	_{100.11s (± 0.39%)}	_~	_99.73s	_100.78s	_{p=1.000 n=6}
_{Emit Time}	_{27.43s (± 0.72%)}	_{27.45s (± 0.48%)}	_~	_27.31s	_27.67s	_{p=0.689 n=6}
_{Total Time}	_{150.15s (± 0.33%)}	_{150.18s (± 0.39%)}	_~	_149.55s	_151.03s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,920	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,349k (± 0.02%)}	_{428,371k (± 0.02%)}	_~	_428,277k	_428,542k	_{p=0.936 n=6}
_{Parse Time}	_{3.95s (± 0.44%)}	_{3.94s (± 0.31%)}	_~	_3.93s	_3.96s	_{p=0.622 n=6}
_{Bind Time}	_{1.72s (± 0.52%)}	_{1.72s (± 0.57%)}	_~	_1.71s	_1.73s	_{p=0.798 n=6}
_{Check Time}	_{17.69s (± 0.24%)}	_{17.61s (± 0.39%)}	_~	_17.54s	_17.72s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.36s (± 0.18%)}	_{23.28s (± 0.32%)}	_~	_23.19s	_23.39s	_{p=0.073 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,548k (± 0.01%)}	_{483,586k (± 0.01%)}	_~	_483,525k	_483,677k	_{p=0.298 n=6}
_{Parse Time}	_{4.02s (± 0.52%)}	_{4.01s (± 0.37%)}	_~	_3.99s	_4.03s	_{p=0.514 n=6}
_{Bind Time}	_{1.42s (± 1.45%)}	_{1.43s (± 0.53%)}	_~	_1.42s	_1.44s	_{p=0.935 n=6}
_{Check Time}	_{22.90s (± 0.55%)}	_{22.91s (± 0.36%)}	_~	_22.79s	_23.04s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.35s (± 0.43%)}	_{28.35s (± 0.29%)}	_~	_28.25s	_28.50s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedSep 25, 2024

@weswigham Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

alibaba/lowcode-engine

40 of 42 projects failed to build with the old tsc and were ignored

modules/code-generator/tsconfig.json

error TS4082: Default export of the module has or is using private name 'CLASS_DEFINE_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40
error TS4082: Default export of the module has or is using private name 'COMMON_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40

FormidableLabs/victory

9 of 63 projects failed to build with the old tsc and were ignored

packages/victory-axis/tsconfig.json

error TS4025: Exported variable 'getBaseProps' has or is using private name 'axis'.
- packages/victory-axis/src/helper-methods.tsx#L549
error TS4050: Return type of public static method from exported class has or is using name 'axis' from external module "/mnt/ts_downloads/_/m/victory/packages/victory-axis/src/helper-methods" but cannot be named.
- packages/victory-axis/src/victory-axis.tsx#L108

packages/victory-axis/tsconfig.build.json

error TS4025: Exported variable 'getBaseProps' has or is using private name 'axis'.
- packages/victory-axis/src/helper-methods.tsx#L549
error TS4050: Return type of public static method from exported class has or is using name 'axis' from external module "/mnt/ts_downloads/_/m/victory/packages/victory-axis/src/helper-methods" but cannot be named.
- packages/victory-axis/src/victory-axis.tsx#L108

tinacms/tinacms

13 of 25 projects failed to build with the old tsc and were ignored

packages/@tinacms/schema-tools/tsconfig.json

error TS4031: Public property 'transformPayload' of exported class has or is using private name 'collectionName'.
- packages/@tinacms/schema-tools/src/schema/TinaSchema.ts#L253

packages/@tinacms/graphql/tsconfig.json

error TS2305: Module '"@tinacms/schema-tools"' has no exported member 'TinaSchema'.
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Collection<true>'.
error TS2339: Property 'namespace' does not exist on type 'unknown'.
error TS2339: Property 'isAuthCollection' does not exist on type 'unknown'.
- packages/@tinacms/graphql/src/build.ts#L182
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'TinaField<true>'.
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Template<true>'.
- packages/@tinacms/graphql/src/builder/index.ts#L976
- packages/@tinacms/graphql/src/builder/index.ts#L1010
error TS2339: Property 'name' does not exist on type 'unknown'.
error TS2339: Property 'path' does not exist on type 'unknown'.
- packages/@tinacms/graphql/src/database/util.ts#L162
error TS2339: Property 'format' does not exist on type 'unknown'.
- packages/@tinacms/graphql/src/database/util.ts#L163

packages/@tinacms/cli/tsconfig.json

error TS2305: Module '"@tinacms/schema-tools"' has no exported member 'TinaSchema'.
- packages/@tinacms/cli/src/next/codegen/index.ts#L8
- packages/@tinacms/cli/src/next/commands/baseCommands.ts#L8

tusen-ai/naive-ui

3 of 6 projects failed to build with the old tsc and were ignored

src/tsconfig.demo.json

error TS4082: Default export of the module has or is using private name 'styleDirection'.
- src/slider/src/Slider.tsx#L107 insrc/tsconfig.demo.json

vuetifyjs/vuetify

3 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.json

error TS4060: Return type of exported function has or is using private name 'scopeId'.
- packages/vuetify/src/composables/scopeId.ts#L4

packages/vuetify/tsconfig.dist.json

error TS4060: Return type of exported function has or is using private name 'scopeId'.
- packages/vuetify/src/composables/scopeId.ts#L4

packages/vuetify/tsconfig.checks.json

error TS4060: Return type of exported function has or is using private name 'scopeId'.
- packages/vuetify/src/composables/scopeId.ts#L4

Copy link

Contributor

MichaelMitchell-at commentedSep 25, 2024•
edited
Loading

Amazing! Has the team already discussed the intent to ship this feature or is this only an experiment? Asking because I'm wondering ifhttps://github.com/oxc-project/oxc/tree/main/crates/oxc_isolated_declarations could bypass the need to implement something like#58771 (oxc-project/oxc#4016) and implement the behavior in this PR directly.

Copy link

MemberAuthor

weswigham commentedSep 30, 2024

You can't ship this before we do because it produces declaration files that can't be correctly read by current versions of TS 😉

weswigham added2 commits

October 1, 2024 10:23

Preserve input computed names in output declaration files when they a…

11ff822

…re entity name expressions

Accept baselines

22c5c89

weswigham force-pushed thecomputed-names-in-declarations-files-are-resolved branch from7fec56c to22c5c89Compare

October 1, 2024 17:31

More tests, only use computed name emit when all names are visible

587f9e0

weswigham force-pushed thecomputed-names-in-declarations-files-are-resolved branch fromf1fcd56 to587f9e0Compare

October 1, 2024 17:58

Copy link

MemberAuthor

weswigham commentedOct 1, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedOct 1, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

Hey@weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham Here are the results of running the user tests with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 inpackages/effect/tsconfig.test.json
- packages/effect/test/Sink/constructors.test.ts#L93 inpackages/effect/tsconfig.test.json

tsconfig.base.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 intsconfig.base.json
- packages/effect/test/Sink/constructors.test.ts#L93 intsconfig.base.json
[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 intsconfig.base.json

packages/schema/dtslint/tsconfig.json

[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 inpackages/schema/dtslint/tsconfig.json

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,378k (± 0.73%)}	_{192,924k (± 0.09%)}	_~	_192,779k	_193,152k	_{p=0.471 n=6}
_{Parse Time}	_{1.31s (± 0.57%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.53%)}	_{9.74s (± 0.25%)}	_~	_9.71s	_9.78s	_{p=0.872 n=6}
_{Emit Time}	_{2.72s (± 0.59%)}	_{2.73s (± 0.51%)}	_~	_2.70s	_2.74s	_{p=0.315 n=6}
_{Total Time}	_{14.50s (± 0.35%)}	_{14.50s (± 0.18%)}	_~	_14.46s	_14.53s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,800k (± 0.01%)}	_{1,224,879k (± 0.00%)}	_{+78k (+ 0.01%)}	_1,224,780k	_1,224,952k	_{p=0.031 n=6}
_{Parse Time}	_{8.05s (± 0.83%)}	_{8.06s (± 0.86%)}	_~	_7.97s	_8.16s	_{p=0.810 n=6}
_{Bind Time}	_{2.26s (± 0.72%)}	_{2.27s (± 1.24%)}	_~	_2.24s	_2.32s	_{p=0.739 n=6}
_{Check Time}	_{37.72s (± 0.43%)}	_{37.62s (± 0.41%)}	_~	_37.39s	_37.79s	_{p=0.296 n=6}
_{Emit Time}	_{18.08s (± 0.82%)}	_{18.17s (± 0.42%)}	_~	_18.09s	_18.25s	_{p=0.468 n=6}
_{Total Time}	_{66.11s (± 0.24%)}	_{66.11s (± 0.22%)}	_~	_65.89s	_66.27s	_{p=0.873 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,522,038	_2,522,038	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,053	_936,053	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,352,501k (± 0.00%)}	_{2,352,657k (± 0.00%)}	_{+156k (+ 0.01%)}	_2,352,576k	_2,352,706k	_{p=0.005 n=6}
_{Parse Time}	_{9.37s (± 0.23%)}	_{9.33s (± 0.25%)}	_{-0.04s (- 0.46%)}	_9.29s	_9.36s	_{p=0.014 n=6}
_{Bind Time}	_{2.16s (± 0.24%)}	_{2.16s (± 0.29%)}	_~	_2.15s	_2.17s	_{p=0.386 n=6}
_{Check Time}	_{75.87s (± 0.27%)}	_{75.65s (± 0.17%)}	_~	_75.49s	_75.79s	_{p=0.066 n=6}
_{Emit Time}	_{0.28s (± 2.95%)}	_{0.28s (± 2.26%)}	_~	_0.27s	_0.29s	_{p=0.432 n=6}
_{Total Time}	_{87.67s (± 0.23%)}	_{87.41s (± 0.15%)}	_~	_87.26s	_87.54s	_{p=0.066 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,258,459	_{+353 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,354	_{+88 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,146,790k (± 0.03%)}	_{3,146,909k (± 0.02%)}	_~	_3,146,389k	_3,147,720k	_{p=1.000 n=6}
_{Parse Time}	_{6.59s (± 0.55%)}	_{6.59s (± 0.54%)}	_~	_6.54s	_6.63s	_{p=0.810 n=6}
_{Bind Time}	_{2.35s (± 0.73%)}	_{2.34s (± 1.82%)}	_~	_2.28s	_2.41s	_{p=0.468 n=6}
_{Check Time}	_{43.00s (± 0.25%)}	_{43.08s (± 0.33%)}	_~	_42.86s	_43.28s	_{p=0.378 n=6}
_{Emit Time}	_{3.51s (± 2.00%)}	_{3.52s (± 1.40%)}	_~	_3.45s	_3.60s	_{p=0.936 n=6}
_{Total Time}	_{55.45s (± 0.31%)}	_{55.54s (± 0.31%)}	_~	_55.27s	_55.79s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,258,459	_{+353 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,354	_{+88 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,496,029k (± 0.01%)}	_{2,496,975k (± 0.01%)}	_{+946k (+ 0.04%)}	_2,496,399k	_2,497,391k	_{p=0.008 n=6}
_{Parse Time}	_{5.41s (± 0.54%)}	_{5.37s (± 1.00%)}	_~	_5.32s	_5.47s	_{p=0.107 n=6}
_{Bind Time}	_{1.74s (± 0.48%)}	_{1.74s (± 0.32%)}	_~	_1.73s	_1.74s	_{p=0.855 n=6}
_{Check Time}	_{35.83s (± 0.20%)}	_{35.82s (± 0.16%)}	_~	_35.75s	_35.92s	_{p=0.810 n=6}
_{Emit Time}	_{3.05s (± 1.10%)}	_{3.05s (± 2.13%)}	_~	_2.93s	_3.12s	_{p=1.000 n=6}
_{Total Time}	_{46.03s (± 0.21%)}	_{45.98s (± 0.27%)}	_~	_45.91s	_46.23s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,785	_262,083	_{+298 (+ 0.11%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_106,596	_{+88 (+ 0.08%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,475k (± 0.01%)}	_{438,838k (± 0.01%)}	_{+363k (+ 0.08%)}	_438,803k	_438,875k	_{p=0.005 n=6}
_{Parse Time}	_{2.90s (± 0.42%)}	_{2.88s (± 0.42%)}	_~	_2.87s	_2.90s	_{p=0.138 n=6}
_{Bind Time}	_1.10s	_1.10s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.71s (± 0.25%)}	_{15.72s (± 0.27%)}	_~	_15.66s	_15.78s	_{p=0.809 n=6}
_{Emit Time}	_{1.31s (± 1.31%)}	_{1.32s (± 0.96%)}	_~	_1.31s	_1.34s	_{p=0.359 n=6}
_{Total Time}	_{21.02s (± 0.22%)}	_{21.03s (± 0.19%)}	_~	_20.98s	_21.07s	_{p=0.809 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,091k (± 0.02%)}	_{371,081k (± 0.01%)}	_~	_371,048k	_371,129k	_{p=0.575 n=6}
_{Parse Time}	_{2.88s (± 1.13%)}	_{2.90s (± 0.55%)}	_~	_2.89s	_2.93s	_{p=0.224 n=6}
_{Bind Time}	_{1.60s (± 1.84%)}	_{1.58s (± 0.89%)}	_~	_1.56s	_1.60s	_{p=0.258 n=6}
_{Check Time}	_{16.32s (± 0.24%)}	_{16.30s (± 0.28%)}	_~	_16.25s	_16.38s	_{p=0.573 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.80s (± 0.37%)}	_{20.79s (± 0.20%)}	_~	_20.74s	_20.85s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,110,299	_3,110,299	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,072,179	_1,072,179	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,202,479k (± 0.01%)}	_{3,203,049k (± 0.00%)}	_{+570k (+ 0.02%)}	_3,202,916k	_3,203,338k	_{p=0.005 n=6}
_{Parse Time}	_{14.02s (± 0.33%)}	_{14.02s (± 0.45%)}	_~	_13.94s	_14.09s	_{p=0.872 n=6}
_{Bind Time}	_{4.44s (± 0.44%)}	_{4.43s (± 0.24%)}	_~	_4.42s	_4.45s	_{p=0.871 n=6}
_{Check Time}	_{85.29s (± 1.42%)}	_{86.61s (± 3.30%)}	_~	_84.75s	_92.09s	_{p=0.575 n=6}
_{Emit Time}	_{24.92s (± 9.42%)}	_{24.08s (± 9.10%)}	_~	_22.53s	_26.93s	_{p=0.377 n=6}
_{Total Time}	_{128.67s (± 2.09%)}	_{129.14s (± 2.74%)}	_~	_125.83s	_133.40s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,484	_279,484	_~	_~	_~	_{p=1.000 n=6}
_Types	_114,024	_114,024	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,365k (± 0.03%)}	_{429,460k (± 0.04%)}	_~	_429,295k	_429,739k	_{p=0.230 n=6}
_{Parse Time}	_{5.02s (± 0.98%)}	_{5.06s (± 0.44%)}	_~	_5.04s	_5.10s	_{p=0.225 n=6}
_{Bind Time}	_{2.14s (± 1.56%)}	_{2.15s (± 1.28%)}	_~	_2.12s	_2.19s	_{p=0.746 n=6}
_{Check Time}	_{22.47s (± 0.56%)}	_{22.48s (± 0.54%)}	_~	_22.35s	_22.63s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.64s (± 0.30%)}	_{29.70s (± 0.42%)}	_~	_29.53s	_29.85s	_{p=0.572 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,560	_540,560	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,448	_181,448	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,360k (± 0.01%)}	_{484,386k (± 0.01%)}	_~	_484,284k	_484,461k	_{p=0.298 n=6}
_{Parse Time}	_{3.36s (± 0.72%)}	_{3.37s (± 0.56%)}	_~	_3.34s	_3.39s	_{p=0.571 n=6}
_{Bind Time}	_{1.18s (± 0.89%)}	_{1.18s (± 1.16%)}	_~	_1.16s	_1.19s	_{p=0.804 n=6}
_{Check Time}	_{19.12s (± 0.40%)}	_{19.04s (± 0.27%)}	_~	_18.97s	_19.10s	_{p=0.091 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{23.66s (± 0.25%)}	_{23.59s (± 0.22%)}	_~	_23.51s	_23.65s	_{p=0.125 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Question token test

bdec7e2

Copy link

MemberAuthor

weswigham commentedOct 1, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedOct 1, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham Here are the results of running the user tests with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 inpackages/effect/tsconfig.test.json
- packages/effect/test/Sink/constructors.test.ts#L93 inpackages/effect/tsconfig.test.json

tsconfig.base.json

[MISSING]error TS1166: A computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type.
- packages/effect/test/Sink/constructors.test.ts#L92 intsconfig.base.json
- packages/effect/test/Sink/constructors.test.ts#L93 intsconfig.base.json
[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 intsconfig.base.json

packages/schema/dtslint/tsconfig.json

[MISSING]error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
- packages/schema/dtslint/Class.ts#L9 inpackages/schema/dtslint/tsconfig.json

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

Hey@weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,035k (± 0.98%)}	_{193,440k (± 0.74%)}	_~	_192,753k	_196,365k	_{p=0.575 n=6}
_{Parse Time}	_{1.32s (± 0.48%)}	_{1.30s (± 0.97%)}	_{-0.02s (- 1.52%)}	_1.29s	_1.32s	_{p=0.019 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.73s (± 0.28%)}	_{9.73s (± 0.26%)}	_~	_9.69s	_9.77s	_{p=0.566 n=6}
_{Emit Time}	_{2.73s (± 0.59%)}	_{2.71s (± 1.15%)}	_~	_2.66s	_2.75s	_{p=0.191 n=6}
_{Total Time}	_{14.50s (± 0.31%)}	_{14.46s (± 0.27%)}	_~	_14.41s	_14.50s	_{p=0.125 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,561k (± 0.00%)}	_{1,224,687k (± 0.00%)}	_{+126k (+ 0.01%)}	_1,224,644k	_1,224,743k	_{p=0.005 n=6}
_{Parse Time}	_{6.66s (± 0.89%)}	_{6.63s (± 0.83%)}	_~	_6.55s	_6.69s	_{p=0.514 n=6}
_{Bind Time}	_{1.89s (± 0.44%)}	_{1.88s (± 0.29%)}	_~	_1.88s	_1.89s	_{p=0.855 n=6}
_{Check Time}	_{31.81s (± 0.38%)}	_{31.86s (± 0.15%)}	_~	_31.77s	_31.91s	_{p=0.377 n=6}
_{Emit Time}	_{15.21s (± 0.88%)}	_{15.18s (± 0.40%)}	_~	_15.10s	_15.26s	_{p=1.000 n=6}
_{Total Time}	_{55.56s (± 0.45%)}	_{55.56s (± 0.17%)}	_~	_55.40s	_55.65s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,522,038	_2,522,038	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,053	_936,053	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,352,496k (± 0.00%)}	_{2,352,669k (± 0.00%)}	_{+173k (+ 0.01%)}	_2,352,612k	_2,352,740k	_{p=0.005 n=6}
_{Parse Time}	_{9.37s (± 0.55%)}	_{9.35s (± 0.30%)}	_~	_9.30s	_9.37s	_{p=0.517 n=6}
_{Bind Time}	_{2.17s (± 0.41%)}	_{2.16s (± 0.65%)}	_~	_2.14s	_2.18s	_{p=0.215 n=6}
_{Check Time}	_{76.04s (± 0.38%)}	_{76.14s (± 0.26%)}	_~	_75.79s	_76.35s	_{p=0.575 n=6}
_{Emit Time}	_0.28s	_{0.28s (± 1.47%)}	_~	_0.27s	_0.28s	_{p=0.405 n=6}
_{Total Time}	_{87.86s (± 0.36%)}	_{87.92s (± 0.23%)}	_~	_87.57s	_88.17s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,258,500	_{+394 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,376	_{+110 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,532k (± 0.01%)}	_{2,423,377k (± 0.02%)}	_{+845k (+ 0.03%)}	_2,423,035k	_2,424,182k	_{p=0.005 n=6}
_{Parse Time}	_{5.20s (± 0.89%)}	_{5.20s (± 0.76%)}	_~	_5.14s	_5.24s	_{p=0.748 n=6}
_{Bind Time}	_{1.93s (± 0.39%)}	_{1.93s (± 0.72%)}	_~	_1.91s	_1.94s	_{p=0.740 n=6}
_{Check Time}	_{35.52s (± 0.28%)}	_{35.37s (± 0.34%)}	_~	_35.21s	_35.52s	_{p=0.054 n=6}
_{Emit Time}	_{3.01s (± 1.85%)}	_{3.02s (± 0.71%)}	_~	_2.98s	_3.04s	_{p=1.000 n=6}
_{Total Time}	_{45.68s (± 0.15%)}	_{45.52s (± 0.26%)}	_{-0.16s (- 0.34%)}	_45.35s	_45.64s	_{p=0.020 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,106	_1,258,500	_{+394 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,266	_266,376	_{+110 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,859,100k (±13.77%)}	_{2,766,705k (±12.90%)}	_~	_2,499,732k	_3,222,096k	_{p=0.689 n=6}
_{Parse Time}	_{6.72s (± 2.99%)}	_{6.63s (± 2.17%)}	_~	_6.47s	_6.89s	_{p=0.748 n=6}
_{Bind Time}	_{2.14s (± 1.99%)}	_{2.19s (± 3.98%)}	_~	_2.11s	_2.36s	_{p=0.336 n=6}
_{Check Time}	_{43.19s (± 0.48%)}	_{43.07s (± 0.40%)}	_~	_42.81s	_43.33s	_{p=0.471 n=6}
_{Emit Time}	_{3.57s (± 2.43%)}	_{3.49s (± 1.70%)}	_~	_3.41s	_3.59s	_{p=0.173 n=6}
_{Total Time}	_{55.63s (± 0.46%)}	_{55.39s (± 0.29%)}	_~	_55.20s	_55.65s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,785	_262,124	_{+339 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,508	_106,618	_{+110 (+ 0.10%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,789k (± 0.01%)}	_{439,077k (± 0.01%)}	_{+288k (+ 0.07%)}	_439,040k	_439,137k	_{p=0.005 n=6}
_{Parse Time}	_{3.54s (± 0.67%)}	_{3.54s (± 1.41%)}	_~	_3.48s	_3.63s	_{p=0.809 n=6}
_{Bind Time}	_{1.31s (± 0.89%)}	_{1.32s (± 1.12%)}	_~	_1.30s	_1.33s	_{p=0.219 n=6}
_{Check Time}	_{18.94s (± 0.42%)}	_{18.84s (± 0.36%)}	_~	_18.72s	_18.92s	_{p=0.064 n=6}
_{Emit Time}	_{1.55s (± 1.27%)}	_{1.54s (± 1.26%)}	_~	_1.52s	_1.57s	_{p=0.466 n=6}
_{Total Time}	_{25.33s (± 0.40%)}	_{25.24s (± 0.24%)}	_~	_25.14s	_25.31s	_{p=0.172 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,077k (± 0.01%)}	_{371,092k (± 0.01%)}	_~	_371,027k	_371,165k	_{p=0.630 n=6}
_{Parse Time}	_{3.59s (± 1.59%)}	_{3.62s (± 1.41%)}	_~	_3.52s	_3.66s	_{p=0.260 n=6}
_{Bind Time}	_{1.96s (± 1.66%)}	_{1.96s (± 0.95%)}	_~	_1.93s	_1.98s	_{p=1.000 n=6}
_{Check Time}	_{20.27s (± 0.28%)}	_{20.31s (± 0.32%)}	_~	_20.24s	_20.41s	_{p=0.145 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.82s (± 0.25%)}	_{25.88s (± 0.29%)}	_~	_25.78s	_25.97s	_{p=0.227 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,110,459	_3,110,459	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,072,226	_1,072,226	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,202,640k (± 0.01%)}	_{3,203,131k (± 0.00%)}	_{+491k (+ 0.02%)}	_3,202,948k	_3,203,256k	_{p=0.008 n=6}
_{Parse Time}	_{14.10s (± 0.70%)}	_{14.00s (± 0.28%)}	_~	_13.94s	_14.05s	_{p=0.077 n=6}
_{Bind Time}	_{4.44s (± 0.23%)}	_{4.43s (± 0.26%)}	_~	_4.41s	_4.44s	_{p=0.491 n=6}
_{Check Time}	_{86.30s (± 1.71%)}	_{85.42s (± 1.41%)}	_~	_84.13s	_87.72s	_{p=0.173 n=6}
_{Emit Time}	_{24.62s (± 8.98%)}	_{23.45s (± 7.52%)}	_~	_22.60s	_27.04s	_{p=0.471 n=6}
_{Total Time}	_{129.44s (± 2.70%)}	_{127.31s (± 2.30%)}	_~	_125.26s	_133.20s	_{p=0.093 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,484	_279,484	_~	_~	_~	_{p=1.000 n=6}
_Types	_114,024	_114,024	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,471k (± 0.03%)}	_{429,554k (± 0.02%)}	_~	_429,430k	_429,687k	_{p=0.230 n=6}
_{Parse Time}	_{4.07s (± 0.36%)}	_{4.06s (± 0.93%)}	_~	_3.99s	_4.09s	_{p=0.806 n=6}
_{Bind Time}	_{1.74s (± 0.63%)}	_{1.73s (± 1.69%)}	_~	_1.69s	_1.78s	_{p=0.319 n=6}
_{Check Time}	_{18.11s (± 0.58%)}	_{18.21s (± 0.23%)}	_~	_18.13s	_18.25s	_{p=0.197 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.92s (± 0.41%)}	_{23.99s (± 0.29%)}	_~	_23.90s	_24.08s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,560	_540,560	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,448	_181,448	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,316k (± 0.01%)}	_{484,365k (± 0.01%)}	_~	_484,311k	_484,418k	_{p=0.066 n=6}
_{Parse Time}	_{3.35s (± 0.74%)}	_{3.35s (± 1.09%)}	_~	_3.31s	_3.41s	_{p=0.934 n=6}
_{Bind Time}	_{1.17s (± 0.84%)}	_{1.18s (± 1.03%)}	_~	_1.17s	_1.20s	_{p=0.734 n=6}
_{Check Time}	_{19.05s (± 0.28%)}	_{19.06s (± 0.39%)}	_~	_18.99s	_19.18s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{23.57s (± 0.26%)}	_{23.59s (± 0.29%)}	_~	_23.48s	_23.67s	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

alibaba/lowcode-engine

40 of 42 projects failed to build with the old tsc and were ignored

modules/code-generator/tsconfig.json

error TS4082: Default export of the module has or is using private name 'CLASS_DEFINE_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40
error TS4082: Default export of the module has or is using private name 'COMMON_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40

1 similar comment

Copy link

Collaborator

typescript-bot commentedOct 1, 2024

@weswigham Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/60052/merge:

Something interesting changed - please have a look.

Details

alibaba/lowcode-engine

40 of 42 projects failed to build with the old tsc and were ignored

modules/code-generator/tsconfig.json

error TS4082: Default export of the module has or is using private name 'CLASS_DEFINE_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40
error TS4082: Default export of the module has or is using private name 'COMMON_CHUNK_NAME'.
- modules/code-generator/src/index.ts#L40
- modules/code-generator/src/standalone.ts#L40

Copy link

Collaborator

typescript-bot commentedDec 6, 2024

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,543k (± 0.93%)}	_{194,863k (± 1.04%)}	_~	_192,999k	_196,767k	_{p=0.336 n=6}
_{Parse Time}	_{1.30s (± 0.94%)}	_{1.31s (± 0.92%)}	_~	_1.29s	_1.32s	_{p=0.300 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.79s (± 0.43%)}	_{9.80s (± 0.43%)}	_~	_9.76s	_9.87s	_{p=1.000 n=6}
_{Emit Time}	_{2.73s (± 0.49%)}	_{2.73s (± 0.75%)}	_~	_2.70s	_2.76s	_{p=0.605 n=6}
_{Total Time}	_{14.54s (± 0.32%)}	_{14.56s (± 0.36%)}	_~	_14.50s	_14.64s	_{p=0.747 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,834k (± 0.00%)}	_{1,225,865k (± 0.00%)}	_~	_1,225,827k	_1,225,927k	_{p=0.471 n=6}
_{Parse Time}	_{6.66s (± 0.61%)}	_{6.66s (± 0.67%)}	_~	_6.59s	_6.71s	_{p=0.872 n=6}
_{Bind Time}	_{1.89s (± 0.33%)}	_{1.89s (± 0.27%)}	_~	_1.88s	_1.89s	_{p=0.386 n=6}
_{Check Time}	_{32.05s (± 0.43%)}	_{31.97s (± 0.39%)}	_~	_31.79s	_32.11s	_{p=0.297 n=6}
_{Emit Time}	_{15.17s (± 0.18%)}	_{15.19s (± 0.42%)}	_~	_15.09s	_15.28s	_{p=0.318 n=6}
_{Total Time}	_{55.78s (± 0.29%)}	_{55.71s (± 0.20%)}	_~	_55.56s	_55.84s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,501,827	_2,501,827	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,625	_909,625	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,319,533k (± 0.00%)}	_{2,319,775k (± 0.00%)}	_{+242k (+ 0.01%)}	_2,319,672k	_2,319,971k	_{p=0.005 n=6}
_{Parse Time}	_{11.21s (± 0.48%)}	_{11.21s (± 0.73%)}	_~	_11.08s	_11.32s	_{p=1.000 n=6}
_{Bind Time}	_{2.61s (± 0.58%)}	_{2.62s (± 0.74%)}	_~	_2.60s	_2.65s	_{p=0.408 n=6}
_{Check Time}	_{91.22s (± 2.56%)}	_{90.44s (± 1.49%)}	_~	_88.96s	_92.19s	_{p=0.471 n=6}
_{Emit Time}	_{0.35s (± 3.32%)}	_{0.35s (± 3.32%)}	_~	_0.34s	_0.37s	_{p=1.000 n=6}
_{Total Time}	_{105.39s (± 2.18%)}	_{104.62s (± 1.25%)}	_~	_103.17s	_106.37s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,330	_1,225,725	_{+395 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,679	_{+110 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,084,924k (± 0.03%)}	_{2,842,889k (±13.22%)}	_~	_2,356,448k	_3,085,999k	_{p=0.810 n=6}
_{Parse Time}	_{6.79s (± 0.77%)}	_{6.72s (± 1.14%)}	_~	_6.61s	_6.82s	_{p=0.298 n=6}
_{Bind Time}	_{2.11s (± 1.57%)}	_{2.14s (± 0.42%)}	_~	_2.13s	_2.15s	_{p=0.065 n=6}
_{Check Time}	_{42.81s (± 0.37%)}	_{42.70s (± 0.40%)}	_~	_42.49s	_42.95s	_{p=0.378 n=6}
_{Emit Time}	_{3.44s (± 2.41%)}	_{3.57s (± 3.73%)}	_~	_3.47s	_3.79s	_{p=0.109 n=6}
_{Total Time}	_{55.15s (± 0.39%)}	_{55.13s (± 0.44%)}	_~	_54.80s	_55.43s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,330	_1,225,725	_{+395 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,569	_266,679	_{+110 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,421,934k (± 0.02%)}	_{2,422,995k (± 0.02%)}	_{+1,062k (+ 0.04%)}	_2,422,352k	_2,423,695k	_{p=0.013 n=6}
_{Parse Time}	_{5.45s (± 1.18%)}	_{5.48s (± 1.01%)}	_~	_5.41s	_5.56s	_{p=0.336 n=6}
_{Bind Time}	_{1.83s (± 0.67%)}	_{1.82s (± 0.41%)}	_~	_1.81s	_1.83s	_{p=0.929 n=6}
_{Check Time}	_{35.26s (± 0.17%)}	_{35.30s (± 0.24%)}	_~	_35.21s	_35.42s	_{p=0.423 n=6}
_{Emit Time}	_{3.02s (± 3.83%)}	_{3.01s (± 1.24%)}	_~	_2.95s	_3.05s	_{p=0.422 n=6}
_{Total Time}	_{45.57s (± 0.47%)}	_{45.61s (± 0.16%)}	_~	_45.53s	_45.73s	_{p=0.092 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,269	_262,609	_{+340 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,628	_106,738	_{+110 (+ 0.10%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,863k (± 0.02%)}	_{440,355k (± 0.01%)}	_{+492k (+ 0.11%)}	_440,275k	_440,440k	_{p=0.005 n=6}
_{Parse Time}	_{2.88s (± 0.72%)}	_{2.89s (± 0.44%)}	_~	_2.88s	_2.91s	_{p=0.867 n=6}
_{Bind Time}	_{1.10s (± 0.37%)}	_1.10s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{15.78s (± 0.37%)}	_{15.76s (± 0.32%)}	_~	_15.70s	_15.84s	_{p=0.519 n=6}
_{Emit Time}	_{1.30s (± 0.90%)}	_{1.31s (± 0.92%)}	_~	_1.30s	_1.33s	_{p=0.138 n=6}
_{Total Time}	_{21.06s (± 0.38%)}	_{21.06s (± 0.32%)}	_~	_20.99s	_21.17s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,608k (± 0.01%)}	_{371,625k (± 0.01%)}	_~	_371,574k	_371,648k	_{p=0.575 n=6}
_{Parse Time}	_{2.90s (± 0.98%)}	_{2.88s (± 1.17%)}	_~	_2.84s	_2.92s	_{p=0.333 n=6}
_{Bind Time}	_{1.58s (± 0.66%)}	_{1.59s (± 1.19%)}	_~	_1.56s	_1.62s	_{p=0.549 n=6}
_{Check Time}	_{16.49s (± 0.36%)}	_{16.47s (± 0.26%)}	_~	_16.42s	_16.53s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.98s (± 0.32%)}	_{20.94s (± 0.29%)}	_~	_20.85s	_21.03s	_{p=0.294 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,901	_3,197,901	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,331	_1,099,331	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,892k (± 0.01%)}	_{3,271,915k (± 0.01%)}	_~	_3,271,523k	_3,272,515k	_{p=0.936 n=6}
_{Parse Time}	_{14.16s (± 0.33%)}	_{14.17s (± 0.27%)}	_~	_14.13s	_14.22s	_{p=1.000 n=6}
_{Bind Time}	_{4.54s (± 0.64%)}	_{4.52s (± 0.44%)}	_~	_4.49s	_4.54s	_{p=0.195 n=6}
_{Check Time}	_{88.08s (± 2.16%)}	_{86.79s (± 0.57%)}	_~	_86.18s	_87.42s	_{p=0.575 n=6}
_{Emit Time}	_{27.06s (± 7.58%)}	_{28.24s (± 2.44%)}	_~	_27.26s	_28.84s	_{p=0.173 n=6}
_{Total Time}	_{133.84s (± 1.20%)}	_{133.71s (± 0.80%)}	_~	_132.31s	_134.59s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,747	_288,747	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,158	_117,158	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,950k (± 0.02%)}	_{441,056k (± 0.02%)}	_~	_440,907k	_441,165k	_{p=0.093 n=6}
_{Parse Time}	_{4.08s (± 0.94%)}	_{4.10s (± 1.27%)}	_~	_4.02s	_4.16s	_{p=0.871 n=6}
_{Bind Time}	_{1.76s (± 0.91%)}	_{1.76s (± 1.63%)}	_~	_1.72s	_1.79s	_{p=0.627 n=6}
_{Check Time}	_{18.85s (± 0.37%)}	_{18.79s (± 0.49%)}	_~	_18.67s	_18.89s	_{p=0.226 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.69s (± 0.27%)}	_{24.64s (± 0.66%)}	_~	_24.41s	_24.84s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,389	_552,389	_~	_~	_~	_{p=1.000 n=6}
_Types	_185,093	_185,093	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,432k (± 0.02%)}	_{492,546k (± 0.02%)}	_~	_492,413k	_492,676k	_{p=0.066 n=6}
_{Parse Time}	_{3.42s (± 0.75%)}	_{3.41s (± 0.49%)}	_~	_3.39s	_3.43s	_{p=0.869 n=6}
_{Bind Time}	_{1.18s (± 1.49%)}	_{1.17s (± 1.04%)}	_~	_1.15s	_1.18s	_{p=0.328 n=6}
_{Check Time}	_{19.57s (± 1.12%)}	_{19.50s (± 0.35%)}	_~	_19.39s	_19.58s	_{p=0.809 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.17s (± 0.86%)}	_{24.08s (± 0.32%)}	_~	_23.98s	_24.17s	_{p=0.423 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedDec 6, 2024

@weswigham Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/60052/merge:

Everything looks good!

weswigham marked this pull request as ready for review

December 9, 2024 17:13

weswigham requested review fromandrewbranch andsandersn

December 9, 2024 17:13

Copy link

Contributor

dragomirtitian commentedDec 9, 2024

Computed properties that have a computed name of a literal type seem to be duplicated when another computed property that is not a literal type is present:

// index.tsdeclareconstx:string;declareconsty:"y";exportclassTest{[x]=10;[y]=10;}// index.d.tsdeclareconstx:string;declareconsty:"y";exportdeclareclassTest{[x]:number;[y]:number;[y]:number;// ❌}export{};

dragomirtitian mentioned this pull request

Dec 19, 2024

Computed property invalid in type declaration emitted in d.ts file#60818

Open

weswigham added3 commits

January 15, 2025 11:10

Merge branch 'main' into computed-names-in-declarations-files-are-res…

5cbd456

…olved

Remove dupe computed name declarations in declaration output

c3d111a

Commit last edit

8ee4d00

Copy link

Member

jakebailey commentedJan 21, 2025

Does this definitely fix#60818?

Copy link

MemberAuthor

weswigham commentedJan 21, 2025

Not intentionally, since it's onlya.b.c style names this PR special-cases to copy through to declaration emit, but the late bound index signature logic may be generic enough to at least remove the index error and make an indexer on the resulting type, rather than not and issuing an error. Though it'd obviously be better if the element access behaved more like the equivalent dotted name and produced a concrete property, which is what I'd say the "real fix" aughta be.

@typescript-bot pack this

Copy link

Collaborator

typescript-bot commentedJan 21, 2025•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

Copy link

Collaborator

typescript-bot commentedJan 21, 2025•
edited
Loading

Hey@weswigham, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164590/artifacts?artifactName=tgz&fileId=F6ABB72746FFE8FA00220E3BDB1DD1A1944C2317AEEF5C0C73BAC8C6962134A102&fileName=/typescript-5.8.0-insiders.20250121.tgz"    }}

and then runningnpm install.

There is also a playgroundfor this build and annpm module you can use via"typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60052-36".;

Copy link

Member

jakebailey commentedJan 21, 2025•
edited
Loading

I think this does what it should, but what's our strategy for dealing with the fact that this PR will cause index expressions to be emitted in such a way that TS<5.8 will be unable to read them?

Is this break acceptable? I think it has to be, because we really want to do it, but it seems like we're going to have to be really clear in the blog post to people that the types may have to be downleveled somehow...

@DanielRosenwasser

Concretely, before:

declareclassBase1{[x:string]:()=>void;}

After:

declareletprop:string;declareclassBase1{[prop]:()=>void;}

DanielRosenwasser mentioned this pull request

Jan 22, 2025

TypeScript 5.8 Iteration Plan#61023

Open

Copy link

MemberAuthor

weswigham commentedJan 22, 2025

Is this break acceptable? I think it has to be, because we really want to do it, but it seems like we're going to have to be really clear in the blog post to people that the types may have to be downleveled somehow

Yeah. Wouldn't be the first time. It's also notable that while you do have to downlevel the declaration to inline the computed name's type to remove theA computed property name in a class property declaration must have a simple literal type or a 'unique symbol' type. error in old versions of TS, it actually does still typecheck as expected despite the error in TS 5.7, thanks to the existing index signature work. So there's a tiny bit of versioning grace there, at least.

Copy link

Member

RyanCavanaugh commentedJan 23, 2025

What's the minimal input file that would cause a freshly-generated .d.ts file to not be readable by 5.7?

Copy link

Member

jakebailey commentedJan 23, 2025

In testing this, I think I found a bug:

letprop!:string;exportclassBase1{[x:string]:()=>void;[prop]!:()=>void;}exportclassBase2{[prop]!:()=>void;[x:string]:()=>void;}

Playground Link

The d.ts emit for this after the PR is:

exportdeclareclassBase1{[x:string]:()=>void;}exportdeclareclassBase2{[x:string]:()=>void;}

But, we can't know without type analysis that the computed property is safe to drop, and the emitter can't make that decision based on whether or not isolatedDeclarations is enabled (and those kinds of emitters would preserve both).

Copy link

MemberAuthor

weswigham commentedJan 24, 2025

What's the minimal input file that would cause a freshly-generated .d.ts file to not be readable by 5.7?

letprop!:string;exportclassBase1{[prop]!:()=>void;}

which will produce

declareprop:string;declareexportclassBase1{[prop]:()=>void;}

except itis readable in 5.7, where I introduced the new computed name index signature behavior for classes (but not earlier), it just has an error in the.d.ts (though will typecheck correctly).

In testing this, I think I found a bug:

A full ID emitter will be forced to retain all possibly-conflicting names, yeah. Which is fine, duplicate declarations basically merge. Where you can, removing dupes from the output is our expected behavior, though.

RyanCavanaugh approved these changes

Jan 24, 2025

View reviewed changes

weswigham merged commitcaf1aee intomicrosoft:main

Jan 24, 2025

32 checks passed

MichaelMitchell-at mentioned this pull request

Jan 24, 2025

isolatedDeclarations does not support well-known symbols as propertiesoxc-project/oxc#4016

Closed

Copy link

Contributor

dragomirtitian commentedJan 27, 2025

A full ID emitter will be forced to retain all possibly-conflicting names, yeah. Which is fine, duplicate declarations basically merge. Where you can, removing dupes from the output is our expected behavior, though.

Don't we want to keep declaration emit in sync to what an ID emitter could produce though? Because what I understand form this is that TS will remove the dupes while an ID emitter will not (since it needs type info to do so).

Copy link

Member

jakebailey commentedJan 27, 2025

Yes, that is why I am concerned; I do not think we should be removing them as we have previously said that we should have one emit that does the same as ID.