NotificationsYou must be signed in to change notification settings
Fork13.2k
Star107k

Always write tsbuildInfo when running tsc -b#58626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sheetalkamat merged 3 commits intomainfromalwaysBuildInfo

Jun 12, 2024

Merged

Always write tsbuildInfo when running tsc -b#58626

sheetalkamat merged 3 commits intomainfromalwaysBuildInfo

Jun 12, 2024

+2,665 −364

Conversation

Copy link

Member

sheetalkamat commentedMay 22, 2024•
edited
Loading

For now it only containsversion but with plan to add more info about program for tsc -b uptodateness.

In future this can be used to:

Remove necessity thatcomposite must list all files (probably)
Remove noEmitOnError mandate when runningtsc -b
Experiment with building downstream projects irrespective of errors (or some type of errors)
HandlenoCheck on commandLine
Add extra files to check for uptodate (that are not listed in by config file like packageJson or additional program files)

typescript-bot assignedsheetalkamat

May 22, 2024

typescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

May 22, 2024

sheetalkamat force-pushed thealwaysBuildInfo branch 10 times, most recently from7dc0b38 to49286d6Compare

May 24, 2024 21:34

sheetalkamat force-pushed thealwaysBuildInfo branch 12 times, most recently from7356020 tod8b4a76Compare

June 5, 2024 23:44

Copy link

MemberAuthor

sheetalkamat commentedJun 5, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedJun 5, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedJun 6, 2024

Hey@sheetalkamat, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedJun 6, 2024

@sheetalkamat Here are the results of running the user tests with tsc comparingmain andrefs/pull/58626/merge:

Everything looks good!

Copy link

Collaborator

typescript-bot commentedJun 6, 2024

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,556k (± 0.97%)}	_{193,590k (± 0.92%)}	_~	_192,332k	_195,896k	_{p=0.689 n=6}
_{Parse Time}	_{1.30s (± 0.76%)}	_{1.30s (± 0.90%)}	_~	_1.28s	_1.31s	_{p=1.000 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.57s (± 0.33%)}	_{9.59s (± 0.36%)}	_~	_9.55s	_9.65s	_{p=0.687 n=6}
_{Emit Time}	_{2.76s (± 0.67%)}	_{2.75s (± 0.84%)}	_~	_2.72s	_2.78s	_{p=0.292 n=6}
_{Total Time}	_{14.36s (± 0.27%)}	_{14.35s (± 0.24%)}	_~	_14.31s	_14.41s	_{p=0.872 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,154k (± 0.00%)}	_{1,222,170k (± 0.00%)}	_~	_1,222,142k	_1,222,202k	_{p=0.810 n=6}
_{Parse Time}	_{8.11s (± 0.47%)}	_{8.12s (± 0.50%)}	_~	_8.08s	_8.19s	_{p=0.686 n=6}
_{Bind Time}	_{2.24s (± 0.67%)}	_{2.25s (± 0.54%)}	_{+0.02s (+ 0.75%)}	_2.23s	_2.26s	_{p=0.048 n=6}
_{Check Time}	_{36.58s (± 0.52%)}	_{36.48s (± 0.52%)}	_~	_36.19s	_36.72s	_{p=0.336 n=6}
_{Emit Time}	_{18.08s (± 0.43%)}	_{18.07s (± 0.72%)}	_~	_17.95s	_18.32s	_{p=0.378 n=6}
_{Total Time}	_{65.01s (± 0.30%)}	_{64.92s (± 0.48%)}	_~	_64.51s	_65.43s	_{p=0.575 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,063,460	_2,063,460	_~	_~	_~	_{p=1.000 n=6}
_Types	_905,285	_905,285	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,072,745k (± 0.01%)}	_{2,072,748k (± 0.01%)}	_~	_2,072,529k	_2,072,912k	_{p=0.936 n=6}
_{Parse Time}	_{8.10s (± 0.26%)}	_{8.12s (± 0.41%)}	_~	_8.09s	_8.18s	_{p=0.212 n=6}
_{Bind Time}	_{2.76s (± 1.39%)}	_{2.75s (± 0.82%)}	_~	_2.73s	_2.78s	_{p=0.870 n=6}
_{Check Time}	_{82.69s (± 0.71%)}	_{82.80s (± 0.23%)}	_~	_82.57s	_83.08s	_{p=1.000 n=6}
_{Emit Time}	_{0.16s (± 2.52%)}	_{0.17s (± 3.32%)}	_~	_0.16s	_0.17s	_{p=0.282 n=6}
_{Total Time}	_{93.71s (± 0.64%)}	_{93.83s (± 0.20%)}	_~	_93.57s	_94.06s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,675	_1,230,875	_{+200 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,238	_{+60 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,376,884k (± 2.62%)}	_{2,378,101k (± 2.59%)}	_~	_2,351,637k	_2,503,758k	_{p=0.230 n=6}
_{Parse Time}	_{7.50s (± 0.95%)}	_{7.50s (± 0.59%)}	_~	_7.44s	_7.57s	_{p=0.936 n=6}
_{Bind Time}	_{2.81s (± 0.69%)}	_{2.79s (± 0.66%)}	_~	_2.77s	_2.81s	_{p=0.091 n=6}
_{Check Time}	_{49.51s (± 0.86%)}	_{49.36s (± 0.61%)}	_~	_48.85s	_49.67s	_{p=1.000 n=6}
_{Emit Time}	_{3.96s (± 5.79%)}	_{3.83s (± 4.23%)}	_~	_3.64s	_4.03s	_{p=0.378 n=6}
_{Total Time}	_{63.78s (± 0.83%)}	_{63.48s (± 0.66%)}	_~	_62.82s	_63.95s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,675	_1,230,875	_{+200 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,238	_{+60 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,428,979k (± 0.05%)}	_{2,479,612k (± 3.17%)}	_~	_2,427,716k	_2,581,877k	_{p=0.689 n=6}
_{Parse Time}	_{7.71s (± 0.66%)}	_{7.69s (± 0.58%)}	_~	_7.61s	_7.74s	_{p=0.378 n=6}
_{Bind Time}	_{2.48s (± 0.91%)}	_{2.48s (± 0.51%)}	_~	_2.46s	_2.49s	_{p=0.331 n=6}
_{Check Time}	_{49.93s (± 0.37%)}	_{50.12s (± 0.33%)}	_~	_49.91s	_50.37s	_{p=0.093 n=6}
_{Emit Time}	_{3.83s (± 2.88%)}	_{3.79s (± 1.31%)}	_~	_3.76s	_3.89s	_{p=0.688 n=6}
_{Total Time}	_{63.97s (± 0.39%)}	_{64.07s (± 0.30%)}	_~	_63.76s	_64.31s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,200	_259,207	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,174	_105,190	_{+16 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,852k (± 0.02%)}	_{428,881k (± 0.02%)}	_~	_428,768k	_428,974k	_{p=0.630 n=6}
_{Parse Time}	_{3.30s (± 0.45%)}	_{3.28s (± 0.87%)}	_~	_3.25s	_3.33s	_{p=0.257 n=6}
_{Bind Time}	_{1.35s (± 0.56%)}	_{1.34s (± 0.94%)}	_~	_1.32s	_1.35s	_{p=0.301 n=6}
_{Check Time}	_{18.09s (± 0.35%)}	_{18.07s (± 0.29%)}	_~	_18.00s	_18.13s	_{p=0.423 n=6}
_{Emit Time}	_{1.38s (± 0.85%)}	_{1.37s (± 1.57%)}	_~	_1.35s	_1.40s	_{p=0.410 n=6}
_{Total Time}	_{24.12s (± 0.29%)}	_{24.06s (± 0.21%)}	_~	_24.01s	_24.13s	_{p=0.148 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,749k (± 0.02%)}	_{369,750k (± 0.02%)}	_~	_369,642k	_369,842k	_{p=0.810 n=6}
_{Parse Time}	_{2.80s (± 0.64%)}	_{2.79s (± 0.95%)}	_~	_2.76s	_2.83s	_{p=0.871 n=6}
_{Bind Time}	_{1.58s (± 0.86%)}	_{1.59s (± 1.26%)}	_~	_1.57s	_1.62s	_{p=0.676 n=6}
_{Check Time}	_{15.71s (± 0.25%)}	_{15.67s (± 0.24%)}	_~	_15.63s	_15.72s	_{p=0.196 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.10s (± 0.31%)}	_{20.06s (± 0.37%)}	_~	_19.96s	_20.15s	_{p=0.297 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,849,404	_2,849,404	_~	_~	_~	_{p=1.000 n=6}
_Types	_965,633	_965,633	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,021,440k (± 0.00%)}	_{3,021,425k (± 0.00%)}	_~	_3,021,356k	_3,021,593k	_{p=0.298 n=6}
_{Parse Time}	_{17.03s (± 0.29%)}	_{17.06s (± 0.29%)}	_~	_17.02s	_17.14s	_{p=0.335 n=6}
_{Bind Time}	_{5.07s (± 0.33%)}	_{5.09s (± 0.25%)}	_~	_5.08s	_5.11s	_{p=0.088 n=6}
_{Check Time}	_{89.73s (± 1.26%)}	_{89.40s (± 0.21%)}	_~	_89.16s	_89.64s	_{p=0.810 n=6}
_{Emit Time}	_{28.83s (± 4.13%)}	_{29.15s (± 0.40%)}	_~	_29.05s	_29.35s	_{p=0.575 n=6}
_{Total Time}	_{140.65s (± 0.12%)}	_{140.69s (± 0.10%)}	_~	_140.58s	_140.94s	_{p=0.520 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,400	_266,400	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,576	_108,576	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,466k (± 0.01%)}	_{411,473k (± 0.01%)}	_~	_411,446k	_411,536k	_{p=0.468 n=6}
_{Parse Time}	_{3.21s (± 0.54%)}	_{3.22s (± 0.66%)}	_~	_3.20s	_3.26s	_{p=0.277 n=6}
_{Bind Time}	_{1.40s (± 0.98%)}	_{1.39s (± 0.59%)}	_~	_1.38s	_1.40s	_{p=0.865 n=6}
_{Check Time}	_{14.49s (± 0.36%)}	_{14.49s (± 0.20%)}	_~	_14.43s	_14.51s	_{p=0.935 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.10s (± 0.30%)}	_{19.10s (± 0.21%)}	_~	_19.03s	_19.15s	_{p=0.808 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_526,436	_526,436	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,425	_179,425	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{464,043k (± 0.08%)}	_{463,912k (± 0.08%)}	_~	_463,509k	_464,292k	_{p=0.689 n=6}
_{Parse Time}	_{3.16s (± 0.65%)}	_{3.16s (± 0.68%)}	_~	_3.14s	_3.20s	_{p=0.739 n=6}
_{Bind Time}	_1.19s	_{1.19s (± 0.53%)}	_~	_1.18s	_1.20s	_{p=1.000 n=6}
_{Check Time}	_{18.15s (± 0.62%)}	_{18.17s (± 0.45%)}	_~	_18.03s	_18.23s	_{p=0.871 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.50s (± 0.52%)}	_{22.52s (± 0.39%)}	_~	_22.37s	_22.62s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedJun 6, 2024

@sheetalkamat Here are the results of running the top 400 repos with tsc comparingmain andrefs/pull/58626/merge:

Everything looks good!

sheetalkamat force-pushed thealwaysBuildInfo branch 2 times, most recently fromd0723b8 toe15f648Compare

June 6, 2024 21:48

Write buildInfo irrespective of incremental if invoked from tsc --b

0b0886f

sheetalkamat force-pushed thealwaysBuildInfo branch frome15f648 to0b0886fCompare

June 6, 2024 22:09

This was referencedJun 12, 2024

tsc -b removes silentnoEmitOnError and emits files even if there are errors#58838

Merged

Allow--noCheck to be commandLine option#58839

Merged

sheetalkamat marked this pull request as ready for review

June 12, 2024 19:35

sheetalkamat requested review fromandrewbranch,jakebailey andweswigham

June 12, 2024 19:35

jakebailey reviewed

Jun 12, 2024

View reviewed changes

src/compiler/tsbuildPublic.ts

		commonOptionsWithBuild.forEach(option=>{
		if(hasProperty(buildOptions,option.name))result[option.name]=buildOptions[option.name];
		});
		result.tscBuild=true;

Copy link

Member

jakebaileyJun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How will this flag affect people using our APIs to implement build mode like tsc? Will it be set for them? Or can we just assume it's always true?

Copy link

MemberAuthor

sheetalkamatJun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If they use ourSolutionBuilder API this where we set it so it should work.

Copy link

Member

jakebaileyJun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alrighty; just verifying so people are not surprised.

jakebailey approved these changes

Jun 12, 2024

View reviewed changes

src/compiler/tsbuildPublic.ts

		commonOptionsWithBuild.forEach(option=>{
		if(hasProperty(buildOptions,option.name))result[option.name]=buildOptions[option.name];
		});
		result.tscBuild=true;