NotificationsYou must be signed in to change notification settings
Fork13.2k
Star107k

Omit effects-free conditional constructs from control flow graph#58013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ahejlsberg merged 3 commits intomainfromoptimizeFlowGraph

Apr 4, 2024

Merged

Omit effects-free conditional constructs from control flow graph#58013

ahejlsberg merged 3 commits intomainfromoptimizeFlowGraph

Apr 4, 2024

Conversation

Copy link

Member

ahejlsberg commentedMar 31, 2024•
edited
Loading

With this PR we optimize control flow graph construction to omit conditional constructs that have no control flow effects. Consider this example:

functiontest(x:A|B|C){letstr=xinstanceofA ?doWithA(x) :xinstanceofB ?doWithB(x) :doWithC(x) :foo(x);returnstr;}

This currently creates the following control flow graph for the reference tox in thefoo(x) call:

With this PR, the effects-free conditional operator expression is removed from the control flow graph for references that follow it in the graph:

Intuitively, this optimization is possible because the observed control flow types at the bottomBranchLabel node are the same as the observed control flow types at theStart node for any variable, parameter, or property reference.

The shallower control flow graphs reduce check time up to 2% in several projects.

Omit effects-free conditional constructs from control flow graph

154a057

typescript-bot assignedahejlsberg

Mar 31, 2024

typescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

Mar 31, 2024

Copy link

MemberAuthor

ahejlsberg commentedMar 31, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedMar 31, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

Hey@ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,678k (± 0.01%)}	_{295,450k (± 0.01%)}	_{-228k (- 0.08%)}	_295,415k	_295,473k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.66s (± 0.34%)}	_~	_2.65s	_2.67s	_{p=0.787 n=6}
_{Bind Time}	_{0.83s (± 1.00%)}	_{0.84s (± 1.43%)}	_~	_0.83s	_0.86s	_{p=0.227 n=6}
_{Check Time}	_{8.25s (± 0.17%)}	_{8.19s (± 0.21%)}	_{-0.06s (- 0.75%)}	_8.17s	_8.22s	_{p=0.005 n=6}
_{Emit Time}	_{7.04s (± 0.45%)}	_{7.04s (± 0.54%)}	_~	_7.02s	_7.12s	_{p=1.000 n=6}
_{Total Time}	_{18.79s (± 0.20%)}	_{18.74s (± 0.25%)}	_~	_18.70s	_18.83s	_{p=0.092 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,352k (± 0.94%)}	_{192,190k (± 0.74%)}	_{-1,161k (- 0.60%)}	_191,569k	_195,095k	_{p=0.030 n=6}
_{Parse Time}	_{1.36s (± 0.90%)}	_{1.37s (± 0.97%)}	_~	_1.35s	_1.38s	_{p=0.729 n=6}
_{Bind Time}	_{0.72s (± 0.75%)}	_{0.73s (± 0.56%)}	_~	_0.73s	_0.74s	_{p=0.054 n=6}
_{Check Time}	_{9.56s (± 0.62%)}	_{9.38s (± 0.22%)}	_{-0.17s (- 1.80%)}	_9.36s	_9.42s	_{p=0.005 n=6}
_{Emit Time}	_{2.63s (± 0.80%)}	_{2.62s (± 0.45%)}	_~	_2.61s	_2.64s	_{p=0.622 n=6}
_{Total Time}	_{14.27s (± 0.30%)}	_{14.11s (± 0.24%)}	_{-0.17s (- 1.17%)}	_14.06s	_14.16s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,404k (± 0.00%)}	_{347,143k (± 0.00%)}	_{-261k (- 0.08%)}	_347,127k	_347,162k	_{p=0.005 n=6}
_{Parse Time}	_{2.49s (± 0.55%)}	_{2.48s (± 0.51%)}	_~	_2.46s	_2.49s	_{p=0.357 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.92s (± 0.00%)}	_{-0.01s (- 0.90%)}	_0.92s	_0.92s	_{p=0.007 n=6}
_{Check Time}	_{7.00s (± 0.60%)}	_{7.01s (± 0.28%)}	_~	_6.99s	_7.04s	_{p=0.568 n=6}
_{Emit Time}	_{4.07s (± 0.30%)}	_{4.07s (± 0.46%)}	_~	_4.05s	_4.10s	_{p=1.000 n=6}
_{Total Time}	_{14.49s (± 0.29%)}	_{14.48s (± 0.27%)}	_~	_14.44s	_14.55s	_{p=0.629 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,806k (± 0.01%)}	_{302,284k (± 0.01%)}	_{-522k (- 0.17%)}	_302,265k	_302,323k	_{p=0.005 n=6}
_{Parse Time}	_{2.41s (± 1.57%)}	_{2.41s (± 1.18%)}	_~	_2.38s	_2.46s	_{p=0.744 n=6}
_{Bind Time}	_{1.21s (± 0.52%)}	_{1.19s (± 0.34%)}	_{-0.02s (- 1.52%)}	_1.19s	_1.20s	_{p=0.004 n=6}
_{Check Time}	_{7.49s (± 0.20%)}	_{7.48s (± 0.22%)}	_~	_7.47s	_7.51s	_{p=0.684 n=6}
_{Emit Time}	_{4.28s (± 0.31%)}	_{4.26s (± 0.36%)}	_~	_4.25s	_4.29s	_{p=0.088 n=6}
_{Total Time}	_{15.39s (± 0.22%)}	_{15.35s (± 0.24%)}	_~	_15.31s	_15.41s	_{p=0.092 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,042k (± 0.00%)}	_{509,974k (± 0.00%)}	_{-68k (- 0.01%)}	_509,951k	_510,012k	_{p=0.008 n=6}
_{Parse Time}	_{2.66s (± 0.24%)}	_{2.67s (± 0.66%)}	_~	_2.64s	_2.69s	_{p=0.454 n=6}
_{Bind Time}	_{0.99s (± 1.23%)}	_{1.00s (± 0.84%)}	_~	_0.98s	_1.00s	_{p=0.934 n=6}
_{Check Time}	_{17.34s (± 0.55%)}	_{17.26s (± 0.28%)}	_~	_17.19s	_17.33s	_{p=0.227 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.00s (± 0.51%)}	_{20.92s (± 0.28%)}	_~	_20.84s	_21.01s	_{p=0.335 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,665k (± 0.00%)}	_{1,742,824k (± 0.00%)}	_{-1,841k (- 0.11%)}	_1,742,764k	_1,742,866k	_{p=0.005 n=6}
_{Parse Time}	_{7.81s (± 0.48%)}	_{7.89s (± 2.14%)}	_~	_7.79s	_8.23s	_{p=0.622 n=6}
_{Bind Time}	_{2.82s (± 1.13%)}	_{2.81s (± 0.61%)}	_~	_2.79s	_2.84s	_{p=0.332 n=6}
_{Check Time}	_{67.17s (± 0.27%)}	_{66.43s (± 0.62%)}	_{-0.73s (- 1.09%)}	_65.93s	_67.17s	_{p=0.020 n=6}
_{Emit Time}	_{0.16s (± 5.58%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=0.541 n=6}
_{Total Time}	_{77.96s (± 0.25%)}	_{77.29s (± 0.57%)}	_{-0.67s (- 0.86%)}	_76.73s	_78.01s	_{p=0.020 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,400,146k (± 0.06%)}	_{2,397,534k (± 0.04%)}	_{-2,612k (- 0.11%)}	_2,395,667k	_2,398,430k	_{p=0.020 n=6}
_{Parse Time}	_{7.48s (± 0.75%)}	_{7.48s (± 1.04%)}	_~	_7.33s	_7.54s	_{p=0.575 n=6}
_{Bind Time}	_{2.79s (± 1.12%)}	_{2.64s (± 5.05%)}	_{🟩-0.15s (- 5.43%)}	_2.49s	_2.78s	_{p=0.020 n=6}
_{Check Time}	_{49.50s (± 0.26%)}	_{49.12s (± 0.56%)}	_{-0.38s (- 0.78%)}	_48.71s	_49.46s	_{p=0.020 n=6}
_{Emit Time}	_{4.01s (± 3.80%)}	_{3.96s (± 2.03%)}	_~	_3.83s	_4.05s	_{p=0.810 n=6}
_{Total Time}	_{63.78s (± 0.32%)}	_{63.20s (± 0.36%)}	_{-0.58s (- 0.92%)}	_62.95s	_63.61s	_{p=0.013 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,082k (± 0.00%)}	_{414,769k (± 0.01%)}	_{-1,314k (- 0.32%)}	_414,720k	_414,810k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 0.73%)}	_{3.33s (± 0.63%)}	_~	_3.31s	_3.36s	_{p=0.570 n=6}
_{Bind Time}	_{1.30s (± 0.40%)}	_{1.30s (± 0.84%)}	_~	_1.29s	_1.32s	_{p=0.784 n=6}
_{Check Time}	_{18.20s (± 0.32%)}	_{17.93s (± 0.24%)}	_{-0.27s (- 1.48%)}	_17.86s	_17.98s	_{p=0.005 n=6}
_{Emit Time}	_{1.36s (± 1.50%)}	_{1.34s (± 1.03%)}	_{-0.02s (- 1.72%)}	_1.32s	_1.35s	_{p=0.050 n=6}
_{Total Time}	_{24.18s (± 0.22%)}	_{23.90s (± 0.21%)}	_{-0.28s (- 1.17%)}	_23.81s	_23.95s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,898,737k (± 0.00%)}	_{2,893,995k (± 0.00%)}	_{-4,742k (- 0.16%)}	_2,893,884k	_2,894,059k	_{p=0.005 n=6}
_{Parse Time}	_{12.87s (± 0.38%)}	_{12.92s (± 0.50%)}	_~	_12.83s	_12.99s	_{p=0.297 n=6}
_{Bind Time}	_{4.10s (± 0.50%)}	_{4.15s (± 0.35%)}	_{+0.04s (+ 1.06%)}	_4.13s	_4.16s	_{p=0.007 n=6}
_{Check Time}	_{71.41s (± 0.41%)}	_{71.07s (± 0.67%)}	_~	_70.81s	_72.04s	_{p=0.066 n=6}
_{Emit Time}	_{19.90s (± 7.73%)}	_{19.28s (± 0.83%)}	_~	_19.05s	_19.45s	_{p=0.809 n=6}
_{Total Time}	_{108.29s (± 1.64%)}	_{107.42s (± 0.43%)}	_~	_107.00s	_108.28s	_{p=0.149 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,871k (± 0.01%)}	_{408,468k (± 0.04%)}	_{-403k (- 0.10%)}	_408,318k	_408,680k	_{p=0.005 n=6}
_{Parse Time}	_{3.89s (± 0.42%)}	_{3.89s (± 0.27%)}	_~	_3.87s	_3.90s	_{p=0.743 n=6}
_{Bind Time}	_{1.68s (± 0.82%)}	_{1.68s (± 0.70%)}	_~	_1.66s	_1.69s	_{p=0.461 n=6}
_{Check Time}	_{16.83s (± 0.14%)}	_{16.78s (± 0.52%)}	_~	_16.68s	_16.89s	_{p=0.376 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.41s (± 0.20%)}	_{22.34s (± 0.32%)}	_~	_22.26s	_22.43s	_{p=0.149 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,467k (± 0.01%)}	_{513,261k (± 0.01%)}	_{-206k (- 0.04%)}	_513,189k	_513,331k	_{p=0.005 n=6}
_{Parse Time}	_{3.95s (± 0.34%)}	_{3.95s (± 0.26%)}	_~	_3.94s	_3.97s	_{p=0.683 n=6}
_{Bind Time}	_{1.88s (± 0.78%)}	_{1.88s (± 0.82%)}	_~	_1.86s	_1.90s	_{p=1.000 n=6}
_{Check Time}	_{3.45s (± 0.46%)}	_{3.41s (± 0.86%)}	_{-0.04s (- 1.21%)}	_3.37s	_3.45s	_{p=0.019 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.09s (± 4.45%)}	_{🔻+0.01s (+10.00%)}	_0.09s	_0.10s	_{p=0.006 n=6}
_{Total Time}	_{9.36s (± 0.28%)}	_{9.33s (± 0.18%)}	_~	_9.30s	_9.35s	_{p=0.064 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg Here are the results of running the user tests comparingmain andrefs/pull/58013/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[MISSING]error TS18048: 'cacheGroup.getName' is possibly 'undefined'.
- lib/optimize/SplitChunksPlugin.js#L1099

Optimize isNarrowableReference

107c5ff

Copy link

MemberAuthor

ahejlsberg commentedMar 31, 2024

@typescript-bot test it

Copy link

Collaborator

typescript-bot commentedMar 31, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

Hey@ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg Here are the results of running the user tests comparingmain andrefs/pull/58013/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[MISSING]error TS18048: 'cacheGroup.getName' is possibly 'undefined'.
- lib/optimize/SplitChunksPlugin.js#L1099

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,667k (± 0.01%)}	_{295,434k (± 0.01%)}	_{-234k (- 0.08%)}	_295,415k	_295,462k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.28%)}	_{2.66s (± 0.00%)}	_~	_2.66s	_2.66s	_{p=0.598 n=6}
_{Bind Time}	_{0.83s (± 1.00%)}	_{0.83s (± 1.01%)}	_~	_0.82s	_0.84s	_{p=0.062 n=6}
_{Check Time}	_{8.24s (± 0.23%)}	_{8.22s (± 0.28%)}	_~	_8.20s	_8.25s	_{p=0.373 n=6}
_{Emit Time}	_{7.04s (± 0.23%)}	_{7.04s (± 0.25%)}	_~	_7.02s	_7.07s	_{p=0.802 n=6}
_{Total Time}	_{18.77s (± 0.04%)}	_{18.75s (± 0.14%)}	_~	_18.71s	_18.79s	_{p=0.061 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,338k (± 0.97%)}	_{192,826k (± 0.90%)}	_~	_191,585k	_195,084k	_{p=0.128 n=6}
_{Parse Time}	_{1.36s (± 0.55%)}	_{1.36s (± 1.43%)}	_~	_1.33s	_1.38s	_{p=1.000 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.72s (± 0.71%)}	_{-0.01s (- 0.91%)}	_0.72s	_0.73s	_{p=0.025 n=6}
_{Check Time}	_{9.53s (± 0.49%)}	_{9.37s (± 0.65%)}	_{-0.15s (- 1.61%)}	_9.31s	_9.46s	_{p=0.006 n=6}
_{Emit Time}	_{2.64s (± 0.56%)}	_{2.62s (± 0.54%)}	_~	_2.60s	_2.64s	_{p=0.073 n=6}
_{Total Time}	_{14.25s (± 0.35%)}	_{14.07s (± 0.46%)}	_{-0.17s (- 1.20%)}	_13.99s	_14.17s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,406k (± 0.01%)}	_{347,118k (± 0.00%)}	_{-288k (- 0.08%)}	_347,092k	_347,137k	_{p=0.005 n=6}
_{Parse Time}	_{2.49s (± 0.59%)}	_{2.48s (± 0.49%)}	_~	_2.47s	_2.50s	_{p=0.503 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.89s (± 0.61%)}	_{🟩-0.04s (- 3.76%)}	_0.89s	_0.90s	_{p=0.002 n=6}
_{Check Time}	_{7.03s (± 0.36%)}	_{7.00s (± 0.36%)}	_~	_6.96s	_7.03s	_{p=0.061 n=6}
_{Emit Time}	_{4.06s (± 0.41%)}	_{4.06s (± 0.41%)}	_~	_4.04s	_4.09s	_{p=0.934 n=6}
_{Total Time}	_{14.50s (± 0.34%)}	_{14.44s (± 0.21%)}	_~	_14.39s	_14.47s	_{p=0.053 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,780k (± 0.01%)}	_{302,275k (± 0.01%)}	_{-505k (- 0.17%)}	_302,243k	_302,320k	_{p=0.005 n=6}
_{Parse Time}	_{2.44s (± 0.73%)}	_{2.40s (± 1.34%)}	_{-0.04s (- 1.84%)}	_2.36s	_2.44s	_{p=0.029 n=6}
_{Bind Time}	_{1.20s (± 0.53%)}	_{1.16s (± 0.70%)}	_{🟩-0.04s (- 3.06%)}	_1.16s	_1.18s	_{p=0.003 n=6}
_{Check Time}	_{7.52s (± 0.47%)}	_{7.49s (± 0.50%)}	_~	_7.45s	_7.54s	_{p=0.196 n=6}
_{Emit Time}	_{4.27s (± 0.48%)}	_{4.29s (± 0.62%)}	_~	_4.25s	_4.33s	_{p=0.257 n=6}
_{Total Time}	_{15.43s (± 0.16%)}	_{15.33s (± 0.53%)}	_{-0.09s (- 0.61%)}	_15.23s	_15.44s	_{p=0.044 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,052k (± 0.00%)}	_{509,968k (± 0.00%)}	_{-84k (- 0.02%)}	_509,931k	_510,007k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.41%)}	_~	_2.65s	_2.68s	_{p=0.784 n=6}
_{Bind Time}	_{1.00s (± 0.55%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.476 n=6}
_{Check Time}	_{17.35s (± 0.55%)}	_{17.26s (± 0.63%)}	_~	_17.14s	_17.45s	_{p=0.148 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.01s (± 0.44%)}	_{20.91s (± 0.55%)}	_~	_20.79s	_21.11s	_{p=0.108 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,695k (± 0.00%)}	_{1,742,846k (± 0.00%)}	_{-1,850k (- 0.11%)}	_1,742,802k	_1,742,893k	_{p=0.005 n=6}
_{Parse Time}	_{9.64s (± 0.54%)}	_{9.73s (± 1.77%)}	_~	_9.60s	_10.07s	_{p=0.261 n=6}
_{Bind Time}	_{3.47s (± 0.92%)}	_{3.46s (± 0.44%)}	_~	_3.44s	_3.48s	_{p=0.681 n=6}
_{Check Time}	_{82.02s (± 0.21%)}	_{81.14s (± 0.21%)}	_{-0.89s (- 1.08%)}	_80.87s	_81.38s	_{p=0.005 n=6}
_{Emit Time}	_{0.19s (± 2.13%)}	_{0.19s (± 2.13%)}	_~	_0.19s	_0.20s	_{p=1.000 n=6}
_{Total Time}	_{95.32s (± 0.18%)}	_{94.52s (± 0.27%)}	_{-0.80s (- 0.84%)}	_94.18s	_94.89s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,399,680k (± 0.02%)}	_{2,397,413k (± 0.04%)}	_{-2,267k (- 0.09%)}	_2,396,480k	_2,398,817k	_{p=0.005 n=6}
_{Parse Time}	_{6.00s (± 0.85%)}	_{5.99s (± 0.35%)}	_~	_5.97s	_6.02s	_{p=0.872 n=6}
_{Bind Time}	_{2.25s (± 1.18%)}	_{2.17s (± 4.21%)}	_~	_2.05s	_2.25s	_{p=0.053 n=6}
_{Check Time}	_{39.87s (± 0.29%)}	_{39.60s (± 0.89%)}	_~	_39.27s	_40.17s	_{p=0.149 n=6}
_{Emit Time}	_{3.19s (± 0.86%)}	_{3.16s (± 1.32%)}	_~	_3.11s	_3.21s	_{p=0.261 n=6}
_{Total Time}	_{51.34s (± 0.24%)}	_{50.94s (± 0.50%)}	_{-0.39s (- 0.77%)}	_50.67s	_51.36s	_{p=0.020 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,097k (± 0.01%)}	_{414,764k (± 0.01%)}	_{-1,334k (- 0.32%)}	_414,731k	_414,787k	_{p=0.005 n=6}
_{Parse Time}	_{3.35s (± 0.73%)}	_{3.34s (± 1.02%)}	_~	_3.29s	_3.39s	_{p=0.627 n=6}
_{Bind Time}	_{1.29s (± 0.42%)}	_{1.29s (± 0.94%)}	_~	_1.28s	_1.31s	_{p=0.865 n=6}
_{Check Time}	_{18.22s (± 0.44%)}	_{18.01s (± 0.41%)}	_{-0.22s (- 1.19%)}	_17.92s	_18.12s	_{p=0.008 n=6}
_{Emit Time}	_{1.35s (± 1.58%)}	_{1.35s (± 1.21%)}	_~	_1.33s	_1.37s	_{p=0.685 n=6}
_{Total Time}	_{24.21s (± 0.33%)}	_{23.99s (± 0.31%)}	_{-0.23s (- 0.94%)}	_23.92s	_24.13s	_{p=0.008 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,898,621k (± 0.01%)}	_{2,893,873k (± 0.00%)}	_{-4,748k (- 0.16%)}	_2,893,754k	_2,893,970k	_{p=0.005 n=6}
_{Parse Time}	_{12.88s (± 0.31%)}	_{12.86s (± 0.30%)}	_~	_12.80s	_12.92s	_{p=0.517 n=6}
_{Bind Time}	_{4.12s (± 0.56%)}	_{4.11s (± 0.65%)}	_~	_4.08s	_4.15s	_{p=0.333 n=6}
_{Check Time}	_{71.66s (± 0.68%)}	_{70.94s (± 0.71%)}	_{-0.72s (- 1.00%)}	_70.48s	_71.89s	_{p=0.045 n=6}
_{Emit Time}	_{21.16s (±10.02%)}	_{19.89s (± 8.12%)}	_~	_19.12s	_23.19s	_{p=0.688 n=6}
_{Total Time}	_{109.82s (± 2.28%)}	_{107.80s (± 1.94%)}	_~	_106.55s	_112.05s	_{p=0.093 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,871k (± 0.01%)}	_{408,351k (± 0.02%)}	_{-520k (- 0.13%)}	_408,268k	_408,438k	_{p=0.005 n=6}
_{Parse Time}	_{3.89s (± 0.66%)}	_{3.88s (± 0.45%)}	_~	_3.86s	_3.90s	_{p=1.000 n=6}
_{Bind Time}	_{1.69s (± 0.69%)}	_{1.67s (± 0.76%)}	_{-0.02s (- 1.09%)}	_1.66s	_1.69s	_{p=0.041 n=6}
_{Check Time}	_{16.84s (± 0.27%)}	_{16.74s (± 0.38%)}	_{-0.10s (- 0.61%)}	_16.64s	_16.80s	_{p=0.019 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.42s (± 0.28%)}	_{22.30s (± 0.30%)}	_{-0.12s (- 0.53%)}	_22.18s	_22.38s	_{p=0.013 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,468k (± 0.01%)}	_{513,258k (± 0.01%)}	_{-210k (- 0.04%)}	_513,185k	_513,327k	_{p=0.005 n=6}
_{Parse Time}	_{3.97s (± 0.70%)}	_{3.95s (± 0.39%)}	_~	_3.93s	_3.97s	_{p=0.123 n=6}
_{Bind Time}	_{1.87s (± 0.87%)}	_{1.88s (± 0.65%)}	_~	_1.86s	_1.89s	_{p=0.796 n=6}
_{Check Time}	_{3.42s (± 0.34%)}	_{3.40s (± 0.57%)}	_~	_3.38s	_3.43s	_{p=0.105 n=6}
_{Emit Time}	_{0.09s (±11.12%)}	_{0.10s (± 5.34%)}	_~	_0.09s	_0.10s	_{p=0.120 n=6}
_{Total Time}	_{9.36s (± 0.36%)}	_{9.33s (± 0.32%)}	_~	_9.29s	_9.36s	_{p=0.126 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg Here are the results of running the top 400 repos comparingmain andrefs/pull/58013/merge:

Everything looks good!

1 similar comment

Copy link

Collaborator

typescript-bot commentedMar 31, 2024

@ahejlsberg Here are the results of running the top 400 repos comparingmain andrefs/pull/58013/merge:

Everything looks good!

Merge branch 'main' into optimizeFlowGraph

6bdaaf7

Copy link

MemberAuthor

ahejlsberg commentedApr 1, 2024

@typescript-bot user test this
@typescript-bot perf test this faster

Copy link

Collaborator

typescript-bot commentedApr 1, 2024•
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

Copy link

Collaborator

typescript-bot commentedApr 1, 2024

@ahejlsberg Here are the results of running the user tests comparingmain andrefs/pull/58013/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[MISSING]error TS18048: 'cacheGroup.getName' is possibly 'undefined'.
- lib/optimize/SplitChunksPlugin.js#L1099

Copy link

Collaborator

typescript-bot commentedApr 1, 2024

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,688k (± 0.01%)}	_{295,464k (± 0.01%)}	_{-225k (- 0.08%)}	_295,421k	_295,523k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.51%)}	_{2.65s (± 0.44%)}	_~	_2.63s	_2.66s	_{p=0.506 n=6}
_{Bind Time}	_{0.83s (± 0.91%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.476 n=6}
_{Check Time}	_{8.25s (± 0.21%)}	_{8.22s (± 0.27%)}	_{-0.03s (- 0.38%)}	_8.18s	_8.24s	_{p=0.033 n=6}
_{Emit Time}	_{7.04s (± 0.39%)}	_{7.04s (± 0.40%)}	_~	_7.00s	_7.08s	_{p=1.000 n=6}
_{Total Time}	_{18.77s (± 0.14%)}	_{18.73s (± 0.28%)}	_~	_18.67s	_18.79s	_{p=0.514 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,761k (± 0.75%)}	_{192,267k (± 0.77%)}	_{-494k (- 0.26%)}	_191,553k	_195,277k	_{p=0.045 n=6}
_{Parse Time}	_{1.36s (± 0.80%)}	_{1.36s (± 1.21%)}	_~	_1.33s	_1.38s	_{p=0.611 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.73s (± 0.87%)}	_~	_0.72s	_0.74s	_{p=0.673 n=6}
_{Check Time}	_{9.52s (± 0.33%)}	_{9.40s (± 0.39%)}	_{-0.13s (- 1.33%)}	_9.34s	_9.45s	_{p=0.005 n=6}
_{Emit Time}	_{2.63s (± 0.32%)}	_{2.63s (± 0.32%)}	_~	_2.61s	_2.63s	_{p=1.000 n=6}
_{Total Time}	_{14.23s (± 0.24%)}	_{14.11s (± 0.23%)}	_{-0.13s (- 0.89%)}	_14.06s	_14.15s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,421k (± 0.01%)}	_{347,106k (± 0.01%)}	_{-315k (- 0.09%)}	_347,086k	_347,131k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.40%)}	_{2.49s (± 0.30%)}	_~	_2.48s	_2.50s	_{p=0.102 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.90s (± 0.45%)}	_{🟩-0.03s (- 3.41%)}	_0.89s	_0.90s	_{p=0.002 n=6}
_{Check Time}	_{7.02s (± 0.18%)}	_{6.99s (± 0.42%)}	_~	_6.95s	_7.02s	_{p=0.073 n=6}
_{Emit Time}	_{4.07s (± 0.26%)}	_{4.07s (± 0.48%)}	_~	_4.04s	_4.09s	_{p=0.625 n=6}
_{Total Time}	_{14.49s (± 0.18%)}	_{14.45s (± 0.18%)}	_~	_14.42s	_14.49s	_{p=0.052 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,794k (± 0.01%)}	_{302,267k (± 0.01%)}	_{-527k (- 0.17%)}	_302,248k	_302,310k	_{p=0.005 n=6}
_{Parse Time}	_{2.41s (± 0.89%)}	_{2.51s (± 9.80%)}	_~	_2.38s	_3.01s	_{p=1.000 n=6}
_{Bind Time}	_{1.20s (± 0.68%)}	_{1.22s (± 9.40%)}	_~	_1.16s	_1.45s	_{p=0.061 n=6}
_{Check Time}	_{7.51s (± 0.39%)}	_{7.79s (± 9.55%)}	_~	_7.46s	_9.31s	_{p=0.517 n=6}
_{Emit Time}	_{4.25s (± 0.24%)}	_{4.45s (± 9.47%)}	_~	_4.25s	_5.31s	_{p=0.055 n=6}
_{Total Time}	_{15.37s (± 0.25%)}	_{15.96s (± 9.53%)}	_~	_15.30s	_19.07s	_{p=0.574 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,079k (± 0.00%)}	_{509,982k (± 0.00%)}	_{-97k (- 0.02%)}	_509,960k	_510,019k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.44%)}	_{2.67s (± 0.52%)}	_~	_2.65s	_2.69s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 1.43%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.867 n=6}
_{Check Time}	_{17.34s (± 0.26%)}	_{17.20s (± 0.26%)}	_{-0.14s (- 0.80%)}	_17.13s	_17.24s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.99s (± 0.23%)}	_{20.86s (± 0.26%)}	_{-0.14s (- 0.64%)}	_20.79s	_20.91s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,745,037k (± 0.00%)}	_{1,743,173k (± 0.00%)}	_{-1,864k (- 0.11%)}	_1,743,114k	_1,743,220k	_{p=0.005 n=6}
_{Parse Time}	_{9.66s (± 0.40%)}	_{9.67s (± 0.95%)}	_~	_9.52s	_9.79s	_{p=0.747 n=6}
_{Bind Time}	_{3.48s (± 0.47%)}	_{3.46s (± 0.85%)}	_~	_3.42s	_3.49s	_{p=0.183 n=6}
_{Check Time}	_{81.84s (± 0.25%)}	_{81.45s (± 0.74%)}	_~	_80.98s	_82.55s	_{p=0.127 n=6}
_{Emit Time}	_{0.19s (± 2.67%)}	_{0.19s (± 2.67%)}	_~	_0.19s	_0.20s	_{p=1.000 n=6}
_{Total Time}	_{95.18s (± 0.20%)}	_{94.78s (± 0.68%)}	_~	_94.22s	_95.88s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,400,279k (± 0.03%)}	_{2,398,558k (± 0.03%)}	_{-1,721k (- 0.07%)}	_2,397,732k	_2,399,674k	_{p=0.008 n=6}
_{Parse Time}	_{6.03s (± 1.45%)}	_{6.01s (± 0.58%)}	_~	_5.97s	_6.06s	_{p=0.127 n=6}
_{Bind Time}	_{2.25s (± 0.83%)}	_{2.16s (± 4.14%)}	_{🟩-0.09s (- 4.07%)}	_2.04s	_2.25s	_{p=0.010 n=6}
_{Check Time}	_{39.95s (± 0.33%)}	_{39.64s (± 0.54%)}	_{-0.32s (- 0.79%)}	_39.37s	_39.99s	_{p=0.031 n=6}
_{Emit Time}	_{3.16s (± 1.23%)}	_{3.15s (± 1.02%)}	_~	_3.12s	_3.21s	_{p=0.689 n=6}
_{Total Time}	_{51.43s (± 0.36%)}	_{50.97s (± 0.23%)}	_{-0.45s (- 0.88%)}	_50.78s	_51.15s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,186k (± 0.00%)}	_{414,849k (± 0.01%)}	_{-1,338k (- 0.32%)}	_414,810k	_414,882k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 0.97%)}	_{3.33s (± 0.97%)}	_~	_3.30s	_3.39s	_{p=0.870 n=6}
_{Bind Time}	_{1.30s (± 0.94%)}	_{1.29s (± 0.58%)}	_~	_1.28s	_1.30s	_{p=0.555 n=6}
_{Check Time}	_{18.18s (± 0.52%)}	_{18.02s (± 0.62%)}	_{-0.17s (- 0.93%)}	_17.83s	_18.16s	_{p=0.031 n=6}
_{Emit Time}	_{1.32s (± 1.12%)}	_{1.33s (± 2.37%)}	_~	_1.28s	_1.37s	_{p=0.571 n=6}
_{Total Time}	_{24.12s (± 0.25%)}	_{23.96s (± 0.30%)}	_{-0.15s (- 0.64%)}	_23.84s	_24.06s	_{p=0.010 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,899,027k (± 0.00%)}	_{2,894,209k (± 0.01%)}	_{-4,818k (- 0.17%)}	_2,893,915k	_2,894,332k	_{p=0.005 n=6}
_{Parse Time}	_{12.89s (± 0.15%)}	_{12.88s (± 0.35%)}	_~	_12.83s	_12.95s	_{p=0.872 n=6}
_{Bind Time}	_{4.11s (± 0.72%)}	_{4.12s (± 0.50%)}	_~	_4.08s	_4.14s	_{p=0.627 n=6}
_{Check Time}	_{71.51s (± 0.37%)}	_{70.78s (± 0.55%)}	_{-0.73s (- 1.02%)}	_70.31s	_71.33s	_{p=0.013 n=6}
_{Emit Time}	_{19.27s (± 0.61%)}	_{19.83s (± 7.94%)}	_~	_19.05s	_23.04s	_{p=0.688 n=6}
_{Total Time}	_{107.77s (± 0.24%)}	_{107.61s (± 1.74%)}	_~	_106.45s	_111.38s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,844k (± 0.01%)}	_{408,298k (± 0.01%)}	_{-546k (- 0.13%)}	_408,223k	_408,324k	_{p=0.005 n=6}
_{Parse Time}	_{3.89s (± 0.82%)}	_{3.90s (± 0.66%)}	_~	_3.87s	_3.94s	_{p=0.871 n=6}
_{Bind Time}	_{1.69s (± 0.79%)}	_{1.67s (± 0.96%)}	_~	_1.66s	_1.70s	_{p=0.087 n=6}
_{Check Time}	_{16.82s (± 0.23%)}	_{16.76s (± 0.20%)}	_{-0.06s (- 0.35%)}	_16.72s	_16.80s	_{p=0.017 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.40s (± 0.19%)}	_{22.33s (± 0.23%)}	_~	_22.26s	_22.40s	_{p=0.054 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,504k (± 0.02%)}	_{513,284k (± 0.01%)}	_{-220k (- 0.04%)}	_513,237k	_513,429k	_{p=0.008 n=6}
_{Parse Time}	_{3.96s (± 0.70%)}	_{3.95s (± 0.35%)}	_~	_3.93s	_3.96s	_{p=0.370 n=6}
_{Bind Time}	_{1.89s (± 1.41%)}	_{1.87s (± 1.05%)}	_~	_1.84s	_1.89s	_{p=0.466 n=6}
_{Check Time}	_{3.44s (± 0.77%)}	_{3.39s (± 0.40%)}	_{-0.05s (- 1.40%)}	_3.38s	_3.41s	_{p=0.005 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.09s (± 8.80%)}	_{🔻+0.01s (+14.00%)}	_0.08s	_0.10s	_{p=0.022 n=6}
_{Total Time}	_{9.38s (± 0.68%)}	_{9.30s (± 0.28%)}	_{-0.08s (- 0.84%)}	_9.27s	_9.33s	_{p=0.036 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

MemberAuthor

ahejlsberg commentedApr 2, 2024•
edited
Loading

@jakebailey Any idea why we're seeing the test failure here#58013 (comment)? I can't reproduce it locally. Meaning, when I runtsc locally in a cloned repository, I never get the error, be it on main or my branch.

Copy link

MemberAuthor

ahejlsberg commentedApr 2, 2024

@jakebailey Ok, I wasn't running with-p tsconfig.types.json, but now when I do, I get the error both in main and in my branch. I just can't reproduce any sort of difference.

Copy link

Member

jakebailey commentedApr 2, 2024

I was out yesterday; will take a look at this shortly.

Copy link

Member

jakebailey commentedApr 2, 2024•
edited
Loading

Cloning webpack, doingyarn, then runningtsc -p ./tsconfig.types.json on main and with this PR does produce a difference:

$git clone git@github.com:webpack/webpack.git$cd webpack$yarn$node~/work/TypeScript/built/local-old/tsc.js -p tsconfig.types.json|& tee~/out-main.txt$node~/work/TypeScript/built/local/tsc.js -p tsconfig.types.json|& tee~/out-pr.txt$wc -l~/out-main.txt~/out-pr.txt  3188 /home/jabaile/out-main.txt  3187 /home/jabaile/out-pr.txt  6375 total$gdiff~/out-main.txt~/out-pr.txt

diff --git a/home/jabaile/out-main.txt b/home/jabaile/out-pr.txtindex c825c4baf..0b70c6f9f 100644--- a/home/jabaile/out-main.txt+++ b/home/jabaile/out-pr.txt@@ -2004,7 +2004,6 @@ lib/optimize/SplitChunksPlugin.js(1011,30): error TS7006: Parameter 'key' implic lib/optimize/SplitChunksPlugin.js(1022,37): error TS7006: Parameter 'key' implicitly has an 'any' type. lib/optimize/SplitChunksPlugin.js(1095,35): error TS18048: 'cacheGroup.minChunks' is possibly 'undefined'. lib/optimize/SplitChunksPlugin.js(1099,9): error TS2722: Cannot invoke an object which is possibly 'undefined'.-lib/optimize/SplitChunksPlugin.js(1099,9): error TS18048: 'cacheGroup.getName' is possibly 'undefined'. lib/optimize/SplitChunksPlugin.js(1254,21): error TS18048: 'cacheGroup.minChunks' is possibly 'undefined'. lib/optimize/SplitChunksPlugin.js(1687,37): error TS7006: Parameter 'value' implicitly has an 'any' type. lib/optimize/SplitChunksPlugin.js(1687,44): error TS7006: Parameter 'key' implicitly has an 'any' type.

This difference appears no matter what order I run things or the clean-ness of the repo. So, I think the bot is correct here.

Copy link

Member

jakebailey commentedApr 2, 2024•
edited
Loading

Also, I modified this PR to forcehasFlowEffects to always be true, and the error count went back to the one on main, so it's definitely some behavior change in the PR (somehow).

Trial and error says that it's something to do with the= false inbindConditionalExpressionFlow; forcing that one to true also "fixes" the error, so maybe that's where it's diverging, somehow... I haven't had time to try and cut it down further.

Copy link

MemberAuthor

ahejlsberg commentedApr 3, 2024

@jakebailey Yeah, sorry, I see what's going on now. What confused me is that we used to issue two errors, and now we only issue one, but the errors have the exact same location. The missing error is an effect of optimizing away part of the control flow graph, causing us to not callgetEffectsSignature, the method that resolves signatures in control flow analysis. For a variety of reasons we can't use the regular (and more complex) signature resolution in CFA, and the CFA resolution reports nullable errors slightly differently. Anyway, the error that went away is just a (differently worded) duplicate, so there's no problem here.