- Notifications
You must be signed in to change notification settings - Fork13.2k
fix(57141): override keyword doesn't check symbol-key class members#57146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tests/baselines/reference/nodeModulesAllowJsImportHelpersCollisions3(module=nodenext).jsShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
iisaduan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ThenodeModules.... baselines should be reverted since#57220 was merged after this PR was last updated. Pulling/merging main, and then updating baselines should revert them!
Otherwise, the PR looks good!
Fixes#57141