NotificationsYou must be signed in to change notification settings
Fork13.1k
Star107k

Improve constraints of conditional types applied to constrained type variables#56004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ahejlsberg merged 9 commits intomainfromfix30152

Nov 21, 2023

Merged

Improve constraints of conditional types applied to constrained type variables#56004

ahejlsberg merged 9 commits intomainfromfix30152

Nov 21, 2023

Conversation

Copy link

Member

ahejlsberg commentedOct 6, 2023•
edited
Loading

With this PR we compute more accurate constraints for distributive conditional types applied to constrained type variables. For example:

typeIsArray<T>=Textendsany[] ?true :false;functionf1<Uextendsobject>(x:IsArray<U>){lett:true=x;// Errorletf:false=x;// Error, but previously wasn't}

Previously, we'd obtain the constraint ofIsArray<U> by applying the distributive conditional type to the constraint ofU, which resolves tofalse (becauseobject doesn't extendany[]). But really, it ought to beboolean (i.e.true | false) since clearly something constrained toobject both could or could not be an array.

A type variable represents any possible type within its constraint. So, given a type parameterT with the constraintC, the constraint ofT extends X ? A : B is

A whenC is known to always extendX,
B whenC is known to never extendX, or
A | B whenC possibly extendsX.

We previously didn't consider the third possibility. With this PR, we choose the third outcome whenC is not assignable toX, butX (or, ifX is a union type, some constituent ofX) is assignable toC.

Fixes#30152.

ahejlsberg added5 commits

October 5, 2023 11:24

Fix constraint of conditional type applied to constrained type variable

c0ae93f

Accept new baselines

03a45f4

Shrink some error pyramids

388daf5

Accept new baselines

5082d17

Add tests

2f5d9e9

typescript-bot assignedahejlsberg

Oct 6, 2023

typescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labels

Oct 6, 2023

Copy link

MemberAuthor

ahejlsberg commentedOct 6, 2023

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at2f5d9e9. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the diff-based user code test suite on this PR at2f5d9e9. You can monitor the buildhere.

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the tsc-only perf test suite on this PR at2f5d9e9. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the diff-based top-repos suite on this PR at2f5d9e9. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,077k (± 0.02%)}	_{295,077k (± 0.01%)}	_~	_295,034k	_295,133k	_{p=0.689 n=6}
_{Parse Time}	_{2.63s (± 0.48%)}	_{2.63s (± 0.64%)}	_~	_2.61s	_2.65s	_{p=1.000 n=6}
_{Bind Time}	_{0.84s (± 0.89%)}	_{0.84s (± 1.06%)}	_~	_0.83s	_0.85s	_{p=0.798 n=6}
_{Check Time}	_{8.06s (± 0.20%)}	_{8.07s (± 0.21%)}	_~	_8.04s	_8.09s	_{p=0.217 n=6}
_{Emit Time}	_{7.05s (± 0.66%)}	_{7.05s (± 0.37%)}	_~	_7.02s	_7.10s	_{p=0.805 n=6}
_{Total Time}	_{18.58s (± 0.27%)}	_{18.59s (± 0.21%)}	_~	_18.54s	_18.65s	_{p=0.629 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{190,688k (± 0.01%)}	_{191,664k (± 1.24%)}	_~	_190,674k	_196,504k	_{p=0.378 n=6}
_{Parse Time}	_{1.35s (± 0.38%)}	_{1.34s (± 0.61%)}	_~	_1.33s	_1.35s	_{p=0.523 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.20s (± 0.73%)}	_{9.20s (± 0.89%)}	_~	_9.15s	_9.37s	_{p=0.809 n=6}
_{Emit Time}	_{2.63s (± 0.52%)}	_{2.60s (± 0.32%)}	_{-0.02s (- 0.82%)}	_2.60s	_2.62s	_{p=0.013 n=6}
_{Total Time}	_{13.90s (± 0.46%)}	_{13.88s (± 0.58%)}	_~	_13.83s	_14.04s	_{p=0.463 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,295k (± 0.01%)}	_{347,297k (± 0.01%)}	_~	_347,256k	_347,322k	_{p=0.810 n=6}
_{Parse Time}	_{2.46s (± 0.48%)}	_{2.47s (± 0.30%)}	_~	_2.46s	_2.48s	_{p=0.150 n=6}
_{Bind Time}	_{0.94s (± 0.87%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.89s (± 0.30%)}	_{6.93s (± 0.42%)}	_{+0.04s (+ 0.61%)}	_6.89s	_6.97s	_{p=0.023 n=6}
_{Emit Time}	_{4.03s (± 0.69%)}	_{4.02s (± 0.44%)}	_~	_4.01s	_4.05s	_{p=1.000 n=6}
_{Total Time}	_{14.31s (± 0.20%)}	_{14.36s (± 0.27%)}	_~	_14.30s	_14.39s	_{p=0.052 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,555k (± 0.01%)}	_{302,545k (± 0.00%)}	_~	_302,535k	_302,556k	_{p=0.687 n=6}
_{Parse Time}	_{2.00s (± 0.58%)}	_{2.00s (± 1.07%)}	_~	_1.97s	_2.03s	_{p=0.870 n=6}
_{Bind Time}	_{1.00s (± 1.04%)}	_{1.00s (± 0.41%)}	_~	_1.00s	_1.01s	_{p=0.528 n=6}
_{Check Time}	_{6.25s (± 0.58%)}	_{6.26s (± 0.31%)}	_~	_6.23s	_6.28s	_{p=0.568 n=6}
_{Emit Time}	_{3.57s (± 0.29%)}	_{3.56s (± 0.60%)}	_~	_3.52s	_3.58s	_{p=0.616 n=6}
_{Total Time}	_{12.82s (± 0.23%)}	_{12.81s (± 0.33%)}	_~	_12.74s	_12.86s	_{p=0.871 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,530k (± 0.00%)}	_{568,506k (± 0.01%)}	_{🔻+97,977k (+20.82%)}	_568,446k	_568,552k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.72%)}	_{2.58s (± 0.55%)}	_~	_2.56s	_2.60s	_{p=0.516 n=6}
_{Bind Time}	_{0.99s (± 0.99%)}	_{0.99s (± 1.18%)}	_~	_0.97s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{16.61s (± 0.59%)}	_{19.11s (± 0.66%)}	_{🔻+2.50s (+15.03%)}	_18.94s	_19.29s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.40%)}	_{22.68s (± 0.48%)}	_{🔻+2.50s (+12.40%)}	_22.53s	_22.83s	_{p=0.005 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,583k (± 0.02%)}	_{511,800k (± 0.02%)}	_{-784k (- 0.15%)}	_511,733k	_511,963k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.39%)}	_{3.27s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=0.868 n=6}
_{Bind Time}	_{1.55s (± 0.58%)}	_{1.55s (± 0.53%)}	_~	_1.54s	_1.56s	_{p=0.550 n=6}
_{Check Time}	_{2.87s (± 0.19%)}	_{2.83s (± 0.65%)}	_{-0.04s (- 1.28%)}	_2.81s	_2.86s	_{p=0.008 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.15%)}	_{7.72s (± 0.23%)}	_{-0.04s (- 0.54%)}	_7.70s	_7.75s	_{p=0.008 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedOct 6, 2023

@ahejlsberg Here are the results of running the top-repos suite comparingmain andrefs/pull/56004/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

7 of 13 projects failed to build with the old tsc and were ignored

packages/cli/templates/default-react-plugin-package/tsconfig.json

error TS2589: Type instantiation is excessively deep and possibly infinite.
- packages/core-app-api/src/apis/implementations/TranslationApi/I18nextTranslationApi.ts#L305

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7006: Parameter 'values' implicitly has an 'any' type.
- src/logic/createFormControl.ts#L1279

vuejs/core

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

error TS2322: Type 'T | DeepReadonly<UnwrapNestedRefs<T & Record<any, any>>>' is not assignable to type 'T'.
- packages/reactivity/src/reactive.ts#L417

tsconfig.json

error TS2322: Type 'T | DeepReadonly<UnwrapNestedRefs<T & Record<any, any>>>' is not assignable to type 'T'.
- packages/reactivity/src/reactive.ts#L417

Copy link

Collaborator

typescript-bot commentedOct 6, 2023

Hey@ahejlsberg, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: reflexbox
Error:

Error: Errors in typescript@local for external dependencies:node_modules/@emotion/styled/types/base.d.ts(127,22): error TS2344: Type 'ForwardedProps' does not satisfy the constraint 'keyof PropsOf<C>'.  Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof PropsOf<C>'.    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.      Type 'ForwardedProps' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.        Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.          Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.            Type 'ForwardedProps' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.              Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                  Type 'ForwardedProps' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                      Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                        Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                          Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                            Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                              Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                Type 'keyof ComponentProps<C> & string' is not assignable to type 'never'.node_modules/@emotion/styled/types/base.d.ts(157,22): error TS2344: Type 'ForwardedProps' does not satisfy the constraint 'keyof PropsOf<C>'.  Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof PropsOf<C>'.    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.      Type 'ForwardedProps' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.        Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.          Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.            Type 'ForwardedProps' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.              Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                  Type 'ForwardedProps' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                      Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                        Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                          Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                            Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                              Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                Type 'keyof ComponentProps<C> & string' is not assignable to type 'never'.    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:194:15)    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:151:9)

Package: knex-cleaner
Error:

Error: Errors in typescript@local for external dependencies:node_modules/knex/types/index.d.ts(1240,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.  Type 'unknown' is not assignable to type '{}'.node_modules/knex/types/index.d.ts(1255,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:194:15)    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:151:9)

Package: mui-datatables
Error:

Error: Errors in typescript@local for external dependencies:node_modules/@emotion/styled/types/base.d.ts(127,22): error TS2344: Type 'ForwardedProps' does not satisfy the constraint 'keyof PropsOf<C>'.  Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof PropsOf<C>'.    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.      Type 'ForwardedProps' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.        Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.          Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.            Type 'ForwardedProps' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.              Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                  Type 'ForwardedProps' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                      Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                        Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                          Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                            Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                              Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                Type 'keyof ComponentProps<C> & string' is not assignable to type 'never'.node_modules/@emotion/styled/types/base.d.ts(157,22): error TS2344: Type 'ForwardedProps' does not satisfy the constraint 'keyof PropsOf<C>'.  Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof PropsOf<C>'.    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.      Type 'ForwardedProps' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.        Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...> & keyof (C extends MemoExoticComponent<...> | LazyExoticComponent<...> ? ReactManagedAttributes<...> : ReactManagedAttributes<...>)'.          Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.            Type 'ForwardedProps' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.              Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                  Type 'ForwardedProps' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                    Type 'keyof ComponentProps<C> & string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                      Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                        Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                          Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                            Type 'keyof ComponentProps<C> & string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                              Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                Type 'keyof ComponentProps<C> & string' is not assignable to type 'never'.node_modules/@mui/styled-engine/index.d.ts(160,22): error TS2344: Type 'ForwardedProps' does not satisfy the constraint 'keyof PropsOf<C>'.  Type 'keyof ComponentProps<C>' is not assignable to type 'keyof PropsOf<C>'.    Type 'string | number | symbol' is not assignable to type 'keyof PropsOf<C>'.      Type 'string' is not assignable to type 'keyof PropsOf<C>'.        Type 'string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.          Type 'keyof ComponentProps<C>' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.            Type 'ForwardedProps' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.              Type 'keyof ComponentProps<C>' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.                Type 'string | number | symbol' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.                  Type 'string' is not assignable to type 'keyof ComponentProps<C> & keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>> & keyof Defaultize<...> & keyof Defaultize<...>'.                    Type 'string' is not assignable to type 'keyof ComponentProps<C>'.                      Type 'keyof ComponentProps<C>' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                        Type 'ForwardedProps' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                          Type 'keyof ComponentProps<C>' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                            Type 'string | number | symbol' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                              Type 'string' is not assignable to type 'keyof MergePropTypes<ComponentProps<C>, InferProps<WeakValidationMap<ComponentProps<C>> | undefined>>'.                                Type 'string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                  Type 'keyof ComponentProps<C>' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                    Type 'ForwardedProps' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                      Type 'keyof ComponentProps<C>' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                        Type 'string | number | symbol' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                          Type 'string' is not assignable to type 'keyof (IsExactlyAny<ComponentProps<C>> extends true ? InferProps<WeakValidationMap<ComponentProps<C>> | undefined> : string extends keyof ComponentProps<...> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                            Type 'string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                              Type 'keyof ComponentProps<C>' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                                Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                                  Type 'keyof ComponentProps<C>' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                                    Type 'string | number | symbol' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                                      Type 'string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined> & keyof (string extends keyof ComponentProps<C> ? ComponentProps<...> : Pick<...> & ... 1 more ... & Pick<...>)'.                                                        Type 'string' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                                          Type 'keyof ComponentProps<C>' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                                            Type 'ForwardedProps' is not assignable to type 'RequiredKeys<WeakValidationMap<ComponentProps<C>> | undefined>'.                                                              Type 'keyof ComponentProps<C>' is not assignable to type 'never'.                                                                Type 'string | number | symbol' is not assignable to type 'never'.                                                                  Type 'string' is not assignable to type 'never'.    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:194:15)    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:151:9)

Package: knex-db-manager
Error:

Error: Errors in typescript@local for external dependencies:node_modules/knex/types/index.d.ts(1091,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.  Type 'unknown' is not assignable to type '{}'.node_modules/knex/types/index.d.ts(1103,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:194:15)    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint/dist/index.js:151:9)

You can check the log here.

Copy link

Member

gabritto commentedOct 6, 2023

@typescript-bot pack this

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@gabritto, I've started to run the tarball bundle task on this PR at2f5d9e9. You can monitor the buildhere.

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Hey@gabritto, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158126/artifacts?artifactName=tgz&fileId=C312C2036DEE5998F78828DF563EFC75917CF2508AF2CDEC50D916C993783F9502&fileName=/typescript-5.3.0-insiders.20231006.tgz"    }}

and then runningnpm install.

There is also a playgroundfor this build and annpm module you can use via"typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-56004-10".;

Use reverse assignable check instead of comparable check

c7613d6

Copy link

MemberAuthor

ahejlsberg commentedOct 6, 2023

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the diff-based user code test suite on this PR atc7613d6. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the tsc-only perf test suite on this PR atc7613d6. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR atc7613d6. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023•
edited
Loading

Heya@ahejlsberg, I've started to run the diff-based top-repos suite on this PR atc7613d6. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedOct 6, 2023

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,069k (± 0.01%)}	_{295,049k (± 0.02%)}	_~	_294,949k	_295,095k	_{p=0.378 n=6}
_{Parse Time}	_{2.64s (± 0.48%)}	_{2.63s (± 0.40%)}	_~	_2.62s	_2.65s	_{p=0.456 n=6}
_{Bind Time}	_{0.84s (± 0.99%)}	_{0.85s (± 0.96%)}	_~	_0.83s	_0.85s	_{p=0.673 n=6}
_{Check Time}	_{8.05s (± 0.54%)}	_{8.06s (± 0.31%)}	_~	_8.02s	_8.10s	_{p=0.568 n=6}
_{Emit Time}	_{7.05s (± 0.56%)}	_{7.05s (± 0.20%)}	_~	_7.03s	_7.07s	_{p=0.366 n=6}
_{Total Time}	_{18.59s (± 0.25%)}	_{18.59s (± 0.19%)}	_~	_18.54s	_18.65s	_{p=0.936 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,451k (± 1.26%)}	_{191,117k (± 0.54%)}	_~	_190,663k	_193,214k	_{p=0.065 n=6}
_{Parse Time}	_{1.34s (± 0.61%)}	_{1.34s (± 1.31%)}	_~	_1.31s	_1.35s	_{p=0.730 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.21s (± 1.04%)}	_{9.21s (± 0.75%)}	_~	_9.13s	_9.32s	_{p=1.000 n=6}
_{Emit Time}	_{2.63s (± 0.81%)}	_{2.60s (± 0.63%)}	_~	_2.59s	_2.63s	_{p=0.061 n=6}
_{Total Time}	_{13.91s (± 0.79%)}	_{13.88s (± 0.50%)}	_~	_13.82s	_14.01s	_{p=0.573 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,311k (± 0.01%)}	_{347,286k (± 0.01%)}	_~	_347,265k	_347,312k	_{p=0.093 n=6}
_{Parse Time}	_{2.46s (± 0.33%)}	_{2.46s (± 0.42%)}	_~	_2.44s	_2.47s	_{p=0.932 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.67%)}	_~	_0.93s	_0.95s	_{p=0.673 n=6}
_{Check Time}	_{6.94s (± 0.51%)}	_{6.90s (± 0.42%)}	_~	_6.87s	_6.94s	_{p=0.089 n=6}
_{Emit Time}	_{4.03s (± 0.41%)}	_{4.03s (± 0.26%)}	_~	_4.01s	_4.04s	_{p=1.000 n=6}
_{Total Time}	_{14.37s (± 0.25%)}	_{14.33s (± 0.16%)}	_~	_14.30s	_14.36s	_{p=0.075 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,551k (± 0.00%)}	_{302,542k (± 0.00%)}	_~	_302,524k	_302,561k	_{p=0.336 n=6}
_{Parse Time}	_{1.99s (± 1.00%)}	_{2.00s (± 1.08%)}	_~	_1.98s	_2.03s	_{p=0.328 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=0.931 n=6}
_{Check Time}	_{6.24s (± 0.29%)}	_{6.24s (± 0.34%)}	_~	_6.21s	_6.26s	_{p=0.935 n=6}
_{Emit Time}	_{3.57s (± 0.34%)}	_{3.57s (± 0.41%)}	_~	_3.55s	_3.59s	_{p=0.564 n=6}
_{Total Time}	_{12.80s (± 0.29%)}	_{12.82s (± 0.24%)}	_~	_12.78s	_12.86s	_{p=0.571 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,502k (± 0.00%)}	_{470,551k (± 0.00%)}	_{+49k (+ 0.01%)}	_470,528k	_470,580k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.16%)}	_{2.58s (± 0.68%)}	_~	_2.55s	_2.60s	_{p=0.246 n=6}
_{Bind Time}	_{1.00s (± 0.63%)}	_{0.99s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.091 n=6}
_{Check Time}	_{16.60s (± 0.47%)}	_{16.73s (± 0.20%)}	_{+0.13s (+ 0.76%)}	_16.70s	_16.78s	_{p=0.016 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.17s (± 0.36%)}	_{20.30s (± 0.20%)}	_{+0.13s (+ 0.64%)}	_20.24s	_20.36s	_{p=0.010 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,602k (± 0.02%)}	_{511,778k (± 0.01%)}	_{-824k (- 0.16%)}	_511,714k	_511,836k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.42%)}	_{3.28s (± 0.25%)}	_~	_3.27s	_3.29s	_{p=0.183 n=6}
_{Bind Time}	_{1.55s (± 0.53%)}	_{1.55s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.206 n=6}
_{Check Time}	_{2.86s (± 1.05%)}	_{2.81s (± 0.61%)}	_{-0.05s (- 1.92%)}	_2.78s	_2.83s	_{p=0.005 n=6}
_{Emit Time}	_{0.08s (± 7.90%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.52%)}	_{7.70s (± 0.18%)}	_{-0.05s (- 0.71%)}	_7.69s	_7.73s	_{p=0.009 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Copy link

Collaborator

typescript-bot commentedOct 6, 2023

@ahejlsberg Here are the results of running the user test suite comparingmain andrefs/pull/56004/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Everything looks good!

Copy link

MemberAuthor

ahejlsberg commentedOct 6, 2023

Latest commit changes checking for the "possibly extends" case to use a reverse assignability check. This check is not quite as permissible as a comparability check, meaning we'll less often hit the "possibly extends" case where the constraint is a union. Still, since constraint types are typically close-to-top types (likeobject or{}), it isn't likely to matter. And, certainly, performance with the reverse assignability test is much more acceptable.

ahejlsberg added this to theTypeScript 5.4.0 milestone

Oct 6, 2023

Copy link

MemberAuthor

ahejlsberg commentedOct 15, 2023

@MichaelMitchell-at That was an earlier copy of the PR. It works witha current build.

Copy link

Contributor

MichaelMitchell-at commentedOct 18, 2023

I tried the current build in our code base and ran into a couple of errors that I'm having trouble creating a minimal reproduction that I can share. In general they seem to arise when generics are involved together with complex conditional types. I wonder if I'm having trouble producing a minimal repro because in the actual code we're hitting one of the depth limits that exists in the type checker.

Unrelated, but just mentioning while I have your attention with the hope y'all will keep in mind, is on nightly I'm encountering a newThe inferred type of this node exceeds the maximum length the compiler will serialize error. It's not really actionable on our side; the object is created by composing a bunch of schema objects from our in-houseZod-like library. One of the reasons to use the schema library is to avoid needing to write out the type by hand. It would probably only help us temporarily if the max length were increased; A more long-term approach might be some ability to give users more control over when type aliases are used/expanded in types when serialized/displayed.

ahejlsberg merged commit38ef79e intomain

Nov 21, 2023

ahejlsberg deleted the fix30152 branch

November 21, 2023 01:08

This was referencedNov 21, 2023

Add knex dependents to expected failuresmicrosoft/DefinitelyTyped-tools#840

Merged

Fix types for TypeScript 5.4knex/knex#5747

Merged

RyanCavanaugh mentioned this pull request

Jan 22, 2024

[NewErrors] 5.4.0-dev.20240121 vs 5.3.3#57117

Closed

voxpelli mentioned this pull request

Jan 29, 2024

Canary:MergeDeep failures intypescript@next not detected by canary testssindresorhus/type-fest#784

Closed

Copy link

voxpelli commentedJan 29, 2024

As an FYI in case anyone follows this issue, it turned out that this caused a regression intype-fest and I'm still debugging why and/or how to fix, but want to mention here in the meanwhile, might file an issue later:sindresorhus/type-fest#784

voxpelli added a commit to sindresorhus/type-fest that referenced this pull request

Jan 29, 2024

FixMergeDeep in TypeScript 5.4

ee12b05

After the change inmicrosoft/TypeScript#56004 the `PickRestType` was causing some types to be considered theoretically infinite in their recursion.I can't wrap my mind around exactly why right now, but I can see how `PickRestType` on a crazy long tuple will cause a very deep recursion, so I decided to simply cap its recursion and return `unknown[]` if it goes past that point and that solved the errors.Side effects:- In practice: rarely any I believe- In theory: some merged types will regress to `unknown[]` in TypeScript versions older than 5.4Considerations:Is the `DepthTracker extends Array<true> = []` + `PickRestTypeMaxDepth extends DepthTracker['length']` a good way to track depth? I know I have done a depth check previous times but can't remember what solution I picked then.Fixes#784

voxpelli mentioned this pull request

Jan 29, 2024

FixMergeDeep in TypeScript 5.4sindresorhus/type-fest#806

Closed

DanielRosenwasser mentioned this pull request

Jan 30, 2024

Design Meeting Notes, 1/24/2024#57241

Closed

acutmore mentioned this pull request

Feb 21, 2024

Bloomberg feedback for 5.4 Beta#57464

Closed

1 task

Andarist mentioned this pull request

Mar 5, 2024

Generic conditional type prematurely resolves to one of the branches instead of deferring#57650

Open

aryaemami59 mentioned this pull request

Mar 8, 2024

Update TypeScript to 5.4reduxjs/redux-toolkit#4255

Merged

4 tasks

dsherret mentioned this pull request

Mar 9, 2024

Type errors when using TypeScript 5.4dsherret/ts-morph#1513

Closed

cjquines mentioned this pull request

Mar 20, 2024

Typescript error "Excessive stack depth" forhasAtLeastremeda/remeda#572

Closed

RyanCavanaugh mentioned this pull request

Mar 20, 2024

"Expression produces a union type that is too complex to represent" when using interfaces with large number of params for filtering and narrowing down certain keys#57863

Closed

DanielRosenwasser mentioned this pull request

Mar 20, 2024

Regression 5.4: the new conditional type constraint is not working with a type parameter representing union type#57864

Closed

RyanCavanaugh mentioned this pull request

Mar 20, 2024

regression in 5.4: error TS2604: JSX element type 'Cmp' does not have any construct or call signatures.#57862

Closed

cjquines mentioned this pull request

Mar 23, 2024

Regression in 5.4: Excessive stack depth when comparing recursive type#57915

Closed

MajorLift mentioned this pull request

Mar 23, 2024

Regression in TypeScript 5.4: "Excessive stack depth comparing types" errorspoteat/hkt-toolbelt#80

Closed

br41nslug mentioned this pull request

Apr 18, 2024

SDK TypeScript 5.4 compatibilitydirectus/directus#22211

Merged

Haroenv added a commit to algolia/instantsearch that referenced this pull request

Jun 20, 2024

fix(types): make algoliasearch detection compatible with TS 5.4.5

1d6fd7a

I can't manage to reproduce this locally, even if i update everything to 5.4.5, but in a fresh Next.js example (likehttps://codesandbox.io/s/47fy7c) `hitsPerPage` isn't accepted to Configure (because PlainSearchParameters is any)This is I believe linked tomicrosoft/TypeScript#56004, maybe also tosindresorhus/type-fest#846 (although the case seems different).Essentially before this change the types like `ClientLiteV5` were evaluated to `any` instead of `unknown`, poisoning the entire type and turning everything into any.The solution is to first check if `typeof AlgoliaSearchLite` is any, and if it is any we don't even evaluate the rest of teh type. Of course if it isn't any it works correctly for v5 still.Again, unfortunately this isn't reproducible in this repo, even when every typescript version is updated to 5.4.5, but at least the error will be fixedfixes#5989

Haroenv mentioned this pull request

Jun 20, 2024

fix(types): make algoliasearch detection compatible with TS 5.4.5algolia/instantsearch#6244

Merged

Haroenv added a commit to algolia/instantsearch that referenced this pull request

Jun 20, 2024

fix(types): make algoliasearch detection compatible with TS 5.4.5 (#6244

4a7afc3

)I can't manage to reproduce this locally, even if i update everything to 5.4.5, but in a fresh Next.js example (likehttps://codesandbox.io/s/47fy7c) `hitsPerPage` isn't accepted to Configure (because PlainSearchParameters is any)This is I believe linked tomicrosoft/TypeScript#56004, maybe also tosindresorhus/type-fest#846 (although the case seems different).Essentially before this change the types like `ClientLiteV5` were evaluated to `any` instead of `unknown`, poisoning the entire type and turning everything into any.The solution is to first check if `typeof AlgoliaSearchLite` is any, and if it is any we don't even evaluate the rest of teh type. Of course if it isn't any it works correctly for v5 still.Again, unfortunately this isn't reproducible in this repo, even when every typescript version is updated to 5.4.5, but at least the error will be fixedfixes#5989

LukeAbby mentioned this pull request

Aug 17, 2024

Type Instantiation is Excessively Deep Regression In #56004#59667

Open

This was referencedSep 5, 2024

Constraints of nested conditional types applied to constrained type variables are incorrect#59868

Open

Improve constraints of nested conditional types applied to constrained type variables#59886

Open

microsoft locked asresolvedand limited conversation to collaborators

Oct 16, 2025

Labels

Author: Team For Milestone Bug

PRs that fix a bug with a specific milestone

7 participants

Movatterモバイル変換

Improve constraints of conditional types applied to constrained type variables#56004

Improve constraints of conditional types applied to constrained type variables#56004

Uh oh!

Conversation

ahejlsberg commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commentedOct 6, 2023

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023

Compiler

Uh oh!

typescript-bot commentedOct 6, 2023

backstage/backstage

packages/cli/templates/default-react-plugin-package/tsconfig.json

react-hook-form/react-hook-form

tsconfig.json

vuejs/core

tsconfig.build.json

tsconfig.json

Uh oh!

typescript-bot commentedOct 6, 2023

Uh oh!

gabritto commentedOct 6, 2023

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commentedOct 6, 2023

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedOct 6, 2023

Compiler

Uh oh!

typescript-bot commentedOct 6, 2023

Uh oh!

ahejlsberg commentedOct 6, 2023

Uh oh!

ahejlsberg commentedOct 15, 2023

Uh oh!

MichaelMitchell-at commentedOct 18, 2023

Uh oh!

voxpelli commentedJan 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ahejlsberg commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading

typescript-bot commentedOct 6, 2023•
edited
Loading