NotificationsYou must be signed in to change notification settings
Fork13.2k
Star107k

Improve error for unclosed imports and exports#54634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sandersn merged 3 commits intomicrosoft:mainfromJack-Works:improve-error-for-unclosed-import-export

Jun 29, 2023

Merged

Improve error for unclosed imports and exports#54634

sandersn merged 3 commits intomicrosoft:mainfromJack-Works:improve-error-for-unclosed-import-export

Jun 29, 2023

Conversation

Copy link

Contributor

Jack-Works commentedJun 13, 2023•
edited
Loading

this fix is picked from#49297
before:

after:

Improve error for unclosed imports and exports

b8adea4

typescript-bot added the For Uncommitted BugPR for untriaged, rejected, closed or missing bug label

Jun 13, 2023

Copy link

Collaborator

typescript-bot commentedJun 13, 2023

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

fix: error

27d107e

sandersn self-assigned this

Jun 28, 2023

sandersn requested review fromgabritto andsandersn

June 28, 2023 17:49

Copy link

Member

sandersn commentedJun 28, 2023

@typescript-bot perf test this

Copy link

Collaborator

typescript-bot commentedJun 28, 2023•
edited
Loading

Heya@sandersn, I've started to run the perf test suite on this PR at27d107e. You can monitor the buildhere.

Update:The results are in!

sandersn approved these changes

Jun 28, 2023

View reviewed changes

Copy link

Member

sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me as long as the lookahead doesn't hurt performance (and I doubt it will since ParsingContext.ImportOrExportSpecifiers doesn't come up much)

Copy link

Collaborator

typescript-bot commentedJun 28, 2023

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54634

_Metric	_main	₅₄₆₃₄	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,753k (± 0.01%)}	_{366,748k (± 0.01%)}	_~	_366,710k	_366,777k	_{p=0.810 n=6}
_{Parse Time}	_{3.46s (± 0.60%)}	_{3.40s (± 0.51%)}	_{-0.06s (- 1.69%)}	_3.38s	_3.43s	_{p=0.008 n=6}
_{Bind Time}	_{1.12s (± 0.67%)}	_{1.11s (± 0.75%)}	_~	_1.11s	_1.13s	_{p=0.172 n=6}
_{Check Time}	_{8.88s (± 0.44%)}	_{8.82s (± 0.19%)}	_{-0.06s (- 0.73%)}	_8.80s	_8.84s	_{p=0.013 n=6}
_{Emit Time}	_{7.54s (± 0.90%)}	_{7.50s (± 0.35%)}	_~	_7.47s	_7.53s	_{p=0.335 n=6}
_{Total Time}	_{21.00s (± 0.52%)}	_{20.83s (± 0.19%)}	_{-0.17s (- 0.81%)}	_20.77s	_20.88s	_{p=0.013 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,823k (± 1.63%)}	_{190,965k (± 0.02%)}	_~	_190,930k	_191,000k	_{p=0.378 n=6}
_{Parse Time}	_{1.50s (± 0.91%)}	_{1.49s (± 0.55%)}	_{-0.02s (- 1.22%)}	_1.48s	_1.50s	_{p=0.032 n=6}
_{Bind Time}	_{0.77s (± 0.00%)}	_{0.77s (± 0.72%)}	_~	_0.76s	_0.77s	_{p=0.071 n=6}
_{Check Time}	_{9.49s (± 0.82%)}	_{9.46s (± 0.85%)}	_~	_9.39s	_9.60s	_{p=0.373 n=6}
_{Emit Time}	_{2.76s (± 0.68%)}	_{2.77s (± 1.31%)}	_~	_2.73s	_2.83s	_{p=0.747 n=6}
_{Total Time}	_{14.52s (± 0.45%)}	_{14.48s (± 0.65%)}	_~	_14.38s	_14.64s	_{p=0.418 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,806k (± 0.01%)}	_{346,793k (± 0.01%)}	_~	_346,773k	_346,827k	_{p=0.689 n=6}
_{Parse Time}	_{2.60s (± 0.97%)}	_{2.57s (± 0.58%)}	_~	_2.55s	_2.59s	_{p=0.086 n=6}
_{Bind Time}	_{1.01s (± 1.25%)}	_{1.00s (± 0.63%)}	_~	_0.99s	_1.01s	_{p=0.090 n=6}
_{Check Time}	_{7.22s (± 0.48%)}	_{7.16s (± 0.26%)}	_{-0.06s (- 0.85%)}	_7.14s	_7.19s	_{p=0.010 n=6}
_{Emit Time}	_{4.26s (± 1.01%)}	_{4.26s (± 0.58%)}	_~	_4.23s	_4.30s	_{p=1.000 n=6}
_{Total Time}	_{15.10s (± 0.64%)}	_{15.00s (± 0.24%)}	_~	_14.96s	_15.06s	_{p=0.092 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,881k (± 0.01%)}	_{300,877k (± 0.00%)}	_~	_300,865k	_300,889k	_{p=0.748 n=6}
_{Parse Time}	_{2.09s (± 1.16%)}	_{2.06s (± 0.89%)}	_~	_2.04s	_2.09s	_{p=0.051 n=6}
_{Bind Time}	_{1.14s (± 0.73%)}	_{1.13s (± 0.67%)}	_{-0.02s (- 1.46%)}	_1.12s	_1.14s	_{p=0.009 n=6}
_{Check Time}	_{6.68s (± 0.21%)}	_{6.67s (± 0.47%)}	_~	_6.65s	_6.73s	_{p=0.145 n=6}
_{Emit Time}	_{3.86s (± 0.69%)}	_{3.85s (± 1.11%)}	_~	_3.81s	_3.93s	_{p=0.460 n=6}
_{Total Time}	_{13.78s (± 0.20%)}	_{13.71s (± 0.32%)}	_{-0.08s (- 0.54%)}	_13.63s	_13.76s	_{p=0.010 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,455k (± 0.01%)}	_{482,438k (± 0.01%)}	_~	_482,326k	_482,511k	_{p=1.000 n=6}
_{Parse Time}	_{3.13s (± 0.44%)}	_{3.11s (± 0.44%)}	_{-0.02s (- 0.64%)}	_3.10s	_3.14s	_{p=0.042 n=6}
_{Bind Time}	_{0.92s (± 1.44%)}	_{0.91s (± 1.32%)}	_~	_0.90s	_0.93s	_{p=0.240 n=6}
_{Check Time}	_{17.44s (± 0.43%)}	_{17.25s (± 0.42%)}	_{-0.19s (- 1.09%)}	_17.19s	_17.38s	_{p=0.010 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.50s (± 0.38%)}	_{21.28s (± 0.28%)}	_{-0.22s (- 1.02%)}	_21.21s	_21.38s	_{p=0.005 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,567k (± 0.02%)}	_{563,534k (± 0.02%)}	_~	_563,484k	_563,703k	_{p=0.378 n=6}
_{Parse Time}	_{3.85s (± 0.75%)}	_{3.84s (± 0.48%)}	_~	_3.82s	_3.87s	_{p=0.870 n=6}
_{Bind Time}	_{1.64s (± 0.50%)}	_{1.63s (± 0.60%)}	_{-0.02s (- 0.91%)}	_1.62s	_1.64s	_{p=0.022 n=6}
_{Check Time}	_{2.80s (± 0.93%)}	_{2.80s (± 0.95%)}	_~	_2.75s	_2.83s	_{p=0.808 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.37s (± 0.42%)}	_{8.34s (± 0.28%)}	_~	_8.31s	_8.37s	_{p=0.108 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,124k (± 0.01%)}	_{366,136k (± 0.01%)}	_~	_366,103k	_366,196k	_{p=0.810 n=6}
_{Parse Time}	_{3.58s (± 0.23%)}	_{3.57s (± 0.25%)}	_{-0.01s (- 0.42%)}	_3.56s	_3.58s	_{p=0.021 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=0.069 n=6}
_{Check Time}	_{9.65s (± 0.57%)}	_{9.64s (± 0.59%)}	_~	_9.57s	_9.73s	_{p=0.809 n=6}
_{Emit Time}	_{8.01s (± 0.83%)}	_{7.96s (± 0.15%)}	_~	_7.95s	_7.98s	_{p=0.244 n=6}
_{Total Time}	_{22.42s (± 0.55%)}	_{22.34s (± 0.28%)}	_~	_22.28s	_22.44s	_{p=0.296 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,825k (± 0.02%)}	_{192,801k (± 0.02%)}	_~	_192,713k	_192,836k	_{p=0.296 n=6}
_{Parse Time}	_{1.60s (± 1.07%)}	_{1.57s (± 1.51%)}	_{-0.03s (- 1.98%)}	_1.54s	_1.60s	_{p=0.043 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.81s (± 0.63%)}	_{-0.01s (- 1.61%)}	_0.81s	_0.82s	_{p=0.009 n=6}
_{Check Time}	_{10.17s (± 0.56%)}	_{10.13s (± 0.36%)}	_~	_10.09s	_10.17s	_{p=0.687 n=6}
_{Emit Time}	_{3.04s (± 1.18%)}	_{3.01s (± 0.59%)}	_~	_2.98s	_3.03s	_{p=0.064 n=6}
_{Total Time}	_{15.63s (± 0.54%)}	_{15.53s (± 0.39%)}	_{-0.10s (- 0.67%)}	_15.44s	_15.59s	_{p=0.020 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,064k (± 0.01%)}	_{346,069k (± 0.00%)}	_~	_346,051k	_346,096k	_{p=1.000 n=6}
_{Parse Time}	_{2.74s (± 0.45%)}	_{2.72s (± 0.00%)}	_{-0.02s (- 0.91%)}	_2.72s	_2.72s	_{p=0.003 n=6}
_{Bind Time}	_{1.09s (± 0.00%)}	_{1.09s (± 0.75%)}	_~	_1.08s	_1.10s	_{p=0.290 n=6}
_{Check Time}	_{7.89s (± 0.38%)}	_{7.86s (± 0.33%)}	_{-0.04s (- 0.51%)}	_7.82s	_7.88s	_{p=0.030 n=6}
_{Emit Time}	_{4.48s (± 0.61%)}	_{4.45s (± 0.83%)}	_~	_4.41s	_4.52s	_{p=0.104 n=6}
_{Total Time}	_{16.21s (± 0.27%)}	_{16.11s (± 0.32%)}	_{-0.09s (- 0.59%)}	_16.06s	_16.20s	_{p=0.020 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,215k (± 0.01%)}	_{300,213k (± 0.01%)}	_~	_300,195k	_300,232k	_{p=0.689 n=6}
_{Parse Time}	_{2.19s (± 0.75%)}	_{2.17s (± 0.63%)}	_{-0.02s (- 0.91%)}	_2.16s	_2.20s	_{p=0.042 n=6}
_{Bind Time}	_{1.24s (± 0.83%)}	_{1.24s (± 0.66%)}	_~	_1.23s	_1.25s	_{p=0.270 n=6}
_{Check Time}	_{7.35s (± 0.61%)}	_{7.31s (± 0.35%)}	_~	_7.27s	_7.34s	_{p=0.106 n=6}
_{Emit Time}	_{4.35s (± 0.51%)}	_{4.34s (± 0.27%)}	_~	_4.32s	_4.35s	_{p=0.326 n=6}
_{Total Time}	_{15.14s (± 0.59%)}	_{15.05s (± 0.21%)}	_~	_15.02s	_15.10s	_{p=0.064 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,706k (± 0.01%)}	_{481,688k (± 0.01%)}	_~	_481,641k	_481,746k	_{p=0.378 n=6}
_{Parse Time}	_{3.27s (± 0.27%)}	_{3.26s (± 0.19%)}	_~	_3.25s	_3.27s	_{p=0.070 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.95s (± 0.54%)}	_{-0.01s (- 1.05%)}	_0.94s	_0.95s	_{p=0.018 n=6}
_{Check Time}	_{18.34s (± 0.65%)}	_{18.21s (± 0.46%)}	_{-0.12s (- 0.67%)}	_18.08s	_18.34s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.56s (± 0.56%)}	_{22.43s (± 0.36%)}	_{-0.14s (- 0.61%)}	_22.31s	_22.56s	_{p=0.030 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,181k (± 0.02%)}	_{561,216k (± 0.02%)}	_~	_561,059k	_561,383k	_{p=0.810 n=6}
_{Parse Time}	_{4.03s (± 0.44%)}	_{3.99s (± 0.27%)}	_{-0.04s (- 0.99%)}	_3.98s	_4.01s	_{p=0.008 n=6}
_{Bind Time}	_{1.75s (± 0.60%)}	_{1.74s (± 1.07%)}	_~	_1.72s	_1.77s	_{p=0.251 n=6}
_{Check Time}	_{3.06s (± 0.48%)}	_{3.05s (± 0.45%)}	_~	_3.02s	_3.06s	_{p=0.304 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{8.93s (± 0.15%)}	_{8.86s (± 0.31%)}	_{-0.07s (- 0.77%)}	_8.83s	_8.90s	_{p=0.005 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{360,100k (± 0.01%)}	_{360,106k (± 0.01%)}	_~	_360,074k	_360,155k	_{p=0.873 n=6}
_{Parse Time}	_{3.68s (± 0.53%)}	_{3.69s (± 0.63%)}	_~	_3.66s	_3.72s	_{p=0.328 n=6}
_{Bind Time}	_{1.23s (± 0.98%)}	_{1.22s (± 0.62%)}	_{-0.02s (- 1.22%)}	_1.21s	_1.23s	_{p=0.045 n=6}
_{Check Time}	_{10.11s (± 0.38%)}	_{10.08s (± 0.52%)}	_~	_10.01s	_10.14s	_{p=0.466 n=6}
_{Emit Time}	_{8.42s (± 0.68%)}	_{8.33s (± 0.31%)}	_{-0.09s (- 1.05%)}	_8.29s	_8.36s	_{p=0.037 n=6}
_{Total Time}	_{23.43s (± 0.33%)}	_{23.31s (± 0.32%)}	_{-0.12s (- 0.52%)}	_23.20s	_23.43s	_{p=0.020 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,155k (± 0.01%)}	_{188,126k (± 0.03%)}	_~	_188,035k	_188,180k	_{p=0.377 n=6}
_{Parse Time}	_{1.63s (± 0.50%)}	_{1.62s (± 0.65%)}	_~	_1.60s	_1.63s	_{p=0.078 n=6}
_{Bind Time}	_{0.85s (± 0.00%)}	_{0.84s (± 0.48%)}	_{-0.01s (- 0.98%)}	_0.84s	_0.85s	_{p=0.007 n=6}
_{Check Time}	_{10.34s (± 0.45%)}	_{10.24s (± 0.56%)}	_{-0.09s (- 0.89%)}	_10.16s	_10.31s	_{p=0.016 n=6}
_{Emit Time}	_{3.14s (± 0.81%)}	_{3.14s (± 1.03%)}	_~	_3.11s	_3.19s	_{p=0.935 n=6}
_{Total Time}	_{15.95s (± 0.33%)}	_{15.85s (± 0.51%)}	_{-0.11s (- 0.68%)}	_15.72s	_15.91s	_{p=0.030 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,191k (± 0.01%)}	_{341,182k (± 0.00%)}	_~	_341,167k	_341,193k	_{p=0.936 n=6}
_{Parse Time}	_{2.83s (± 0.55%)}	_{2.81s (± 0.27%)}	_~	_2.80s	_2.82s	_{p=0.050 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.12s (± 0.67%)}	_~	_1.11s	_1.13s	_{p=0.082 n=6}
_{Check Time}	_{8.25s (± 0.37%)}	_{8.19s (± 0.58%)}	_~	_8.14s	_8.27s	_{p=0.077 n=6}
_{Emit Time}	_{4.71s (± 0.78%)}	_{4.70s (± 0.99%)}	_~	_4.65s	_4.78s	_{p=0.573 n=6}
_{Total Time}	_{16.90s (± 0.34%)}	_{16.82s (± 0.47%)}	_~	_16.71s	_16.94s	_{p=0.075 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,306k (± 0.00%)}	_{295,309k (± 0.00%)}	_~	_295,303k	_295,313k	_{p=0.422 n=6}
_{Parse Time}	_{2.41s (± 0.93%)}	_{2.38s (± 0.93%)}	_~	_2.36s	_2.41s	_{p=0.062 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.48%)}	_~	_1.06s	_1.07s	_{p=1.000 n=6}
_{Check Time}	_{7.65s (± 0.36%)}	_{7.63s (± 0.49%)}	_~	_7.58s	_7.69s	_{p=0.469 n=6}
_{Emit Time}	_{4.31s (± 0.78%)}	_{4.29s (± 0.50%)}	_~	_4.26s	_4.32s	_{p=0.295 n=6}
_{Total Time}	_{15.43s (± 0.46%)}	_{15.37s (± 0.39%)}	_~	_15.31s	_15.48s	_{p=0.260 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,166k (± 0.00%)}	_{477,165k (± 0.00%)}	_~	_477,143k	_477,188k	_{p=1.000 n=6}
_{Parse Time}	_{3.36s (± 0.42%)}	_{3.32s (± 0.25%)}	_{-0.04s (- 1.09%)}	_3.31s	_3.33s	_{p=0.005 n=6}
_{Bind Time}	_{1.01s (± 0.00%)}	_{1.00s (± 0.00%)}	_{-0.01s (- 0.99%)}	_1.00s	_1.00s	_{p=0.001 n=6}
_{Check Time}	_{19.40s (± 0.72%)}	_{19.16s (± 0.35%)}	_{-0.24s (- 1.25%)}	_19.06s	_19.24s	_{p=0.008 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.77s (± 0.60%)}	_{23.48s (± 0.33%)}	_{-0.29s (- 1.23%)}	_23.37s	_23.57s	_{p=0.005 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,174k (± 0.01%)}	_{550,179k (± 0.00%)}	_~	_550,155k	_550,192k	_{p=0.298 n=6}
_{Parse Time}	_{4.25s (± 0.18%)}	_{4.22s (± 0.38%)}	_{-0.03s (- 0.71%)}	_4.20s	_4.24s	_{p=0.007 n=6}
_{Bind Time}	_{1.68s (± 1.15%)}	_{1.67s (± 0.59%)}	_~	_1.65s	_1.68s	_{p=0.156 n=6}
_{Check Time}	_{3.14s (± 0.66%)}	_{3.13s (± 0.47%)}	_~	_3.10s	_3.14s	_{p=0.871 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.15s (± 0.32%)}	_{9.11s (± 0.27%)}	_{-0.05s (- 0.51%)}	_9.07s	_9.14s	_{p=0.030 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₃₄	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54634

_Metric	_main	₅₄₆₃₄	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,575ms (± 0.93%)}	_{2,542ms (± 0.47%)}	_{-33ms (- 1.27%)}	_2,527ms	_2,556ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{5,373ms (± 0.79%)}	_{5,352ms (± 0.70%)}	_~	_5,311ms	_5,416ms	_{p=0.298 n=6}
_{Req 3 - references}	_{342ms (± 1.15%)}	_{342ms (± 0.86%)}	_~	_337ms	_346ms	_{p=0.628 n=6}
_{Req 4 - navto}	_{288ms (± 0.42%)}	_{286ms (± 0.36%)}	_~	_285ms	_288ms	_{p=0.084 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 3.73%)}	_{83ms (± 2.15%)}	_~	_81ms	_85ms	_{p=0.934 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,655ms (± 1.15%)}	_{2,654ms (± 0.98%)}	_~	_2,609ms	_2,678ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,136ms (± 1.98%)}	_{4,098ms (± 0.32%)}	_~	_4,085ms	_4,117ms	_{p=0.295 n=6}
_{Req 3 - references}	_{349ms (± 0.97%)}	_{349ms (± 0.47%)}	_~	_346ms	_350ms	_{p=0.747 n=6}
_{Req 4 - navto}	_{287ms (± 0.41%)}	_{287ms (± 0.51%)}	_~	_286ms	_290ms	_{p=0.666 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 1.26%)}	_{70ms (± 0.73%)}	_~	_70ms	_71ms	_{p=0.190 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,112ms (± 0.40%)}	_{3,100ms (± 0.44%)}	_~	_3,080ms	_3,118ms	_{p=0.148 n=6}
_{Req 2 - geterr}	_{1,604ms (± 0.64%)}	_{1,593ms (± 0.78%)}	_~	_1,578ms	_1,610ms	_{p=0.172 n=6}
_{Req 3 - references}	_{112ms (± 0.92%)}	_{113ms (± 1.07%)}	_~	_111ms	_114ms	_{p=0.675 n=6}
_{Req 4 - navto}	_{370ms (± 0.44%)}	_{370ms (± 0.91%)}	_~	_368ms	_377ms	_{p=0.514 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{378ms (± 1.50%)}	_{376ms (± 2.10%)}	_~	_363ms	_383ms	_{p=0.571 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,669ms (± 1.42%)}	_{2,637ms (± 0.66%)}	_~	_2,619ms	_2,664ms	_{p=0.092 n=6}
_{Req 2 - geterr}	_{5,988ms (± 1.75%)}	_{6,023ms (± 0.30%)}	_~	_6,004ms	_6,054ms	_{p=1.000 n=6}
_{Req 3 - references}	_{354ms (± 0.43%)}	_{354ms (± 0.59%)}	_~	_351ms	_356ms	_{p=0.807 n=6}
_{Req 4 - navto}	_{285ms (± 0.69%)}	_{288ms (± 1.75%)}	_~	_281ms	_294ms	_{p=0.465 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 8.89%)}	_{93ms (± 0.59%)}	_~	_92ms	_93ms	_{p=0.476 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,853ms (± 0.69%)}	_{2,826ms (± 0.44%)}	_{-27ms (- 0.96%)}	_2,813ms	_2,849ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{4,680ms (± 0.37%)}	_{4,675ms (± 0.36%)}	_~	_4,661ms	_4,703ms	_{p=0.572 n=6}
_{Req 3 - references}	_{365ms (± 0.48%)}	_{364ms (± 0.68%)}	_~	_361ms	_368ms	_{p=0.373 n=6}
_{Req 4 - navto}	_{285ms (± 0.52%)}	_{283ms (± 0.99%)}	_~	_278ms	_286ms	_{p=0.088 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 1.19%)}	_{75ms (± 0.54%)}	_~	_75ms	_76ms	_{p=0.787 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,266ms (± 0.73%)}	_{3,230ms (± 0.20%)}	_{-35ms (- 1.08%)}	_3,221ms	_3,238ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{1,751ms (± 1.13%)}	_{1,734ms (± 1.49%)}	_~	_1,693ms	_1,757ms	_{p=0.630 n=6}
_{Req 3 - references}	_{127ms (± 6.77%)}	_{126ms (± 6.65%)}	_~	_121ms	_143ms	_{p=0.655 n=6}
_{Req 4 - navto}	_{357ms (± 0.72%)}	_{353ms (± 0.34%)}	_{-4ms (- 1.17%)}	_351ms	_354ms	_{p=0.015 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{410ms (± 1.80%)}	_{409ms (± 1.48%)}	_~	_401ms	_418ms	_{p=1.000 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,822ms (± 0.59%)}	_{2,791ms (± 0.68%)}	_{-31ms (- 1.09%)}	_2,766ms	_2,816ms	_{p=0.025 n=6}
_{Req 2 - geterr}	_{6,211ms (± 0.45%)}	_{6,187ms (± 0.35%)}	_~	_6,155ms	_6,212ms	_{p=0.128 n=6}
_{Req 3 - references}	_{361ms (± 0.67%)}	_{362ms (± 0.87%)}	_~	_357ms	_366ms	_{p=0.685 n=6}
_{Req 4 - navto}	_{292ms (± 0.40%)}	_{291ms (± 0.19%)}	_{-1ms (- 0.46%)}	_290ms	_291ms	_{p=0.025 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 6.17%)}	_{104ms (± 0.50%)}	_~	_103ms	_104ms	_{p=0.928 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,990ms (± 0.45%)}	_{2,972ms (± 0.41%)}	_{-19ms (- 0.62%)}	_2,951ms	_2,986ms	_{p=0.031 n=6}
_{Req 2 - geterr}	_{4,556ms (± 0.61%)}	_{4,539ms (± 0.85%)}	_~	_4,487ms	_4,585ms	_{p=0.575 n=6}
_{Req 3 - references}	_{377ms (± 0.52%)}	_{377ms (± 0.36%)}	_~	_375ms	_379ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{300ms (± 0.49%)}	_{298ms (± 0.46%)}	_~	_296ms	_300ms	_{p=0.073 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 0.53%)}	_{77ms (± 2.54%)}	_~	_74ms	_80ms	_{p=0.245 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,491ms (± 0.72%)}	_{3,475ms (± 0.91%)}	_~	_3,425ms	_3,505ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{1,856ms (± 1.09%)}	_{1,853ms (± 1.31%)}	_~	_1,816ms	_1,886ms	_{p=0.936 n=6}
_{Req 3 - references}	_{152ms (± 6.75%)}	_{151ms (± 8.53%)}	_~	_132ms	_160ms	_{p=0.571 n=6}
_{Req 4 - navto}	_{397ms (± 0.37%)}	_{396ms (± 0.80%)}	_~	_392ms	_401ms	_{p=0.629 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{432ms (± 2.81%)}	_{436ms (± 1.26%)}	_~	_427ms	_443ms	_{p=0.297 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₃₄	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54634

_Metric	_main	₅₄₆₃₄	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{143.72ms (± 0.39%)}	_{142.81ms (± 0.21%)}	_{-0.90ms (- 0.63%)}	_141.86ms	_146.12ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{225.73ms (± 0.51%)}	_{223.39ms (± 0.44%)}	_{-2.34ms (- 1.04%)}	_220.88ms	_230.71ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.13ms (± 0.40%)}	_{227.39ms (± 0.24%)}	_{+1.26ms (+ 0.56%)}	_223.20ms	_232.36ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{207.95ms (± 0.41%)}	_{207.13ms (± 0.41%)}	_{-0.82ms (- 0.39%)}	_204.54ms	_215.71ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₆₃₄	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Merge branch 'main' into improve-error-for-unclosed-import-export

6eb6fa1

sandersn merged commited5008d intomicrosoft:main

Jun 29, 2023

Jack-Works deleted the improve-error-for-unclosed-import-export branch

June 30, 2023 08:48

microsoft locked asresolvedand limited conversation to collaborators

Oct 22, 2025

Labels

For Uncommitted Bug

PR for untriaged, rejected, closed or missing bug

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve error for unclosed imports and exports#54634

Improve error for unclosed imports and exports#54634

Uh oh!

Conversation

Jack-Works commentedJun 13, 2023•
edited
Loading

Uh oh!