- Notifications
You must be signed in to change notification settings - Fork13.1k
AddNoInfer intrinsic type#52968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
typescript-bot commentedFeb 25, 2023
The TypeScript team hasn't accepted the linked issue#14829. If you can get it accepted, this PR will have a better chance of being reviewed. |
Uh oh!
There was an error while loading.Please reload this page.
sandersn commentedMar 7, 2023
@Andarist did you learn anything interesting from the implementation? If so, can you add a report to the end of#14829? Unless@DanielRosenwasser@RyanCavanaugh or@ahejlsberg are interested in taking up this feature in a design meeting, it's likely that this PR will sit until it gets stale. |
Andarist commentedMar 13, 2023
@jakebailey would you mind creating a playground for this? :) |
jakebailey commentedMar 13, 2023
@typescript-bot pack this |
typescript-bot commentedMar 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Heya@jakebailey, I've started to run the tarball bundle task on this PR at86448ff. You can monitor the buildhere. |
typescript-bot commentedMar 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@jakebailey, I've packed this intoan installable tgz. You can install it for testing by referencing it in your and then running There is also a playgroundfor this build and annpm module you can use via |
unional commentedMay 1, 2023
Hi, I am reading#14829 and trying to add An I notice the type typeNoInfer<T>=T&{[KinkeyofT]:T[K]}typeRecursivePartial<T>={[PinkeyofT]?:T[P]extends(inferU)[]?RecursivePartial<U>[]:T[P]extendsRecord<any,any>?RecursivePartial<T[P]>:T[P]}functionfoo(v:{a:number,b:string}){}functionstub<T>(v:RecursivePartial<NoInfer<T>>):T{returnvasT}foo(stub({a:1})// error// Argument of type '{ a: number; }' is not assignable to parameter of type '{ a: number; b: string; }'.// Property 'b' is missing in type '{ a: number; }' but required in type '{ a: number; b: string; }'. It works with the following type: Just want to bring it up so that this test case is covered in your implementation. |
Andarist commentedJun 5, 2023
@RyanCavanaugh Since 5.2 development has started recently - perhaps we could get some current thoughts from the team about this feature? 😉 |
andrewbranch commentedDec 7, 2023
@typescript-bot pack this |
typescript-bot commentedDec 7, 2023
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document themon our wiki's API Breaking Changes page. Also, please make sure@DanielRosenwasser and@RyanCavanaugh are aware of the changes, just as a heads up. |
typescript-bot commentedDec 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Heya@andrewbranch, I've started to run the tarball bundle task on this PR at989fa50. You can monitor the buildhere. |
typescript-bot commentedDec 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@andrewbranch, I've packed this intoan installable tgz. You can install it for testing by referencing it in your and then running There is also a playgroundfor this build and annpm module you can use via |
Andarist commentedDec 15, 2023
superseded by#56794 |
closes#14829
There is still some work to be done here (type displays on hover, assignability bug, and maybe more) - but I'm pushing this out to receive an early feedback
cc@RyanCavanaugh