Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Supportexport type *#52217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
andrewbranch merged 8 commits intomicrosoft:mainfromandrewbranch:feature/37238
Jan 20, 2023
Merged

Conversation

andrewbranch
Copy link
Member

Fixes#37238

Adds support forexport type * from "mod" andexport type * as ns from "mod".

danielbayley and silverwind reacted with thumbs up emojiarthurfiorette, robpalme, Jack-Works, ohxxx, chenjiahan, sbbarragan, baptisteArno, natoehv, Benjamin-Dobell, PabloSzx, and 22 more reacted with hooray emojiwrslatz, bluebill1049, desko27, unicornware, BarrieLAJ, mubarakshow, shaquille-galanto, harvestnide, and silverwind reacted with heart emoji
@andrewbranch
Copy link
MemberAuthor

@typescript-bot perf test this
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commentedJan 12, 2023•
edited
Loading

Heya@andrewbranch, I've started to run the diff-based top-repos suite on this PR at08701ac. You can monitor the buildhere.

Update:The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commentedJan 12, 2023•
edited
Loading

Heya@andrewbranch, I've started to run the perf test suite on this PR at08701ac. You can monitor the buildhere.

Update:The results are in!

Copy link
Member

@jakebaileyjakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can't say I saw anything surprising in the checker (looked as I would guess), but I think the baselines say it all and look good to me; all of the edge cases I was coming up with appear to be tested.

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52217
Metricmain52217DeltaBestWorst
Angular - node (v18.10.0, x64)
Memory used361,163k (± 0.01%)361,169k (± 0.01%)+6k (+ 0.00%)361,117k361,213k
Parse Time3.94s (± 1.12%)3.93s (± 0.74%)-0.01s (- 0.34%)3.89s3.98s
Bind Time1.21s (± 0.56%)1.21s (± 0.33%)+0.00s (+ 0.00%)1.21s1.22s
Check Time8.78s (± 0.55%)8.77s (± 0.54%)-0.01s (- 0.09%)8.70s8.84s
Emit Time7.48s (± 0.41%)7.49s (± 0.56%)+0.00s (+ 0.04%)7.43s7.54s
Total Time21.42s (± 0.29%)21.39s (± 0.29%)-0.02s (- 0.10%)21.35s21.52s
Compiler-Unions - node (v18.10.0, x64)
Memory used193,036k (± 1.25%)192,040k (± 0.12%)-996k (- 0.52%)191,743k192,272k
Parse Time1.66s (± 0.76%)1.64s (± 1.21%)-0.02s (- 1.40%)1.61s1.66s
Bind Time0.80s (± 0.91%)0.80s (± 0.61%)+0.00s (+ 0.41%)0.80s0.81s
Check Time9.57s (± 0.73%)9.55s (± 0.40%)-0.02s (- 0.22%)9.51s9.62s
Emit Time2.89s (± 5.20%)2.88s (± 5.94%)-0.01s (- 0.26%)2.75s3.12s
Total Time14.93s (± 1.02%)14.88s (± 1.23%)-0.05s (- 0.35%)14.73s15.15s
Monaco - node (v18.10.0, x64)
Memory used345,704k (± 0.01%)345,740k (± 0.01%)+36k (+ 0.01%)345,680k345,794k
Parse Time2.91s (± 0.51%)2.90s (± 0.56%)-0.01s (- 0.46%)2.88s2.92s
Bind Time1.06s (± 1.13%)1.05s (± 0.54%)-0.00s (- 0.16%)1.05s1.06s
Check Time7.23s (± 0.33%)7.25s (± 0.45%)+0.02s (+ 0.23%)7.20s7.28s
Emit Time4.31s (± 0.51%)4.31s (± 1.31%)-0.00s (- 0.12%)4.24s4.40s
Total Time15.52s (± 0.13%)15.52s (± 0.64%)-0.00s (- 0.02%)15.41s15.65s
TFS - node (v18.10.0, x64)
Memory used300,525k (± 0.00%)300,513k (± 0.01%)-12k (- 0.00%)300,488k300,536k
Parse Time2.24s (± 1.30%)2.24s (± 1.49%)+0.00s (+ 0.10%)2.19s2.28s
Bind Time1.17s (± 0.58%)1.18s (± 0.52%)+0.01s (+ 0.81%)1.18s1.19s
Check Time6.83s (± 0.26%)6.84s (± 0.36%)+0.02s (+ 0.22%)6.80s6.87s
Emit Time3.94s (± 0.59%)3.94s (± 0.80%)-0.00s (- 0.07%)3.90s3.99s
Total Time14.18s (± 0.36%)14.21s (± 0.34%)+0.02s (+ 0.17%)14.12s14.25s
material-ui - node (v18.10.0, x64)
Memory used476,358k (± 0.01%)476,424k (± 0.02%)+66k (+ 0.01%)476,303k476,532k
Parse Time3.49s (± 0.31%)3.48s (± 1.73%)-0.01s (- 0.36%)3.39s3.54s
Bind Time0.98s (± 0.38%)1.00s (± 2.71%)+0.02s (+ 1.94%)0.97s1.05s
Check Time16.98s (± 0.71%)17.05s (± 0.47%)+0.06s (+ 0.38%)16.98s17.20s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time21.45s (± 0.54%)21.52s (± 0.40%)+0.07s (+ 0.34%)21.42s21.67s
xstate - node (v18.10.0, x64)
Memory used546,273k (± 0.01%)546,312k (± 0.03%)+39k (+ 0.01%)546,167k546,617k
Parse Time4.38s (± 1.14%)4.38s (± 0.86%)+0.00s (+ 0.06%)4.32s4.42s
Bind Time1.71s (± 0.88%)1.70s (± 0.49%)-0.01s (- 0.35%)1.69s1.71s
Check Time2.72s (± 0.36%)2.71s (± 0.51%)-0.01s (- 0.48%)2.68s2.72s
Emit Time0.08s (± 0.23%)0.08s (± 5.05%)+0.00s (+ 2.22%)0.08s0.09s
Total Time8.89s (± 0.68%)8.87s (± 0.57%)-0.01s (- 0.15%)8.78s8.93s
Angular - node (v16.17.1, x64)
Memory used360,570k (± 0.02%)360,574k (± 0.01%)+5k (+ 0.00%)360,505k360,642k
Parse Time4.14s (± 0.33%)4.13s (± 0.34%)-0.01s (- 0.33%)4.11s4.15s
Bind Time1.27s (± 0.36%)1.28s (± 0.29%)+0.00s (+ 0.20%)1.27s1.28s
Check Time9.42s (± 0.30%)9.43s (± 0.52%)+0.01s (+ 0.10%)9.37s9.50s
Emit Time7.95s (± 0.49%)7.98s (± 0.56%)+0.03s (+ 0.36%)7.92s8.05s
Total Time22.78s (± 0.30%)22.81s (± 0.41%)+0.03s (+ 0.12%)22.69s22.95s
Compiler-Unions - node (v16.17.1, x64)
Memory used195,601k (± 1.02%)194,939k (± 0.99%)-662k (- 0.34%)193,531k197,506k
Parse Time1.80s (± 0.85%)1.82s (± 1.15%)+0.03s (+ 1.49%)1.80s1.86s
Bind Time0.85s (± 0.49%)0.85s (± 0.38%)-0.00s (- 0.29%)0.84s0.85s
Check Time10.24s (± 0.68%)10.28s (± 0.69%)+0.04s (+ 0.38%)10.20s10.41s
Emit Time3.08s (± 4.23%)3.16s (± 5.33%)+0.08s (+ 2.59%)2.99s3.37s
Total Time15.97s (± 0.91%)16.11s (± 1.02%)+0.14s (+ 0.88%)15.92s16.32s
Monaco - node (v16.17.1, x64)
Memory used345,089k (± 0.01%)345,148k (± 0.00%)+60k (+ 0.02%)345,125k345,162k
Parse Time3.09s (± 0.69%)3.10s (± 0.42%)+0.01s (+ 0.32%)3.08s3.11s
Bind Time1.11s (± 1.35%)1.11s (± 1.28%)-0.00s (- 0.35%)1.09s1.13s
Check Time7.87s (± 0.45%)7.89s (± 0.29%)+0.02s (+ 0.31%)7.86s7.92s
Emit Time4.54s (± 0.71%)4.55s (± 0.79%)+0.02s (+ 0.36%)4.52s4.62s
Total Time16.60s (± 0.32%)16.64s (± 0.39%)+0.04s (+ 0.25%)16.59s16.76s
TFS - node (v16.17.1, x64)
Memory used299,892k (± 0.00%)299,890k (± 0.01%)-3k (- 0.00%)299,859k299,916k
Parse Time2.44s (± 1.56%)2.41s (± 0.25%)-0.03s (- 1.22%)2.41s2.42s
Bind Time1.27s (± 0.67%)1.26s (± 1.33%)-0.00s (- 0.32%)1.24s1.29s
Check Time7.41s (± 0.41%)7.42s (± 0.34%)+0.01s (+ 0.13%)7.38s7.44s
Emit Time4.25s (± 0.59%)4.23s (± 0.82%)-0.02s (- 0.48%)4.18s4.28s
Total Time15.36s (± 0.31%)15.31s (± 0.40%)-0.05s (- 0.31%)15.26s15.42s
material-ui - node (v16.17.1, x64)
Memory used475,630k (± 0.01%)475,696k (± 0.01%)+66k (+ 0.01%)475,663k475,739k
Parse Time3.66s (± 0.33%)3.65s (± 0.35%)-0.00s (- 0.03%)3.65s3.68s
Bind Time1.02s (± 0.85%)1.02s (± 0.48%)-0.00s (- 0.03%)1.02s1.03s
Check Time18.01s (± 1.47%)17.92s (± 0.33%)-0.10s (- 0.53%)17.82s18.00s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time22.69s (± 1.17%)22.59s (± 0.27%)-0.09s (- 0.41%)22.50s22.68s
xstate - node (v16.17.1, x64)
Memory used543,815k (± 0.01%)543,890k (± 0.02%)+75k (+ 0.01%)543,824k544,068k
Parse Time4.56s (± 0.40%)4.56s (± 0.30%)-0.00s (- 0.10%)4.53s4.57s
Bind Time1.79s (± 0.62%)1.78s (± 0.75%)-0.01s (- 0.65%)1.76s1.80s
Check Time2.93s (± 0.43%)2.93s (± 0.35%)+0.00s (+ 0.13%)2.92s2.95s
Emit Time0.08s (± 0.21%)0.08s (± 5.09%)+0.00s (+ 1.99%)0.08s0.09s
Total Time9.37s (± 0.32%)9.36s (± 0.28%)-0.00s (- 0.05%)9.33s9.41s
Angular - node (v14.15.1, x64)
Memory used354,205k (± 0.01%)354,209k (± 0.00%)+4k (+ 0.00%)354,187k354,224k
Parse Time4.17s (± 0.48%)4.16s (± 0.63%)-0.00s (- 0.04%)4.12s4.20s
Bind Time1.30s (± 0.56%)1.30s (± 1.28%)+0.01s (+ 0.39%)1.29s1.33s
Check Time9.75s (± 0.40%)9.77s (± 0.48%)+0.02s (+ 0.22%)9.72s9.85s
Emit Time8.30s (± 0.87%)8.27s (± 0.63%)-0.03s (- 0.38%)8.21s8.35s
Total Time23.52s (± 0.40%)23.51s (± 0.46%)-0.01s (- 0.05%)23.39s23.71s
Compiler-Unions - node (v14.15.1, x64)
Memory used188,945k (± 0.02%)188,962k (± 0.02%)+17k (+ 0.01%)188,922k189,023k
Parse Time1.83s (± 0.58%)1.83s (± 0.63%)-0.00s (- 0.08%)1.82s1.85s
Bind Time0.88s (± 1.15%)0.88s (± 0.48%)-0.00s (- 0.28%)0.87s0.88s
Check Time10.26s (± 0.53%)10.30s (± 0.67%)+0.05s (+ 0.47%)10.21s10.39s
Emit Time3.15s (± 0.61%)3.13s (± 0.88%)-0.02s (- 0.48%)3.10s3.17s
Total Time16.12s (± 0.49%)16.14s (± 0.65%)+0.02s (+ 0.15%)15.99s16.28s
Monaco - node (v14.15.1, x64)
Memory used339,885k (± 0.02%)339,855k (± 0.00%)-30k (- 0.01%)339,836k339,870k
Parse Time3.22s (± 1.23%)3.23s (± 0.34%)+0.00s (+ 0.10%)3.21s3.24s
Bind Time1.14s (± 0.98%)1.14s (± 0.57%)-0.00s (- 0.05%)1.12s1.14s
Check Time8.16s (± 0.53%)8.19s (± 0.33%)+0.03s (+ 0.36%)8.14s8.21s
Emit Time4.79s (± 0.57%)4.77s (± 0.78%)-0.02s (- 0.35%)4.73s4.82s
Total Time17.30s (± 0.45%)17.32s (± 0.31%)+0.01s (+ 0.07%)17.23s17.36s
TFS - node (v14.15.1, x64)
Memory used294,787k (± 0.00%)294,789k (± 0.00%)+2k (+ 0.00%)294,782k294,799k
Parse Time2.70s (± 0.93%)2.72s (± 1.30%)+0.02s (+ 0.60%)2.67s2.76s
Bind Time1.11s (± 0.44%)1.11s (± 0.81%)-0.00s (- 0.28%)1.09s1.11s
Check Time7.73s (± 0.45%)7.72s (± 0.45%)-0.01s (- 0.09%)7.68s7.77s
Emit Time4.58s (± 1.00%)4.58s (± 0.64%)-0.00s (- 0.02%)4.53s4.61s
Total Time16.12s (± 0.56%)16.12s (± 0.49%)+0.00s (+ 0.02%)16.02s16.26s
material-ui - node (v14.15.1, x64)
Memory used471,142k (± 0.00%)471,170k (± 0.00%)+28k (+ 0.01%)471,160k471,186k
Parse Time3.82s (± 0.42%)3.83s (± 0.98%)+0.01s (+ 0.35%)3.79s3.90s
Bind Time1.03s (± 0.59%)1.03s (± 0.91%)+0.00s (+ 0.35%)1.02s1.05s
Check Time18.91s (± 0.58%)18.91s (± 0.68%)-0.00s (- 0.02%)18.71s19.09s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time23.76s (± 0.45%)23.78s (± 0.66%)+0.02s (+ 0.09%)23.59s24.04s
xstate - node (v14.15.1, x64)
Memory used532,069k (± 0.01%)532,080k (± 0.01%)+12k (+ 0.00%)532,046k532,143k
Parse Time4.96s (± 0.94%)4.98s (± 0.80%)+0.02s (+ 0.40%)4.93s5.03s
Bind Time1.66s (± 0.78%)1.66s (± 0.66%)-0.00s (- 0.03%)1.65s1.68s
Check Time3.06s (± 0.40%)3.07s (± 0.39%)+0.01s (+ 0.44%)3.06s3.09s
Emit Time0.10s (± 0.18%)0.10s (± 4.03%)+0.00s (+ 1.84%)0.10s0.11s
Total Time9.79s (± 0.52%)9.82s (± 0.59%)+0.03s (+ 0.34%)9.75s9.92s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current522176
Baselinemain6

TSServer

Comparison Report - main..52217
Metricmain52217DeltaBestWorst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,434ms (± 7.59%)2,387ms (± 7.54%)-46ms (- 1.90%)2,150ms2,567ms
Req 2 - geterr5,175ms (± 6.86%)5,094ms (± 7.51%)-81ms (- 1.57%)4,733ms5,554ms
Req 3 - references360ms (± 7.22%)351ms (± 9.09%)-9ms (- 2.56%)318ms381ms
Req 4 - navto274ms (± 7.45%)269ms (± 7.97%)-4ms (- 1.51%)243ms296ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo134ms (±75.71%)67ms (± 7.91%)🟩-68ms (-50.45%)61ms74ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen2,712ms (± 1.31%)2,681ms (± 1.57%)-32ms (- 1.17%)2,640ms2,747ms
Req 2 - geterr3,977ms (± 0.54%)3,976ms (± 0.46%)-1ms (- 0.03%)3,955ms4,005ms
Req 3 - references374ms (± 0.77%)375ms (± 0.57%)+1ms (+ 0.35%)372ms377ms
Req 4 - navto290ms (± 0.39%)291ms (± 0.81%)+1ms (+ 0.35%)287ms294ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo82ms (± 2.54%)82ms (± 3.46%)-0ms (- 0.04%)77ms84ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen3,364ms (± 0.78%)3,364ms (± 0.68%)-0ms (- 0.00%)3,321ms3,384ms
Req 2 - geterr1,398ms (± 0.67%)1,398ms (± 1.13%)-0ms (- 0.02%)1,380ms1,422ms
Req 3 - references250ms (± 1.26%)251ms (± 0.98%)+1ms (+ 0.34%)247ms253ms
Req 4 - navto359ms (± 0.74%)359ms (± 0.74%)+0ms (+ 0.02%)356ms362ms
Req 5 - completionInfo count3,154 (± 0.00%)3,154 (± 0.00%)0 ( 0.00%)3,1543,154
Req 5 - completionInfo439ms (± 2.01%)442ms (± 1.89%)+3ms (+ 0.76%)427ms451ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,759ms (± 0.62%)2,689ms (± 5.18%)-70ms (- 2.53%)2,408ms2,768ms
Req 2 - geterr5,795ms (± 0.50%)5,673ms (± 5.54%)-122ms (- 2.10%)5,033ms5,838ms
Req 3 - references376ms (± 0.83%)366ms (± 5.37%)-10ms (- 2.58%)326ms376ms
Req 4 - navto275ms (± 0.89%)268ms (± 5.87%)-7ms (- 2.68%)236ms278ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo301ms (± 1.22%)292ms (± 4.63%)🟩-9ms (- 3.03%)265ms301ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen2,864ms (± 0.33%)2,866ms (± 0.78%)+2ms (+ 0.07%)2,840ms2,902ms
Req 2 - geterr4,321ms (± 0.31%)4,291ms (± 0.38%)-30ms (- 0.69%)4,269ms4,313ms
Req 3 - references386ms (± 1.69%)390ms (± 0.67%)+4ms (+ 1.03%)386ms394ms
Req 4 - navto300ms (± 0.33%)298ms (± 0.59%)-1ms (- 0.40%)296ms301ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo79ms (± 0.66%)80ms (± 1.95%)+0ms (+ 0.59%)78ms82ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen3,473ms (± 0.50%)3,474ms (± 0.50%)+0ms (+ 0.01%)3,452ms3,500ms
Req 2 - geterr1,639ms (± 5.04%)1,663ms (± 4.04%)+24ms (+ 1.47%)1,526ms1,699ms
Req 3 - references166ms (±53.85%)141ms (±49.66%)🟩-24ms (-14.69%)109ms284ms
Req 4 - navto339ms (± 2.57%)336ms (± 1.90%)-3ms (- 0.84%)327ms346ms
Req 5 - completionInfo count3,154 (± 0.00%)3,154 (± 0.00%)0 ( 0.00%)3,1543,154
Req 5 - completionInfo480ms (± 1.42%)484ms (± 1.10%)+4ms (+ 0.83%)479ms494ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen2,857ms (± 0.52%)2,853ms (± 0.74%)-4ms (- 0.13%)2,819ms2,880ms
Req 2 - geterr6,210ms (± 1.26%)6,179ms (± 0.69%)-31ms (- 0.51%)6,130ms6,245ms
Req 3 - references388ms (± 1.28%)389ms (± 0.39%)+1ms (+ 0.30%)387ms391ms
Req 4 - navto288ms (± 1.02%)285ms (± 0.37%)-3ms (- 1.07%)284ms287ms
Req 5 - completionInfo count1,356 (± 0.00%)1,356 (± 0.00%)0 ( 0.00%)1,3561,356
Req 5 - completionInfo88ms (± 7.23%)83ms (± 8.95%)🟩-5ms (- 5.56%)74ms92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,010ms (± 1.07%)3,031ms (± 1.23%)+21ms (+ 0.70%)2,981ms3,071ms
Req 2 - geterr4,585ms (± 0.34%)4,612ms (± 0.59%)+26ms (+ 0.57%)4,584ms4,653ms
Req 3 - references413ms (± 0.59%)412ms (± 1.15%)-2ms (- 0.37%)404ms416ms
Req 4 - navto307ms (± 0.57%)306ms (± 1.05%)-0ms (- 0.06%)301ms310ms
Req 5 - completionInfo count1,518 (± 0.00%)1,518 (± 0.00%)0 ( 0.00%)1,5181,518
Req 5 - completionInfo78ms (± 0.37%)78ms (± 1.46%)+0ms (+ 0.26%)78ms81ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen3,805ms (± 0.46%)3,812ms (± 0.56%)+7ms (+ 0.19%)3,789ms3,841ms
Req 2 - geterr1,476ms (± 1.10%)1,478ms (± 0.80%)+1ms (+ 0.10%)1,462ms1,490ms
Req 3 - references128ms (± 2.08%)132ms (± 1.47%)+3ms (+ 2.63%)130ms134ms
Req 4 - navto387ms (± 0.73%)390ms (± 1.06%)+3ms (+ 0.76%)387ms398ms
Req 5 - completionInfo count3,154 (± 0.00%)3,154 (± 0.00%)0 ( 0.00%)3,1543,154
Req 5 - completionInfo497ms (± 1.35%)497ms (± 1.49%)-0ms (- 0.02%)484ms505ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
BenchmarkNameIterations
Current522176
Baselinemain6

Startup

Comparison Report - main..52217
Metricmain52217DeltaBestWorst
tsc-startup - node (v16.17.1, x64)
Execution time139.64ms (± 0.18%)139.63ms (± 0.22%)-0.01ms (- 0.00%)138.67ms143.08ms
tsserver-startup - node (v16.17.1, x64)
Execution time231.84ms (± 0.22%)232.12ms (± 0.18%)+0.28ms (+ 0.12%)230.78ms237.57ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time234.25ms (± 0.19%)234.27ms (± 0.20%)+0.02ms (+ 0.01%)232.83ms240.29ms
typescript-startup - node (v16.17.1, x64)
Execution time216.40ms (± 0.26%)215.96ms (± 0.19%)-0.44ms (- 0.20%)214.37ms220.07ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
BenchmarkNameIterations
Current522176
Baselinemain6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@andrewbranch Here are the results of running the top-repos suite comparingmain andrefs/pull/52217/merge:

Everything looks good!

@andrewbranch
Copy link
MemberAuthor

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commentedJan 13, 2023•
edited
Loading

Heya@andrewbranch, I've started to run the tarball bundle task on this PR at3b6a185. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

typescript-bot commentedJan 13, 2023•
edited
Loading

Hey@andrewbranch, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142506/artifacts?artifactName=tgz&fileId=1BF16492D581EC4BF36216D73ACECB3D69DB03FD7F42EEBC4330F0C00F7BE01702&fileName=/typescript-5.0.0-insiders.20230113.tgz"    }}

and then runningnpm install.

There is also a playgroundfor this build and annpm module you can use via"typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52217-7".;

Copy link
Member

@weswighamweswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unless I'm mistaken, it looks like this needs some (error-free).d.ts emit tests to ensure we preserve theexport typey-ness of these declarations when doing declaration emit (and probably some emitter/declaration emitter code to match). A test with anexport type declaration in a js file with js declaration emit on would also be relevant, despite (I assume) being an error.

andrewbranch reacted with thumbs up emoji
@andrewbranch
Copy link
MemberAuthor

Good call. I suspect it already works since this form is not actually new syntax, just newly not a grammar error, but it definitely needs to be tested.

@andrewbranch
Copy link
MemberAuthor

As I predicted, declaration emit does work. It did drop thetype from declaration emit when the source file was JS, but that seems ok?

Copy link
Member

@weswighamweswigham left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It'd be nice if the js declaration emit preserved thetype modifier, just in case someone uses the (admittedly internal) node builder APIs on typescript code (which is why it knows how to emit interfaces and such), but since it's an error it's non-critical.

@andrewbranch
Copy link
MemberAuthor

On second thought, having consistent declaration emit is also required to make errors consistent between referenced projects in the editor and on the CLI, so I went ahead and fixed it.

@andrewbranchandrewbranch merged commitf576398 intomicrosoft:mainJan 20, 2023
@andrewbranchandrewbranch deleted the feature/37238 branchJanuary 20, 2023 22:24
@ConaclosConaclos mentioned this pull requestFeb 22, 2023
2 tasks
@V1REV1RE mentioned this pull requestMar 18, 2023
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sandersnsandersnsandersn approved these changes

@weswighamweswighamweswigham approved these changes

@jakebaileyjakebaileyjakebailey approved these changes

Assignees

@andrewbranchandrewbranch

Labels
Author: TeamFor Milestone BugPRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] allowexport type * from
5 participants
@andrewbranch@typescript-bot@sandersn@weswigham@jakebailey
[8]ページ先頭
©2009-2025 Movatter.jp