NotificationsYou must be signed in to change notification settings
Fork12.9k
Star105k

Improve comparison operators type checking to disallow unions containing numbers as an operand#52048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

RyanCavanaugh merged 1 commit intomicrosoft:mainfromAndarist:comparison-operator-improvements

Jan 20, 2023

Merged

Improve comparison operators type checking to disallow unions containing numbers as an operand#52048

RyanCavanaugh merged 1 commit intomicrosoft:mainfromAndarist:comparison-operator-improvements

Jan 20, 2023

Conversation

Copy link

Contributor

Andarist commentedDec 29, 2022

fixes#52036

at this moment this is just a spike to check if this is even a desired change

Improve comparison operators type checking to disallow unions contain…

7996bcb

…ing numbers as an operand

typescript-bot added the For Uncommitted BugPR for untriaged, rejected, closed or missing bug label

Dec 29, 2022

Andarist commented

Dec 29, 2022

View reviewed changes

src/compiler/checker.ts

Comment on lines +35646 to +35647

		return leftAssignableToNumber && rightAssignableToNumber \|\|
		!leftAssignableToNumber && !rightAssignableToNumber && areTypesComparable(left, right);

Copy link

ContributorAuthor

AndaristDec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

essentially, when one of the operands is assignable to a number (or big int) then we require the other one to be assignable to it too.areTypesComparable kicks in only when both sides are not assignable tonumberOrBigIntType

Andarist commented

Dec 29, 2022

View reviewed changes

tests/baselines/reference/comparisonOperatorWithNoRelationshipTypeParameter.errors.txt

		@@ -6,9 +6,41 @@ tests/cases/conformance/expressions/binaryOperators/comparisonOperator/compariso
		tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithNoRelationshipTypeParameter.ts(17,14): error TS2367: This comparison appears to be unintentional because the types 'T' and 'U' have no overlap.
		tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithNoRelationshipTypeParameter.ts(18,14): error TS2367: This comparison appears to be unintentional because the types 'T' and 'U' have no overlap.
		tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithNoRelationshipTypeParameter.ts(19,14): error TS2367: This comparison appears to be unintentional because the types 'T' and 'U' have no overlap.
		tests/cases/conformance/expressions/binaryOperators/comparisonOperator/comparisonOperatorWithNoRelationshipTypeParameter.ts(23,16): error TS2365: Operator '<' cannot be applied to types 'T' and 'number'.

Copy link

ContributorAuthor

AndaristDec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To bring back the old behavior we should probably also allow unconstrained generics - but I wasn't sure what's the best check for them. Should I just checksomeType with a predicate testing if the type is aTypeParameter without a constraint?

Andarist commented

Dec 29, 2022

View reviewed changes

tests/baselines/reference/controlFlowWhileStatement.errors.txt

		@@ -0,0 +1,113 @@
		tests/cases/conformance/controlFlow/controlFlowWhileStatement.ts(81,12): error TS2365: Operator '>' cannot be applied to types 'string \| number' and 'number'.

Copy link

ContributorAuthor

AndaristDec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps this indicated that the improvement requires some more work - or maybe that it's not a good improvement after all, as maybe "swallowing" non-numbers in unions is desired? Kinda easy to miss a mistake because of this behavior but some existing code can depend on it

Andarist commented

Dec 29, 2022

View reviewed changes

tests/baselines/reference/controlFlowWhileStatement.errors.txt

Comment on lines +84 to +87

		x = "";
		while (x > 1) {
		~~~~~
		!!! error TS2365: Operator '>' cannot be applied to types 'string \| number' and 'number'.

Copy link

ContributorAuthor

AndaristDec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I feel like perhaps the error here is actually desirable - since the initial CFA type isstring and for such thiswhile loop is ignored at runtime (and could be ignored by the CFA analysis). We never enter the body of this loop

Andarist mentioned this pull request

Dec 29, 2022

typescript passesnumber | Promise<number> as if it werenumber (or something like that)#52036

Closed

Copy link

Member

RyanCavanaugh commentedJan 4, 2023

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

Copy link

Collaborator

typescript-bot commentedJan 4, 2023•
edited
Loading

Heya@RyanCavanaugh, I've started to run the perf test suite on this PR at7996bcb. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedJan 4, 2023•
edited
Loading

Heya@RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at7996bcb. You can monitor the buildhere.

Update:The results are in!

Copy link

Collaborator

typescript-bot commentedJan 4, 2023•
edited
Loading

Heya@RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at7996bcb. You can monitor the buildhere.

Copy link

Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparingmain andrefs/pull/52048/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.json

[NEW]error TS2365: Operator '<' cannot be applied to types 'string | number | []' and 'number'.
- lib/util/semver.js#L293
[NEW]error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number | []'.
- lib/util/semver.js#L354
[NEW]error TS2365: Operator '<=' cannot be applied to types 'number' and 'string | number | []'.

tsconfig.types.json

[NEW]error TS2365: Operator '<' cannot be applied to types 'string | number | []' and 'number'.
- lib/util/semver.js#L293
[NEW]error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number | []'.
- lib/util/semver.js#L354
[NEW]error TS2365: Operator '<=' cannot be applied to types 'number' and 'string | number | []'.

Copy link

Collaborator

typescript-bot commentedJan 4, 2023

Heya@RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diffhere.

Copy link

Member

RyanCavanaugh commentedJan 4, 2023

Breaks from an internal codebase (an ancient snapshot FWIW):

                animateOverlayPanel: (deltaY?: Number) => {                    if (typeof(deltaY) !== 'undefined' && deltaY < 0 && !!this.state.currentItem.url) {                                                          ~~~~~~~~~~!!! error TS2365: Operator '<' cannot be applied to types 'Number' and 'number'.

        if (item && item.redacted && item.redacted > 0) {                                            ~~~~~~~~~~~~~~~~~~~~~~~~!!! error TS2365: Operator '>' cannot be applied to types 'string | number' and 'number'.

                } else if (latin1ToGsm[codePoint] < -1) {                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~!!! error TS2365: Operator '<' cannot be applied to types 'string | number' and 'number'.                    scalarGsmEncodedLength.push(2);                } else {

                    urlPreviewInfo.content_type === FileTypeHelper.imageContentTypes.gif                        && urlPreviewInfo.size                        && urlPreviewInfo.size > this._maxGifFileSizeForIOs;                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~!!! error TS2365: Operator '>' cannot be applied to types 'string | number' and 'number'.

Copy link

ContributorAuthor

Andarist commentedJan 4, 2023

Most of the breaks here look very desirable to me. The Number vs number one should probably be corrected though.

Copy link

Collaborator

typescript-bot commentedJan 5, 2023

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52048

_Metric	_main	₅₂₀₄₈	_Delta	_Best	_Worst
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{372,498k (± 0.01%)}	_{372,489k (± 0.01%)}	_{-9k (- 0.00%)}	_372,440k	_372,562k
_{Parse Time}	_{3.96s (± 0.81%)}	_{3.98s (± 1.24%)}	_{+0.01s (+ 0.34%)}	_3.90s	_4.03s
_{Bind Time}	_{1.20s (± 0.73%)}	_{1.19s (± 0.74%)}	_{-0.01s (- 0.42%)}	_1.18s	_1.21s
_{Check Time}	_{8.62s (± 0.75%)}	_{8.61s (± 0.50%)}	_{-0.01s (- 0.08%)}	_8.58s	_8.70s
_{Emit Time}	_{7.55s (± 0.92%)}	_{7.55s (± 0.75%)}	_{+0.00s (+ 0.04%)}	_7.48s	_7.62s
_{Total Time}	_{21.33s (± 0.59%)}	_{21.33s (± 0.54%)}	_{+0.00s (+ 0.02%)}	_21.21s	_21.48s
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{199,110k (± 1.16%)}	_{200,978k (± 1.54%)}	_{+1,869k (+ 0.94%)}	_198,088k	_203,883k
_{Parse Time}	_{1.65s (± 1.75%)}	_{1.64s (± 1.55%)}	_{-0.01s (- 0.40%)}	_1.59s	_1.67s
_{Bind Time}	_{0.79s (± 0.72%)}	_{0.79s (± 0.66%)}	_{-0.00s (- 0.31%)}	_0.78s	_0.80s
_{Check Time}	_{9.45s (± 0.66%)}	_{9.37s (± 0.75%)}	_{-0.07s (- 0.78%)}	_9.26s	_9.44s
_{Emit Time}	_{2.75s (± 1.04%)}	_{2.75s (± 0.72%)}	_{-0.00s (- 0.10%)}	_2.72s	_2.77s
_{Total Time}	_{14.64s (± 0.64%)}	_{14.55s (± 0.55%)}	_{-0.09s (- 0.59%)}	_14.43s	_14.64s
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{353,963k (± 0.01%)}	_{353,904k (± 0.01%)}	_{-59k (- 0.02%)}	_353,867k	_353,946k
_{Parse Time}	_{2.96s (± 1.34%)}	_{2.94s (± 0.80%)}	_{-0.01s (- 0.47%)}	_2.92s	_2.98s
_{Bind Time}	_{1.04s (± 1.06%)}	_{1.04s (± 1.47%)}	_{-0.00s (- 0.13%)}	_1.02s	_1.06s
_{Check Time}	_{7.24s (± 0.66%)}	_{7.20s (± 0.34%)}	_{-0.04s (- 0.61%)}	_7.16s	_7.23s
_{Emit Time}	_{4.31s (± 0.98%)}	_{4.25s (± 1.10%)}	_{-0.06s (- 1.44%)}	_4.20s	_4.31s
_{Total Time}	_{15.55s (± 0.70%)}	_{15.43s (± 0.44%)}	_{-0.12s (- 0.75%)}	_15.37s	_15.55s
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{309,869k (± 0.01%)}	_{309,856k (± 0.00%)}	_{-14k (- 0.00%)}	_309,838k	_309,873k
_{Parse Time}	_{2.25s (± 0.76%)}	_{2.26s (± 1.19%)}	_{+0.00s (+ 0.22%)}	_2.23s	_2.31s
_{Bind Time}	_{1.17s (± 0.88%)}	_{1.15s (± 0.32%)}	_{-0.01s (- 1.00%)}	_1.15s	_1.16s
_{Check Time}	_{6.81s (± 0.75%)}	_{6.81s (± 0.67%)}	_{-0.01s (- 0.10%)}	_6.75s	_6.87s
_{Emit Time}	_{3.94s (± 0.88%)}	_{3.90s (± 0.50%)}	_{-0.03s (- 0.89%)}	_3.87s	_3.92s
_{Total Time}	_{14.17s (± 0.57%)}	_{14.12s (± 0.55%)}	_{-0.05s (- 0.33%)}	_14.02s	_14.23s
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{485,044k (± 0.01%)}	_{485,119k (± 0.01%)}	_{+74k (+ 0.02%)}	_485,067k	_485,149k
_{Parse Time}	_{3.52s (± 0.31%)}	_{3.52s (± 0.46%)}	_{-0.00s (- 0.14%)}	_3.50s	_3.55s
_{Bind Time}	_{0.96s (± 0.55%)}	_{0.96s (± 0.88%)}	_{+0.00s (+ 0.52%)}	_0.95s	_0.98s
_{Check Time}	_{16.96s (± 0.74%)}	_{16.90s (± 0.99%)}	_{-0.06s (- 0.33%)}	_16.76s	_17.23s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.44s (± 0.62%)}	_{21.38s (± 0.80%)}	_{-0.06s (- 0.27%)}	_21.21s	_21.71s
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{569,822k (± 0.02%)}	_{569,793k (± 0.03%)}	_{-29k (- 0.01%)}	_569,602k	_569,959k
_{Parse Time}	_{4.41s (± 0.87%)}	_{4.42s (± 0.77%)}	_{+0.00s (+ 0.06%)}	_4.38s	_4.46s
_{Bind Time}	_{1.70s (± 0.74%)}	_{1.69s (± 0.75%)}	_{-0.01s (- 0.30%)}	_1.68s	_1.71s
_{Check Time}	_{2.59s (± 0.75%)}	_{2.60s (± 0.59%)}	_{+0.01s (+ 0.25%)}	_2.57s	_2.62s
_{Emit Time}	_{0.08s (± 0.11%)}	_{0.08s (± 0.11%)}	_{-0.00s (- 0.20%)}	_0.08s	_0.08s
_{Total Time}	_{8.79s (± 0.47%)}	_{8.79s (± 0.45%)}	_{+0.01s (+ 0.07%)}	_8.75s	_8.85s
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{371,802k (± 0.01%)}	_{371,861k (± 0.01%)}	_{+59k (+ 0.02%)}	_371,830k	_371,909k
_{Parse Time}	_{4.14s (± 0.68%)}	_{4.14s (± 0.24%)}	_{+0.00s (+ 0.08%)}	_4.13s	_4.16s
_{Bind Time}	_{1.27s (± 0.54%)}	_{1.27s (± 0.79%)}	_{-0.01s (- 0.44%)}	_1.25s	_1.28s
_{Check Time}	_{9.28s (± 0.61%)}	_{9.30s (± 0.39%)}	_{+0.02s (+ 0.21%)}	_9.27s	_9.37s
_{Emit Time}	_{7.96s (± 0.17%)}	_{7.97s (± 0.74%)}	_{+0.01s (+ 0.15%)}	_7.90s	_8.05s
_{Total Time}	_{22.66s (± 0.34%)}	_{22.68s (± 0.46%)}	_{+0.03s (+ 0.12%)}	_22.54s	_22.80s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{200,839k (± 0.92%)}	_{199,826k (± 0.08%)}	_{-1,013k (- 0.50%)}	_199,500k	_199,933k
_{Parse Time}	_{1.82s (± 0.51%)}	_{1.82s (± 0.41%)}	_{-0.00s (- 0.23%)}	_1.81s	_1.83s
_{Bind Time}	_{0.84s (± 1.00%)}	_{0.84s (± 0.79%)}	_{-0.01s (- 0.82%)}	_0.83s	_0.85s
_{Check Time}	_{10.11s (± 0.83%)}	_{10.10s (± 1.29%)}	_{-0.01s (- 0.12%)}	_9.94s	_10.28s
_{Emit Time}	_{3.14s (± 6.00%)}	_{3.04s (± 4.32%)}	_{🟩-0.10s (- 3.09%)}	_2.96s	_3.29s
_{Total Time}	_{15.92s (± 1.43%)}	_{15.80s (± 1.46%)}	_{-0.12s (- 0.73%)}	_15.56s	_16.24s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{353,248k (± 0.01%)}	_{353,231k (± 0.01%)}	_{-18k (- 0.00%)}	_353,199k	_353,267k
_{Parse Time}	_{3.19s (± 1.20%)}	_{3.17s (± 0.53%)}	_{-0.02s (- 0.55%)}	_3.15s	_3.19s
_{Bind Time}	_{1.11s (± 1.22%)}	_{1.11s (± 1.33%)}	_{+0.00s (+ 0.02%)}	_1.09s	_1.14s
_{Check Time}	_{7.85s (± 0.36%)}	_{7.85s (± 0.38%)}	_{+0.00s (+ 0.06%)}	_7.82s	_7.90s
_{Emit Time}	_{4.48s (± 0.48%)}	_{4.48s (± 0.40%)}	_{-0.00s (- 0.10%)}	_4.45s	_4.50s
_{Total Time}	_{16.63s (± 0.36%)}	_{16.62s (± 0.37%)}	_{-0.02s (- 0.10%)}	_16.54s	_16.72s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{309,212k (± 0.01%)}	_{309,216k (± 0.00%)}	_{+4k (+ 0.00%)}	_309,210k	_309,225k
_{Parse Time}	_{2.62s (± 1.14%)}	_{2.61s (± 0.95%)}	_{-0.01s (- 0.30%)}	_2.58s	_2.65s
_{Bind Time}	_{1.07s (± 1.43%)}	_{1.04s (± 0.72%)}	_{-0.03s (- 2.53%)}	_1.04s	_1.06s
_{Check Time}	_{7.42s (± 0.49%)}	_{7.38s (± 0.29%)}	_{-0.04s (- 0.52%)}	_7.36s	_7.41s
_{Emit Time}	_{4.24s (± 0.58%)}	_{4.20s (± 0.79%)}	_{-0.04s (- 0.87%)}	_4.15s	_4.24s
_{Total Time}	_{15.34s (± 0.39%)}	_{15.23s (± 0.35%)}	_{-0.11s (- 0.74%)}	_15.16s	_15.30s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{484,374k (± 0.00%)}	_{484,398k (± 0.01%)}	_{+24k (+ 0.00%)}	_484,358k	_484,429k
_{Parse Time}	_{3.68s (± 0.39%)}	_{3.67s (± 0.29%)}	_{-0.01s (- 0.20%)}	_3.66s	_3.68s
_{Bind Time}	_{1.02s (± 0.71%)}	_{1.01s (± 0.64%)}	_{-0.00s (- 0.26%)}	_1.00s	_1.02s
_{Check Time}	_{17.86s (± 0.59%)}	_{17.89s (± 0.51%)}	_{+0.03s (+ 0.15%)}	_17.79s	_18.00s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.56s (± 0.45%)}	_{22.57s (± 0.45%)}	_{+0.01s (+ 0.04%)}	_22.46s	_22.70s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{567,338k (± 0.02%)}	_{567,334k (± 0.01%)}	_{-4k (- 0.00%)}	_567,274k	_567,429k
_{Parse Time}	_{4.77s (± 0.73%)}	_{4.75s (± 0.43%)}	_{-0.01s (- 0.31%)}	_4.74s	_4.79s
_{Bind Time}	_{1.66s (± 0.66%)}	_{1.65s (± 0.74%)}	_{-0.01s (- 0.64%)}	_1.62s	_1.66s
_{Check Time}	_{2.83s (± 0.57%)}	_{2.83s (± 0.43%)}	_{-0.00s (- 0.03%)}	_2.81s	_2.84s
_{Emit Time}	_{0.09s (± 4.66%)}	_{0.09s (± 4.56%)}	_{-0.00s (- 0.04%)}	_0.08s	_0.09s
_{Total Time}	_{9.34s (± 0.37%)}	_{9.32s (± 0.37%)}	_{-0.02s (- 0.25%)}	_9.27s	_9.37s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{365,502k (± 0.00%)}	_{365,498k (± 0.00%)}	_{-4k (- 0.00%)}	_365,479k	_365,521k
_{Parse Time}	_{4.16s (± 0.79%)}	_{4.15s (± 0.40%)}	_{-0.01s (- 0.18%)}	_4.12s	_4.17s
_{Bind Time}	_{1.30s (± 0.49%)}	_{1.30s (± 0.30%)}	_{+0.00s (+ 0.23%)}	_1.30s	_1.31s
_{Check Time}	_{9.66s (± 0.34%)}	_{9.70s (± 0.46%)}	_{+0.04s (+ 0.41%)}	_9.64s	_9.78s
_{Emit Time}	_{8.21s (± 0.83%)}	_{8.19s (± 0.60%)}	_{-0.02s (- 0.25%)}	_8.10s	_8.25s
_{Total Time}	_{23.32s (± 0.33%)}	_{23.33s (± 0.25%)}	_{+0.01s (+ 0.06%)}	_23.24s	_23.40s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{194,956k (± 0.01%)}	_{195,016k (± 0.03%)}	_{+60k (+ 0.03%)}	_194,954k	_195,085k
_{Parse Time}	_{1.86s (± 0.21%)}	_{1.84s (± 0.62%)}	_{-0.01s (- 0.75%)}	_1.83s	_1.86s
_{Bind Time}	_{0.87s (± 0.56%)}	_{0.87s (± 0.89%)}	_{-0.00s (- 0.41%)}	_0.87s	_0.89s
_{Check Time}	_{10.14s (± 0.48%)}	_{10.09s (± 0.54%)}	_{-0.05s (- 0.46%)}	_10.01s	_10.14s
_{Emit Time}	_{3.12s (± 0.96%)}	_{3.13s (± 0.40%)}	_{+0.00s (+ 0.13%)}	_3.11s	_3.14s
_{Total Time}	_{15.99s (± 0.38%)}	_{15.94s (± 0.41%)}	_{-0.05s (- 0.32%)}	_15.85s	_16.00s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{348,122k (± 0.01%)}	_{348,076k (± 0.01%)}	_{-46k (- 0.01%)}	_348,050k	_348,116k
_{Parse Time}	_{3.26s (± 1.01%)}	_{3.24s (± 0.89%)}	_{-0.02s (- 0.65%)}	_3.21s	_3.28s
_{Bind Time}	_{1.13s (± 0.57%)}	_{1.12s (± 0.94%)}	_{-0.01s (- 0.62%)}	_1.11s	_1.14s
_{Check Time}	_{8.13s (± 0.46%)}	_{8.15s (± 0.39%)}	_{+0.02s (+ 0.29%)}	_8.12s	_8.21s
_{Emit Time}	_{4.70s (± 0.46%)}	_{4.71s (± 0.83%)}	_{+0.02s (+ 0.32%)}	_4.67s	_4.78s
_{Total Time}	_{17.21s (± 0.41%)}	_{17.22s (± 0.38%)}	_{+0.01s (+ 0.07%)}	_17.13s	_17.32s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{304,140k (± 0.00%)}	_{304,140k (± 0.00%)}	_{0k ( 0.00%)}	_304,121k	_304,152k
_{Parse Time}	_{2.73s (± 0.83%)}	_{2.71s (± 0.93%)}	_{-0.03s (- 0.95%)}	_2.67s	_2.75s
_{Bind Time}	_{1.09s (± 0.60%)}	_{1.07s (± 0.48%)}	_{-0.01s (- 1.23%)}	_1.06s	_1.08s
_{Check Time}	_{7.70s (± 0.38%)}	_{7.75s (± 0.35%)}	_{+0.05s (+ 0.65%)}	_7.73s	_7.80s
_{Emit Time}	_{4.60s (± 1.00%)}	_{4.56s (± 1.36%)}	_{-0.05s (- 1.00%)}	_4.50s	_4.66s
_{Total Time}	_{16.13s (± 0.45%)}	_{16.09s (± 0.63%)}	_{-0.04s (- 0.23%)}	_16.01s	_16.28s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{479,809k (± 0.00%)}	_{479,786k (± 0.00%)}	_{-23k (- 0.00%)}	_479,771k	_479,806k
_{Parse Time}	_{3.91s (± 0.44%)}	_{3.88s (± 0.52%)}	_{-0.02s (- 0.59%)}	_3.86s	_3.91s
_{Bind Time}	_{1.05s (± 0.68%)}	_{1.05s (± 0.61%)}	_{-0.00s (- 0.32%)}	_1.04s	_1.06s
_{Check Time}	_{18.99s (± 0.56%)}	_{18.93s (± 0.54%)}	_{-0.05s (- 0.29%)}	_18.78s	_19.08s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.95s (± 0.45%)}	_{23.87s (± 0.40%)}	_{-0.08s (- 0.34%)}	_23.71s	_23.99s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{555,710k (± 0.01%)}	_{555,695k (± 0.01%)}	_{-15k (- 0.00%)}	_555,652k	_555,731k
_{Parse Time}	_{5.12s (± 0.70%)}	_{5.11s (± 0.98%)}	_{-0.02s (- 0.30%)}	_5.06s	_5.19s
_{Bind Time}	_{1.60s (± 1.36%)}	_{1.57s (± 0.54%)}	_{-0.02s (- 1.45%)}	_1.56s	_1.59s
_{Check Time}	_{2.99s (± 0.44%)}	_{2.97s (± 0.56%)}	_{-0.02s (- 0.71%)}	_2.95s	_2.99s
_{Emit Time}	_{0.10s (± 0.16%)}	_{0.10s (± 0.23%)}	_{-0.00s (- 0.10%)}	_0.10s	_0.10s
_{Total Time}	_{9.81s (± 0.64%)}	_{9.76s (± 0.56%)}	_{-0.06s (- 0.57%)}	_9.70s	_9.84s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₀₄₈	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52048

_Metric	_main	₅₂₀₄₈	_Delta	_Best	_Worst
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,537ms (± 1.73%)}	_{2,554ms (± 1.30%)}	_{+16ms (+ 0.64%)}	_2,508ms	_2,603ms
_{Req 2 - geterr}	_{5,646ms (± 1.20%)}	_{5,650ms (± 1.02%)}	_{+4ms (+ 0.06%)}	_5,578ms	_5,710ms
_{Req 3 - references}	_{362ms (± 2.69%)}	_{362ms (± 2.13%)}	_{+0ms (+ 0.04%)}	_353ms	_376ms
_{Req 4 - navto}	_{291ms (± 1.50%)}	_{292ms (± 2.23%)}	_{+2ms (+ 0.62%)}	_284ms	_302ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{84ms (± 5.43%)}	_{80ms (± 8.09%)}	_{🟩-4ms (- 5.14%)}	_71ms	_87ms
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,696ms (± 1.05%)}	_{2,713ms (± 1.60%)}	_{+17ms (+ 0.62%)}	_2,675ms	_2,774ms
_{Req 2 - geterr}	_{4,131ms (± 0.18%)}	_{4,137ms (± 0.98%)}	_{+6ms (+ 0.14%)}	_4,096ms	_4,191ms
_{Req 3 - references}	_{357ms (± 0.76%)}	_{357ms (± 0.75%)}	_{-1ms (- 0.21%)}	_352ms	_360ms
_{Req 4 - navto}	_{290ms (± 0.74%)}	_{291ms (± 1.10%)}	_{+1ms (+ 0.21%)}	_289ms	_297ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{65ms (± 1.36%)}	_{65ms (± 1.22%)}	_{+0ms (+ 0.43%)}	_64ms	_66ms
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,625ms (± 0.71%)}	_{3,598ms (± 0.60%)}	_{-26ms (- 0.73%)}	_3,562ms	_3,620ms
_{Req 2 - geterr}	_{1,331ms (± 1.32%)}	_{1,336ms (± 1.20%)}	_{+5ms (+ 0.34%)}	_1,318ms	_1,356ms
_{Req 3 - references}	_{104ms (± 3.33%)}	_{105ms (± 2.37%)}	_{+1ms (+ 1.17%)}	_103ms	_110ms
_{Req 4 - navto}	_{360ms (± 1.93%)}	_{357ms (± 1.92%)}	_{-3ms (- 0.88%)}	_349ms	_368ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{435ms (± 1.46%)}	_{429ms (± 1.07%)}	_{-5ms (- 1.24%)}	_423ms	_436ms
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,792ms (± 0.59%)}	_{2,542ms (±21.65%)}	_{🟩-249ms (- 8.93%)}	_1,419ms	_2,797ms
_{Req 2 - geterr}	_{6,035ms (± 0.81%)}	_{5,508ms (±21.97%)}	_{🟩-526ms (- 8.72%)}	_3,037ms	_6,070ms
_{Req 3 - references}	_{363ms (± 1.11%)}	_{335ms (±22.14%)}	_{🟩-28ms (- 7.65%)}	_184ms	_370ms
_{Req 4 - navto}	_{280ms (± 0.35%)}	_{256ms (±21.84%)}	_{🟩-24ms (- 8.69%)}	_142ms	_281ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{85ms (± 9.64%)}	_{80ms (±21.27%)}	_{🟩-5ms (- 6.17%)}	_48ms	_95ms
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,910ms (± 0.73%)}	_{2,899ms (± 0.47%)}	_{-11ms (- 0.37%)}	_2,876ms	_2,915ms
_{Req 2 - geterr}	_{4,494ms (± 0.27%)}	_{4,493ms (± 0.38%)}	_{-0ms (- 0.01%)}	_4,474ms	_4,520ms
_{Req 3 - references}	_{383ms (± 1.06%)}	_{383ms (± 0.32%)}	_{-0ms (- 0.04%)}	_381ms	_384ms
_{Req 4 - navto}	_{296ms (± 1.09%)}	_{297ms (± 1.38%)}	_{+1ms (+ 0.45%)}	_292ms	_304ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{74ms (± 3.97%)}	_{72ms (± 3.01%)}	_{-2ms (- 2.74%)}	_70ms	_76ms
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,762ms (± 0.30%)}	_{3,755ms (± 0.28%)}	_{-7ms (- 0.19%)}	_3,744ms	_3,773ms
_{Req 2 - geterr}	_{1,444ms (± 1.11%)}	_{1,456ms (± 0.78%)}	_{+12ms (+ 0.82%)}	_1,444ms	_1,472ms
_{Req 3 - references}	_{108ms (± 1.00%)}	_{109ms (± 3.15%)}	_{+1ms (+ 0.54%)}	_107ms	_116ms
_{Req 4 - navto}	_{352ms (± 0.70%)}	_{346ms (± 1.14%)}	_{-6ms (- 1.63%)}	_341ms	_351ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{455ms (± 1.93%)}	_{454ms (± 0.51%)}	_{-2ms (- 0.37%)}	_450ms	_456ms
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,056ms (± 0.40%)}	_{3,050ms (± 0.38%)}	_{-6ms (- 0.19%)}	_3,037ms	_3,066ms
_{Req 2 - geterr}	_{5,907ms (± 0.66%)}	_{5,878ms (± 0.94%)}	_{-29ms (- 0.49%)}	_5,800ms	_5,950ms
_{Req 3 - references}	_{383ms (± 1.03%)}	_{384ms (± 1.34%)}	_{+1ms (+ 0.38%)}	_375ms	_389ms
_{Req 4 - navto}	_{288ms (± 0.44%)}	_{292ms (± 1.21%)}	_{+3ms (+ 1.18%)}	_286ms	_296ms
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_{0 ( 0.00%)}	_1,356	_1,356
_{Req 5 - completionInfo}	_{82ms (± 1.20%)}	_{80ms (± 3.17%)}	_{-2ms (- 2.78%)}	_77ms	_85ms
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,199ms (± 1.02%)}	_{3,205ms (± 0.59%)}	_{+5ms (+ 0.17%)}	_3,183ms	_3,239ms
_{Req 2 - geterr}	_{4,392ms (± 1.16%)}	_{4,366ms (± 0.76%)}	_{-27ms (- 0.61%)}	_4,305ms	_4,406ms
_{Req 3 - references}	_{408ms (± 1.63%)}	_{410ms (± 0.74%)}	_{+2ms (+ 0.47%)}	_408ms	_414ms
_{Req 4 - navto}	_{308ms (± 2.47%)}	_{303ms (± 2.37%)}	_{-5ms (- 1.63%)}	_295ms	_312ms
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_{0 ( 0.00%)}	_1,518	_1,518
_{Req 5 - completionInfo}	_{82ms (± 7.39%)}	_{85ms (±10.35%)}	_{+3ms (+ 4.04%)}	_76ms	_96ms
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,783ms (± 0.50%)}	_{3,788ms (± 0.80%)}	_{+5ms (+ 0.14%)}	_3,756ms	_3,842ms
_{Req 2 - geterr}	_{1,460ms (± 0.95%)}	_{1,463ms (± 0.68%)}	_{+3ms (+ 0.20%)}	_1,452ms	_1,476ms
_{Req 3 - references}	_{132ms (± 2.26%)}	_{131ms (± 2.49%)}	_{-1ms (- 1.01%)}	_128ms	_134ms
_{Req 4 - navto}	_{395ms (± 0.66%)}	_{395ms (± 0.13%)}	_{-1ms (- 0.14%)}	_394ms	_395ms
_{Req 5 - completionInfo count}	_{3,154 (± 0.00%)}	_{3,154 (± 0.00%)}	_{0 ( 0.00%)}	_3,154	_3,154
_{Req 5 - completionInfo}	_{498ms (± 1.34%)}	_{496ms (± 1.47%)}	_{-2ms (- 0.42%)}	_486ms	_502ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₀₄₈	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52048

_Metric	_main	₅₂₀₄₈	_Delta	_Best	_Worst
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{138.42ms (± 0.27%)}	_{138.37ms (± 0.23%)}	_{-0.05ms (- 0.04%)}	_137.50ms	_141.25ms
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{222.62ms (± 0.19%)}	_{222.46ms (± 0.18%)}	_{-0.16ms (- 0.07%)}	_220.89ms	_226.13ms
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{224.03ms (± 0.19%)}	_{224.02ms (± 0.16%)}	_{-0.01ms (- 0.00%)}	_223.04ms	_231.72ms
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{207.69ms (± 0.20%)}	_{207.37ms (± 0.18%)}	_{-0.32ms (- 0.15%)}	_205.72ms	_210.62ms

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₀₄₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Copy link

Collaborator

typescript-bot commentedJan 5, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparingmain andrefs/pull/52048/merge:

Something interesting changed - please have a look.

Details

directus/directus

⚠️ Note that built also had errors⚠️

Req #2133 - completionInfo    at hasCovariantVoidArgument (/typescript-main/built/local/tsserver.js:60119:91)    at relateVariances (/typescript-main/built/local/tsserver.js:59369:64)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59038:32)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-main/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-main/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-main/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-main/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-main/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-main/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-main/built/local/tsserver.js:60079:23)    at getAliasVariances (/typescript-main/built/local/tsserver.js:60060:12)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59034:27)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at indexInfoRelatedTo (/typescript-main/built/local/tsserver.js:59904:23)    at typeRelatedToIndexInfo (/typescript-main/built/local/tsserver.js:59933:16)    at indexSignaturesRelatedTo (/typescript-main/built/local/tsserver.js:59922:280)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59334:28)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-main/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-main/built/local/tsserver.js:60079:23)    at getAliasVariances (/typescript-main/built/local/tsserver.js:60060:12)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59034:27)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-main/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-main/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-main/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-main/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-main/built/local/tsserver.js:60079:23)    at getVariances (/typescript-main/built/local/tsserver.js:60057:128)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59309:29)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-main/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-main/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isRelatedToWorker (/typescript-main/built/local/tsserver.js:58463:14)    at compareSignaturesRelated (/typescript-main/built/local/tsserver.js:57998:119)    at signatureRelatedTo (/typescript-main/built/local/tsserver.js:59844:14)    at signaturesRelatedTo (/typescript-main/built/local/tsserver.js:59776:27)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59330:24)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-main/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-main/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-main/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-main/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-main/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isRelatedToWorker (/typescript-main/built/local/tsserver.js:58463:14)    at compareSignaturesRelated (/typescript-main/built/local/tsserver.js:57998:119)    at signatureRelatedTo (/typescript-main/built/local/tsserver.js:59844:14)    at signaturesRelatedTo (/typescript-main/built/local/tsserver.js:59776:27)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59330:24)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-main/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-main/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-main/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-main/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58956:21)

Req #2133 - completionInfo    at hasCovariantVoidArgument (/typescript-52048/built/local/tsserver.js:60119:91)    at relateVariances (/typescript-52048/built/local/tsserver.js:59369:64)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59038:32)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-52048/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-52048/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-52048/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-52048/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-52048/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-52048/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-52048/built/local/tsserver.js:60079:23)    at getAliasVariances (/typescript-52048/built/local/tsserver.js:60060:12)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59034:27)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at indexInfoRelatedTo (/typescript-52048/built/local/tsserver.js:59904:23)    at typeRelatedToIndexInfo (/typescript-52048/built/local/tsserver.js:59933:16)    at indexSignaturesRelatedTo (/typescript-52048/built/local/tsserver.js:59922:280)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59334:28)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-52048/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-52048/built/local/tsserver.js:60079:23)    at getAliasVariances (/typescript-52048/built/local/tsserver.js:60060:12)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59034:27)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-52048/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-52048/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-52048/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at checkTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58219:20)    at isTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58174:14)    at isTypeAssignableTo (/typescript-52048/built/local/tsserver.js:57525:12)    at getVariancesWorker (/typescript-52048/built/local/tsserver.js:60079:23)    at getVariances (/typescript-52048/built/local/tsserver.js:60057:128)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59309:29)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-52048/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-52048/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isRelatedToWorker (/typescript-52048/built/local/tsserver.js:58463:14)    at compareSignaturesRelated (/typescript-52048/built/local/tsserver.js:57998:119)    at signatureRelatedTo (/typescript-52048/built/local/tsserver.js:59844:14)    at signaturesRelatedTo (/typescript-52048/built/local/tsserver.js:59776:27)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59330:24)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-52048/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-52048/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-52048/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at eachTypeRelatedToType (/typescript-52048/built/local/tsserver.js:58798:28)    at unionOrIntersectionRelatedTo (/typescript-52048/built/local/tsserver.js:58697:171)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59026:23)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isRelatedToWorker (/typescript-52048/built/local/tsserver.js:58463:14)    at compareSignaturesRelated (/typescript-52048/built/local/tsserver.js:57998:119)    at signatureRelatedTo (/typescript-52048/built/local/tsserver.js:59844:14)    at signaturesRelatedTo (/typescript-52048/built/local/tsserver.js:59776:27)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59330:24)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)    at recursiveTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58926:19)    at isRelatedTo (/typescript-52048/built/local/tsserver.js:58529:122)    at isPropertySymbolTypeRelated (/typescript-52048/built/local/tsserver.js:59479:14)    at propertyRelatedTo (/typescript-52048/built/local/tsserver.js:59526:23)    at propertiesRelatedTo (/typescript-52048/built/local/tsserver.js:59712:29)    at structuredTypeRelatedToWorker (/typescript-52048/built/local/tsserver.js:59328:21)    at structuredTypeRelatedTo (/typescript-52048/built/local/tsserver.js:58956:21)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/directus.directus.rawError.txt in theartifact folder

Last few requests

{"seq":2130,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/api/src/services/graphql/index.ts","line":338,"offset":21,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":2131,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/api/src/services/graphql/index.ts","line":367,"offset":1,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":2132,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/api/src/services/graphql/index.ts","line":367,"offset":1,"entryNames":["_convertObjectType"]}}{"seq":2133,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/api/src/services/graphql/index.ts","line":386,"offset":60,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}

Repro Steps

git clone https://github.com/directus/directus --recurse-submodules
In dirdirectus, rungit reset --hard cbd2af050b0fe68b8d9a395da469597aec2b41a9
In dirdirectus, runpnpm install --no-frozen-lockfile --prefer-offline --ignore-scripts --reporter=silent
Back in the initial folder, downloadRepoResults4/directus.directus.replay.txt from theartifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./directus ./directus.directus.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

felixrieseberg/windows95

⚠️ Note that built also had errors⚠️

Req #297 - references    at formatMessage2 (/typescript-main/built/local/tsserver.js:159403:21)    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160410:21)    at IOSession.send (/typescript-main/built/local/tsserver.js:160407:10)    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160454:10)    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:162065:14)    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163451:14)

Req #297 - references    at formatMessage2 (/typescript-52048/built/local/tsserver.js:159410:21)    at IOSession.writeMessage (/typescript-52048/built/local/tsserver.js:160417:21)    at IOSession.send (/typescript-52048/built/local/tsserver.js:160414:10)    at IOSession.doOutput (/typescript-52048/built/local/tsserver.js:160461:10)    at IOSession.onMessage (/typescript-52048/built/local/tsserver.js:162072:14)    at Interface.<anonymous> (/typescript-52048/built/local/tsserver.js:163458:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/felixrieseberg.windows95.rawError.txt in theartifact folder

Last few requests

{"seq":294,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":29694,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":295,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":29694,"entryNames":["_"]}}{"seq":296,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":31046}}{"seq":297,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":31059}}

Repro Steps

git clone https://github.com/felixrieseberg/windows95 --recurse-submodules
In dirwindows95, rungit reset --hard 17a81393467e2668eb2eea291ab4b6a749756dad
In dirwindows95, runyarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, downloadRepoResults4/felixrieseberg.windows95.replay.txt from theartifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./windows95 ./felixrieseberg.windows95.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors⚠️

Req #13114 - references    at formatMessage2 (/typescript-main/built/local/tsserver.js:159403:21)    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160410:21)    at IOSession.send (/typescript-main/built/local/tsserver.js:160407:10)    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160454:10)    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:162065:14)    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163451:14)

Req #13114 - references    at formatMessage2 (/typescript-52048/built/local/tsserver.js:159410:21)    at IOSession.writeMessage (/typescript-52048/built/local/tsserver.js:160417:21)    at IOSession.send (/typescript-52048/built/local/tsserver.js:160414:10)    at IOSession.doOutput (/typescript-52048/built/local/tsserver.js:160461:10)    at IOSession.onMessage (/typescript-52048/built/local/tsserver.js:162072:14)    at Interface.<anonymous> (/typescript-52048/built/local/tsserver.js:163458:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in theartifact folder

Last few requests

{"seq":13111,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":586264,"entryNames":["_"]}}{"seq":13112,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":586580,"includeExternalModuleExports":true,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":13113,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":586609,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":13114,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":587766}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dirblueprint, rungit reset --hard b8653656018f3a0d08a9fdadd5fd0e2813f9c158
In dirblueprint, runyarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, downloadRepoResults4/palantir.blueprint.replay.txt from theartifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

vercel/hyper

⚠️ Note that built also had errors⚠️

Req #12671 - references    at formatMessage2 (/typescript-main/built/local/tsserver.js:159403:21)    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160410:21)    at IOSession.send (/typescript-main/built/local/tsserver.js:160407:10)    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160454:10)    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:162065:14)    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163451:14)

Req #12671 - references    at formatMessage2 (/typescript-52048/built/local/tsserver.js:159410:21)    at IOSession.writeMessage (/typescript-52048/built/local/tsserver.js:160417:21)    at IOSession.send (/typescript-52048/built/local/tsserver.js:160414:10)    at IOSession.doOutput (/typescript-52048/built/local/tsserver.js:160461:10)    at IOSession.onMessage (/typescript-52048/built/local/tsserver.js:162072:14)    at Interface.<anonymous> (/typescript-52048/built/local/tsserver.js:163458:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/vercel.hyper.rawError.txt in theartifact folder

Last few requests

{"seq":12668,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":121581,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":12669,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":121581,"entryNames":["__webpack_require__"]}}{"seq":12670,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":122310,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}{"seq":12671,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":84971,"offset":123278}}

Repro Steps

git clone https://github.com/vercel/hyper --recurse-submodules
In dirhyper, rungit reset --hard f494781ff22171cb4ab6081dbd6f71b13ae5f9a3
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dirhyper/app, runyarn install --ignore-engines --ignore-scripts --silent
2. In dirhyper, runyarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, downloadRepoResults2/vercel.hyper.replay.txt from theartifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./hyper ./vercel.hyper.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

Copy link

Collaborator

typescript-bot commentedJan 5, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparingmain andrefs/pull/52048/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.monaco.json

error TS2365: Operator '<=' cannot be applied to types 'number' and 'number | never[]'.
- src/vs/editor/browser/viewParts/indentGuides/indentGuides.ts#L212
error TS2365: Operator '<' cannot be applied to types 'string | number' and 'number'.
- src/vs/editor/common/services/modelService.ts#L200

neoclide/coc.nvim

tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'unknown' and 'number'.
- src/__tests__/client/diagnostics.test.ts#L297
- src/__tests__/list/mappings.test.ts#L56
error TS2365: Operator '>=' cannot be applied to types 'unknown' and 'number'.
- src/model/editInspect.ts#L131

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number | boolean | RegExp'.
- src/logic/validateField.ts#L186
error TS2365: Operator '<' cannot be applied to types 'number' and 'string | number | boolean | RegExp'.
- src/logic/validateField.ts#L189

react-native-elements/react-native-elements

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number'.
- packages/base/src/Tooltip/Tooltip.tsx#L178 intsconfig.json

recharts/recharts

demo/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number'.
- src/component/Text.tsx#L119

tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'number' and 'string | number'.
- src/component/Text.tsx#L119

sveltejs/svelte

2 of 3 projects failed to build with the old tsc and were ignored

src/runtime/tsconfig.json

error TS2365: Operator '>' cannot be applied to types 'number' and 'number | ((from: T, to: T) => number)'.
- src/runtime/motion/tweened.ts#L125

DanielRosenwasser mentioned this pull request

Jan 7, 2023

Design Meeting Notes, 1/6/2023#52141

Closed

sandersn requested a review fromRyanCavanaugh

January 10, 2023 21:42

Copy link

Collaborator

typescript-bot commentedJan 10, 2023

The TypeScript team hasn't accepted the linked issue#52036. If you can get it accepted, this PR will have a better chance of being reviewed.

sandersn requested a review fromjakebailey

January 10, 2023 21:42

sandersn assignedjakebailey

Jan 10, 2023

Copy link

ContributorAuthor

Andarist commentedJan 16, 2023•
edited
Loading

@RyanCavanaugh the union cases that you mentioned are conceptually the same as the issue that I'm trying to fix here, so I guess that if we decide to move this PR forward (in some shape) then that would be a breaking change for those situations. I don't see any additional heuristics that would keep those cases working while erroring on the case linked to this PR.

TheNumber case is an edge case but well, conceptually it's a valid one - so this could be fixed here.

Cases discovered by the top are also related to unions and one is related tounknown. There are also some LSP issues reportedhere. It's surprising that this has affected LSP anyhow so I wonder if those are not false positives somehow but I could investigate this further and fix the issues if they are legit.

All in all, it kinda boils down to making a decision about the desired behavior here and only your team can do that. I'm more than happy to work on an adjusted algorithm for this but I'd have to know what that is (if it would be any different from what I have in this PR). It's not that I'm not willing to experiment and propose algorithm adjustments - it's just that the whole thing is very subtle and you have the best idea of what kind of disputable you might want to allow. So at the very least, I could use a little bit of a push from your team's side to explore the improved algorithm.

Let me know what you think, if you want to act on this anyhow or if you prefer to close the PR. From my PoV, most of the new errors are desired - those cases won't throw, so they are "type-safe" but they rely on some implicit coercions~ that are often super easy to miss. This change would require adding some additionaltypeof x === 'number' to codebases but I'd consider the RoI worth it.

DanielRosenwasser mentioned this pull request

Jan 18, 2023

Design Meeting Notes, 1/18/2023#52296

Closed

RyanCavanaugh added the Breaking ChangeWould introduce errors in existing code label

Jan 19, 2023

Copy link

ContributorAuthor

Andarist commentedJan 20, 2023

I see inthe latest design notes that:

Conclusion: Feels like this PR is a good start. Want to bring this in for 5.0.

What are the next steps here then? Which cases should I fix and which cases do we want to keep as "broken"? cc@RyanCavanaugh @DanielRosenwasser

Copy link

Member

RyanCavanaugh commentedJan 20, 2023

There might be some more corner cases to explore here, but I think this is effectively what we want to "try" in the 5.0 beta to gauge reaction and figure out what to tweak (or if it's just going to have to roll back entirely). I'm leaning toward merge as-is.@DanielRosenwasser good to go?

jakebailey approved these changes

Jan 20, 2023

View reviewed changes

Copy link

ContributorAuthor

Andarist commentedJan 20, 2023

While working on this, I initially made a different change but then discovered that TS currently allows this:

classA{foo(){}}classBextendsA{bar(){}}declareconsta:Adeclareconstb:Ba<b// ok?

So I went with a different route, trying to keep this behavior as I thought that it was desired. But given the discussion and an attempt to change the base behavior - should this case (and similar ones) be considered an error? How do we define what TS treats as a valid comparison?

From my PoV, allowing the comparison to be OK based on both types being comparable is not that useful and is a footgun. I'm specifically calling out this part of the check:

!leftAssignableToNumber&&!rightAssignableToNumber&&areTypesComparable(left,right);

RyanCavanaugh merged commit2acbcee intomicrosoft:main

Jan 20, 2023

RyanCavanaugh mentioned this pull request

Jan 20, 2023

Tighten relational operator more#52342

Closed

jakebailey mentioned this pull request

Jan 23, 2023

Fix error in herebyfile after comparison strictness change#52376

Merged

jakebailey mentioned this pull request

Feb 9, 2023

Specific enum value not comparable with number in 5.0#52701

Closed

Andarist mentioned this pull request

Feb 14, 2023

Operator '<' cannot be applied to types 'Number' and 'number'#52753

Closed

Copy link

redradist commentedMay 1, 2023

@Andarist
FYI, Regarding this issue with implicit coercion I wrote a libraryhttps://github.com/redradist/SafeScript that completly exclude implicit coersion

cben mentioned this pull request

Sep 21, 2023

ts2365 allows unsafe comparisons: string | number < string | number#55808

Open

Labels

Breaking Change

Would introduce errors in existing code

For Uncommitted Bug

PR for untriaged, rejected, closed or missing bug

5 participants

Movatterモバイル変換

Improve comparison operators type checking to disallow unions containing numbers as an operand#52048

Improve comparison operators type checking to disallow unions containing numbers as an operand#52048

Uh oh!

Conversation

Andarist commentedDec 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RyanCavanaugh commentedJan 4, 2023

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023

Uh oh!

typescript-bot commentedJan 4, 2023

Uh oh!

typescript-bot commentedJan 4, 2023

Uh oh!

RyanCavanaugh commentedJan 4, 2023

Uh oh!

Andarist commentedJan 4, 2023

Uh oh!

typescript-bot commentedJan 5, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commentedJan 5, 2023

Last few requests

Repro Steps

Last few requests

Repro Steps

Last few requests

Repro Steps

Last few requests

Repro Steps

Uh oh!

typescript-bot commentedJan 5, 2023

Uh oh!

typescript-bot commentedJan 10, 2023

Uh oh!

Andarist commentedJan 16, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Andarist commentedJan 20, 2023

Uh oh!

RyanCavanaugh commentedJan 20, 2023

Uh oh!

Andarist commentedJan 20, 2023

Uh oh!

redradist commentedMay 1, 2023

Uh oh!

Uh oh!

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

typescript-bot commentedJan 4, 2023•
edited
Loading

Andarist commentedJan 16, 2023•
edited
Loading