Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enables passing--declaration,--emitDeclarationOnly,--declarationMap,--soureMap and--inlineSourceMap totsc --build#51241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sheetalkamat merged 12 commits intomainfromcommandLineBuildSelected
Nov 7, 2022

Conversation

sheetalkamat
Copy link
Member

@sheetalkamatsheetalkamat commentedOct 20, 2022
edited
Loading

This enables passing--declaration,--emitDeclarationOnly,--declarationMap,--soureMap and--inlineSourceMap totsc --build.
As part of this change:

  1. tsbuildInfo stores these options so that we can check if we need to re-emit because of the flag changes,
  2. Changes to builder include, storing affectedFilesPendingEmit as has BuilderFileEmit which is flag of JS, Dts, DtsMap etc. determining what kind of emit is pending
  3. emit signatures for composite project encode if emit was done usingdeclrationMap options different from what the current compilerOptions are (eg if there are errors there wont be emit and emitSignature can go out of sync with options). This helps with checking if d.ts has changed or not irrespective of it being emitted with map
  4. Source file version also excludes sourceMappingUrl so that sourceFile version is independent of sourceMap. Both of these steps helps with avoidin unnecessary builds in downstream projects
  5. With --out we store all fileInfos and options so we can correctly calcualte the uptodateness and pending emit(js, dts or none)
  6. Enables the js only emit and handles --out bundling story when doing partial emit (keeping existing js or dts bundle information in buildInfo)

Fixes#51164

@sheetalkamatsheetalkamatforce-pushed thecommandLineBuildSelected branch 4 times, most recently from648ce65 to35994b1CompareOctober 21, 2022 22:11
@typescript-bottypescript-bot added Author: Team For Uncommitted BugPR for untriaged, rejected, closed or missing bug labelsOct 21, 2022
@sheetalkamatsheetalkamatforce-pushed thecommandLineBuildSelected branch 4 times, most recently from32921e8 to0efa044CompareOctober 21, 2022 23:34
@sheetalkamatsheetalkamatforce-pushed thecommandLineBuildSelected branch 13 times, most recently frome5a439f toa1390a0CompareNovember 3, 2022 21:30
@sheetalkamatsheetalkamat marked this pull request as ready for reviewNovember 3, 2022 21:40
@sheetalkamatsheetalkamat changed the title[WIP] Some of the selected options of--buildEnables passing--declaration,--emitDeclarationOnly,--declarationMap,--soureMap and--inlineSourceMap totsc --buildNov 3, 2022
@jakebailey
Copy link
Member

@typescript-bot pack this

Going to try this on the module branch.

sheetalkamat reacted with thumbs up emoji

@typescript-bot
Copy link
Collaborator

typescript-bot commentedNov 4, 2022
edited
Loading

Heya@jakebailey, I've started to run the tarball bundle task on this PR at34e5ec2. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

typescript-bot commentedNov 4, 2022
edited
Loading

Hey@jakebailey, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/137645/artifacts?artifactName=tgz&fileId=F047FEE07F98961F99E4D66E9BE280123DA2BEDF5528C75C0D43136275FB686E02&fileName=/typescript-5.0.0-insiders.20221104.tgz"    }}

and then runningnpm install.


There is also a playgroundfor this build and annpm module you can use via"typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-51241-2".;

@jakebailey
Copy link
Member

jakebailey commentedNov 5, 2022
edited
Loading

Tested it out, and it does appear to work, nice!

Not sure Andrew has had time to look at this quite yet, but it seems reasonable to me. Mostly test baseline changes.

sheetalkamat reacted with thumbs up emoji

@typescript-bottypescript-bot added For Milestone BugPRs that fix a bug with a specific milestone and removed For Uncommitted BugPR for untriaged, rejected, closed or missing bug labelsNov 7, 2022
@Conaclos
Copy link

Conaclos commentedJan 27, 2023
edited
Loading

ShouldoutDir be accepted as well?
e.g.

tsc --build src --emitDeclarationOnly --outDir dist

For now I got the following error:Compiler option '--outDir' may not be used with '--build'

@sheetalkamat
Copy link
MemberAuthor

Should outDir be accepted as well?

all the path related options are per project specific so will not be part of--build because it's for building multiple projects.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jakebaileyjakebaileyjakebailey left review comments

@andrewbranchandrewbranchandrewbranch approved these changes

Assignees

@sheetalkamatsheetalkamat

Labels
Author: TeamFor Milestone BugPRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow --emitDeclarationOnly flag to be passed in --build
5 participants
@sheetalkamat@jakebailey@typescript-bot@Conaclos@andrewbranch

[8]ページ先頭

©2009-2025 Movatter.jp