Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

mark length of readonly tuple as readonly#47717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sandersn merged 1 commit intomicrosoft:mainfromZzzen:readonly-tuple-length
Feb 15, 2022

Conversation

@Zzzen
Copy link
Contributor

Fixes#47260

@typescript-bottypescript-bot added the For Backlog BugPRs that fix a backlog bug labelFeb 3, 2022
@DanielRosenwasser
Copy link
Member

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 4, 2022•
edited
Loading

Heya@DanielRosenwasser, I've started to run the tarball bundle task on this PR ate1fe677. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 4, 2022•
edited
Loading

Heya@DanielRosenwasser, I've started to run the perf test suite on this PR ate1fe677. You can monitor the buildhere.

Update:The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 4, 2022•
edited
Loading

Heya@DanielRosenwasser, I've started to run the extended test suite on this PR ate1fe677. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 4, 2022•
edited
Loading

Heya@DanielRosenwasser, I've started to run the parallelized community code test suite on this PR ate1fe677. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 4, 2022•
edited
Loading

Heya@DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR ate1fe677. You can monitor the buildhere.

@typescript-bot
Copy link
Collaborator

Hey@DanielRosenwasser, I've packed this intoan installable tgz. You can install it for testing by referencing it in yourpackage.json like so:

{    "devDependencies": {        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/119235/artifacts?artifactName=tgz&fileId=179E3F3899E84A167CD34B8FFD7EC9D18C5D6329A819889FC7558DEC8B922CD902&fileName=/typescript-4.6.0-insiders.20220204.tgz"    }}

and then runningnpm install.

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..47717

Metricmain47717DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used356,326k (± 0.02%)356,370k (± 0.01%)+45k (+ 0.01%)356,225k356,455k
Parse Time1.96s (± 0.54%)1.96s (± 0.65%)+0.00s (+ 0.10%)1.93s1.99s
Bind Time0.85s (± 0.70%)0.87s (± 0.57%)+0.01s (+ 1.29%)0.86s0.88s
Check Time5.62s (± 0.54%)5.63s (± 0.61%)+0.02s (+ 0.28%)5.57s5.70s
Emit Time5.91s (± 0.51%)5.96s (± 0.56%)+0.05s (+ 0.85%)5.90s6.04s
Total Time14.33s (± 0.36%)14.41s (± 0.41%)+0.08s (+ 0.57%)14.29s14.55s
Compiler-Unions - node (v10.16.3, x64)
Memory used204,231k (± 0.03%)204,275k (± 0.03%)+44k (+ 0.02%)204,144k204,382k
Parse Time0.79s (± 0.76%)0.80s (± 1.12%)+0.01s (+ 1.15%)0.78s0.82s
Bind Time0.53s (± 1.30%)0.53s (± 1.05%)+0.00s (+ 0.57%)0.52s0.54s
Check Time7.87s (± 0.52%)7.93s (± 0.99%)+0.06s (+ 0.77%)7.80s8.17s
Emit Time2.48s (± 0.85%)2.47s (± 1.18%)-0.01s (- 0.24%)2.43s2.54s
Total Time11.65s (± 0.38%)11.72s (± 0.77%)+0.07s (+ 0.57%)11.55s11.92s
Monaco - node (v10.16.3, x64)
Memory used342,657k (± 0.02%)342,638k (± 0.03%)-19k (- 0.01%)342,372k342,781k
Parse Time1.48s (± 0.42%)1.49s (± 0.90%)+0.00s (+ 0.27%)1.46s1.52s
Bind Time0.76s (± 0.79%)0.76s (± 0.45%)+0.00s (+ 0.26%)0.75s0.76s
Check Time5.55s (± 0.61%)5.54s (± 0.41%)-0.01s (- 0.14%)5.50s5.59s
Emit Time3.21s (± 0.86%)3.25s (± 1.08%)+0.04s (+ 1.12%)3.16s3.31s
Total Time11.00s (± 0.32%)11.03s (± 0.33%)+0.03s (+ 0.29%)10.95s11.14s
TFS - node (v10.16.3, x64)
Memory used305,696k (± 0.02%)305,797k (± 0.02%)+101k (+ 0.03%)305,658k305,910k
Parse Time1.20s (± 0.51%)1.21s (± 0.75%)+0.01s (+ 0.67%)1.19s1.22s
Bind Time0.72s (± 0.62%)0.72s (± 0.95%)-0.01s (- 0.83%)0.70s0.73s
Check Time5.06s (± 0.67%)5.06s (± 0.56%)+0.00s (+ 0.02%)5.00s5.11s
Emit Time3.40s (± 0.76%)3.40s (± 1.21%)+0.00s (+ 0.06%)3.34s3.53s
Total Time10.38s (± 0.37%)10.39s (± 0.58%)+0.01s (+ 0.07%)10.27s10.56s
material-ui - node (v10.16.3, x64)
Memory used471,934k (± 0.01%)471,885k (± 0.01%)-49k (- 0.01%)471,804k472,040k
Parse Time1.78s (± 0.53%)1.78s (± 0.56%)+0.01s (+ 0.39%)1.77s1.81s
Bind Time0.66s (± 1.21%)0.67s (± 0.70%)+0.01s (+ 1.21%)0.66s0.68s
Check Time14.25s (± 0.66%)14.39s (± 0.78%)+0.14s (+ 1.01%)14.14s14.63s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time16.69s (± 0.61%)16.84s (± 0.70%)+0.16s (+ 0.95%)16.59s17.09s
xstate - node (v10.16.3, x64)
Memory used570,550k (± 0.02%)574,080k (± 1.39%)+3,531k (+ 0.62%)570,313k606,316k
Parse Time2.56s (± 0.34%)2.57s (± 0.44%)+0.01s (+ 0.55%)2.54s2.59s
Bind Time1.01s (± 0.29%)1.02s (± 0.69%)+0.01s (+ 1.09%)1.01s1.04s
Check Time1.50s (± 0.55%)1.51s (± 0.72%)+0.01s (+ 1.00%)1.49s1.53s
Emit Time0.07s (± 0.00%)0.07s (± 4.13%)+0.00s (+ 2.86%)0.07s0.08s
Total Time5.14s (± 0.28%)5.17s (± 0.36%)+0.03s (+ 0.53%)5.11s5.20s
Angular - node (v12.1.0, x64)
Memory used333,906k (± 0.12%)333,919k (± 0.09%)+13k (+ 0.00%)332,747k334,164k
Parse Time1.95s (± 0.60%)1.96s (± 0.74%)+0.01s (+ 0.62%)1.93s1.99s
Bind Time0.84s (± 0.86%)0.85s (± 1.13%)+0.01s (+ 1.07%)0.83s0.87s
Check Time5.42s (± 0.51%)5.44s (± 0.56%)+0.02s (+ 0.31%)5.40s5.55s
Emit Time6.14s (± 0.58%)6.15s (± 0.61%)+0.01s (+ 0.21%)6.09s6.28s
Total Time14.35s (± 0.37%)14.40s (± 0.44%)+0.05s (+ 0.34%)14.33s14.64s
Compiler-Unions - node (v12.1.0, x64)
Memory used191,771k (± 0.04%)191,769k (± 0.03%)-3k (- 0.00%)191,621k191,851k
Parse Time0.78s (± 0.74%)0.78s (± 0.79%)+0.00s (+ 0.13%)0.77s0.79s
Bind Time0.54s (± 0.69%)0.54s (± 0.68%)+0.00s (+ 0.19%)0.53s0.54s
Check Time7.32s (± 0.40%)7.38s (± 0.72%)+0.06s (+ 0.79%)7.26s7.55s
Emit Time2.48s (± 0.91%)2.47s (± 0.64%)-0.02s (- 0.76%)2.44s2.51s
Total Time11.12s (± 0.30%)11.16s (± 0.59%)+0.04s (+ 0.36%)11.03s11.36s
Monaco - node (v12.1.0, x64)
Memory used325,727k (± 0.02%)325,730k (± 0.03%)+3k (+ 0.00%)325,427k325,998k
Parse Time1.46s (± 0.72%)1.48s (± 1.07%)+0.01s (+ 0.96%)1.45s1.51s
Bind Time0.74s (± 0.91%)0.74s (± 0.46%)-0.00s (- 0.13%)0.74s0.75s
Check Time5.44s (± 0.60%)5.47s (± 0.51%)+0.03s (+ 0.53%)5.41s5.53s
Emit Time3.26s (± 0.95%)3.29s (± 0.78%)+0.04s (+ 1.20%)3.22s3.35s
Total Time10.90s (± 0.37%)10.99s (± 0.47%)+0.08s (+ 0.74%)10.89s11.08s
TFS - node (v12.1.0, x64)
Memory used290,444k (± 0.02%)290,454k (± 0.03%)+10k (+ 0.00%)290,333k290,679k
Parse Time1.21s (± 0.66%)1.21s (± 0.95%)+0.01s (+ 0.41%)1.20s1.25s
Bind Time0.70s (± 1.23%)0.70s (± 0.63%)+0.00s (+ 0.00%)0.69s0.71s
Check Time4.99s (± 0.40%)5.00s (± 0.41%)+0.01s (+ 0.14%)4.96s5.04s
Emit Time3.44s (± 0.47%)3.43s (± 0.50%)-0.01s (- 0.29%)3.38s3.47s
Total Time10.34s (± 0.22%)10.34s (± 0.28%)+0.00s (+ 0.04%)10.28s10.41s
material-ui - node (v12.1.0, x64)
Memory used450,679k (± 0.01%)450,709k (± 0.01%)+29k (+ 0.01%)450,596k450,792k
Parse Time1.78s (± 0.33%)1.79s (± 0.58%)+0.01s (+ 0.84%)1.77s1.82s
Bind Time0.64s (± 0.53%)0.64s (± 1.13%)-0.00s (- 0.16%)0.62s0.66s
Check Time12.82s (± 0.75%)12.84s (± 0.87%)+0.02s (+ 0.16%)12.69s13.08s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.24s (± 0.65%)15.28s (± 0.76%)+0.04s (+ 0.26%)15.10s15.54s
xstate - node (v12.1.0, x64)
Memory used536,436k (± 0.02%)539,969k (± 1.44%)+3,532k (+ 0.66%)536,337k571,349k
Parse Time2.51s (± 0.74%)2.50s (± 0.40%)-0.00s (- 0.04%)2.48s2.53s
Bind Time1.05s (± 0.63%)1.05s (± 0.71%)-0.00s (- 0.00%)1.04s1.07s
Check Time1.44s (± 0.61%)1.44s (± 0.77%)+0.00s (+ 0.14%)1.42s1.48s
Emit Time0.07s (± 0.00%)0.07s (± 0.00%)0.00s ( 0.00%)0.07s0.07s
Total Time5.07s (± 0.34%)5.08s (± 0.30%)+0.01s (+ 0.14%)5.04s5.12s
Angular - node (v14.15.1, x64)
Memory used332,364k (± 0.00%)332,353k (± 0.01%)-11k (- 0.00%)332,261k332,392k
Parse Time1.95s (± 0.68%)1.96s (± 0.77%)+0.01s (+ 0.41%)1.93s1.99s
Bind Time0.89s (± 0.79%)0.89s (± 0.79%)+0.00s (+ 0.22%)0.88s0.91s
Check Time5.45s (± 0.33%)5.47s (± 0.47%)+0.03s (+ 0.55%)5.43s5.52s
Emit Time6.20s (± 0.53%)6.21s (± 0.77%)+0.02s (+ 0.29%)6.13s6.33s
Total Time14.49s (± 0.25%)14.54s (± 0.50%)+0.05s (+ 0.35%)14.42s14.74s
Compiler-Unions - node (v14.15.1, x64)
Memory used192,663k (± 0.57%)193,229k (± 0.39%)+566k (+ 0.29%)190,358k193,697k
Parse Time0.81s (± 0.64%)0.81s (± 0.84%)+0.01s (+ 0.62%)0.80s0.83s
Bind Time0.56s (± 0.71%)0.56s (± 0.84%)+0.00s (+ 0.36%)0.56s0.58s
Check Time7.41s (± 0.53%)7.52s (± 0.71%)+0.11s (+ 1.48%)7.43s7.66s
Emit Time2.50s (± 1.17%)2.49s (± 0.50%)-0.01s (- 0.24%)2.46s2.52s
Total Time11.28s (± 0.59%)11.39s (± 0.50%)+0.12s (+ 1.03%)11.27s11.53s
Monaco - node (v14.15.1, x64)
Memory used324,512k (± 0.00%)324,522k (± 0.01%)+10k (+ 0.00%)324,479k324,562k
Parse Time1.50s (± 0.50%)1.52s (± 0.63%)+0.02s (+ 1.40%)1.50s1.54s
Bind Time0.77s (± 0.72%)0.77s (± 0.72%)0.00s ( 0.00%)0.76s0.78s
Check Time5.38s (± 0.62%)5.38s (± 0.40%)+0.00s (+ 0.06%)5.33s5.43s
Emit Time3.30s (± 0.94%)3.29s (± 0.25%)-0.00s (- 0.06%)3.27s3.31s
Total Time10.94s (± 0.58%)10.96s (± 0.24%)+0.02s (+ 0.20%)10.92s11.03s
TFS - node (v14.15.1, x64)
Memory used289,218k (± 0.01%)289,241k (± 0.01%)+23k (+ 0.01%)289,189k289,291k
Parse Time1.23s (± 0.81%)1.23s (± 0.63%)+0.00s (+ 0.08%)1.22s1.25s
Bind Time0.74s (± 0.78%)0.74s (± 0.78%)+0.00s (+ 0.41%)0.73s0.75s
Check Time4.98s (± 0.44%)4.99s (± 0.29%)+0.00s (+ 0.06%)4.95s5.02s
Emit Time3.55s (± 0.73%)3.56s (± 0.50%)+0.02s (+ 0.42%)3.51s3.60s
Total Time10.50s (± 0.42%)10.52s (± 0.26%)+0.02s (+ 0.19%)10.44s10.59s
material-ui - node (v14.15.1, x64)
Memory used448,902k (± 0.01%)448,691k (± 0.07%)-211k (- 0.05%)447,693k448,942k
Parse Time1.84s (± 0.58%)1.85s (± 0.54%)+0.01s (+ 0.33%)1.83s1.88s
Bind Time0.68s (± 0.73%)0.69s (± 0.75%)+0.01s (+ 0.88%)0.68s0.70s
Check Time12.96s (± 0.55%)13.06s (± 0.73%)+0.10s (+ 0.79%)12.86s13.35s
Emit Time0.00s (± 0.00%)0.00s (± 0.00%)0.00s ( NaN%)0.00s0.00s
Total Time15.48s (± 0.49%)15.60s (± 0.62%)+0.11s (+ 0.74%)15.39s15.89s
xstate - node (v14.15.1, x64)
Memory used534,082k (± 0.00%)534,082k (± 0.00%)-0k (- 0.00%)534,040k534,104k
Parse Time2.56s (± 0.57%)2.56s (± 0.40%)+0.00s (+ 0.08%)2.54s2.58s
Bind Time1.16s (± 0.48%)1.17s (± 0.96%)+0.01s (+ 0.60%)1.15s1.20s
Check Time1.48s (± 0.60%)1.49s (± 0.52%)+0.00s (+ 0.34%)1.47s1.50s
Emit Time0.08s (± 0.00%)0.08s (± 3.81%)-0.00s (- 2.50%)0.07s0.08s
Total Time5.29s (± 0.26%)5.30s (± 0.34%)+0.01s (+ 0.28%)5.26s5.34s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
BenchmarkNameIterations
Current4771710
Baselinemain10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished andfailed. I've opened aPR with the baseline diff from master.

@sandersn
Copy link
Member

@typescript-bot user test this inline

@typescript-bot
Copy link
Collaborator

typescript-bot commentedFeb 15, 2022•
edited
Loading

Heya@sandersn, I've started to run the diff-based community code test suite on this PR ate1fe677. You can monitor the buildhere.

Update:The results are in!

@sandersnsandersn merged commit81d1457 intomicrosoft:mainFeb 15, 2022
@DanielRosenwasserDanielRosenwasser added the Breaking ChangeWould introduce errors in existing code labelFeb 15, 2022
@typescript-bot
Copy link
Collaborator

@sandersn
Great news! no new errors were found between main..refs/pull/47717/merge

Copy link

@Enes60Enes60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Aşkısı

@microsoftmicrosoft locked asresolvedand limited conversation to collaboratorsOct 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@sandersnsandersnsandersn approved these changes

+1 more reviewer

@Enes60Enes60Enes60 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking ChangeWould introduce errors in existing codeFor Backlog BugPRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readonly open-ended tuples have writable length property

5 participants

@Zzzen@DanielRosenwasser@typescript-bot@sandersn@Enes60
[8]ページ先頭
©2009-2025 Movatter.jp