- Notifications
You must be signed in to change notification settings - Fork12.9k
Emit build info even on noEmitOnError or tsc --build#38853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.../watchMode/programUpdates/reportErrors/when-preserveWatchOutput-is-passed-on-command-line.jsShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| ) { | ||
| const canEmitBuildInfo = !(buildResult & BuildResultFlags.SyntaxErrors) && program && !outFile(program.getCompilerOptions()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do syntax errors block a build info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because there is nothing to write in this case. Only semantic errors are cached so there is no use writing tsbuildinfo in this case
* upstream/master: (48 commits) Fix merging of JS value & TS type decl LEGO: check in for master to temporary branch. `getSymbolDisplayPartsDocumentationAndSymbolKind`: use actual `symbol.flags` for `getAliasedSymbol` LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Fix two tests Update user baselines LEGO: check in for master to temporary branch. address PR comments Emit build info even on noEmitOnError or tsc --build (microsoft#38853) Some changes to tsc baselines for clarity (microsoft#38850) LEGO: check in for master to temporary branch. fix merge conflicts polish tests remove outdated tests convert import trigger reason test convert import trigger reason only convert export trigger reason test convert export cursor only changes remove declaration ...
Uh oh!
There was an error while loading.Please reload this page.
With this change the caching of semantic diagnostics in the builder is written to the disk with .tsbuildinfo so next incremental build should benefit from that.