- Notifications
You must be signed in to change notification settings - Fork12.9k
Add check for delete expression must be optional#37921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Is needed a test with an index type? Like: interfaceBar{[id:string]:string;}declareconsta:Bardeletea["a"];deletea.b; |
Kingwl commentedApr 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Good point. @typescript-bot pack this. |
Hey, How are you?@typescript-bot @typescript-bot pack this. |
typescript-bot commentedApr 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
typescript-bot commentedApr 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey@Kingwl, I've packed this intoan installable tgz. You can install it for testing by referencing it in your
and then running There is also a playgroundfor this build. |
This reverts commit39beb1d.
DanielRosenwasser commentedApr 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is a breaking change that was added in post beta with no test run on it. I think we should have had more due diligence before pulling it in. I think we should back it out and add it in for 4.0. |
simhnna commentedSep 17, 2020
What's the reasoning behind excluding
|
Because |
rohitf commentedSep 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Seeing a possible bug for the following case -even though TS recognizes thatkey in delete p[key] can be either 'foo' or 'bar', it does not error.
|
Fixes#13783