NotificationsYou must be signed in to change notification settings
Fork13.2k
Star107k

feat(29624): better errors for non-exported types#36187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

DanielRosenwasser merged 1 commit intomicrosoft:masterfroma-tarasyuk:feature/29624

Jan 21, 2020

Merged

feat(29624): better errors for non-exported types#36187

DanielRosenwasser merged 1 commit intomicrosoft:masterfroma-tarasyuk:feature/29624

Jan 21, 2020

Conversation

Copy link

Contributor

a-tarasyuk commentedJan 14, 2020•
edited
Loading

Fixes#29624

a-tarasyuk requested a review fromDanielRosenwasser

January 14, 2020 18:52

DanielRosenwasser reviewed

Jan 14, 2020

View reviewed changes

tests/baselines/reference/exportLocalSpellingSuggestion.js OutdatedShow resolvedHide resolved

a-tarasyuk force-pushed thefeature/29624 branch from274a6d6 to275c3e3Compare

January 15, 2020 09:40

a-tarasyuk requested a review fromDanielRosenwasser

January 15, 2020 09:45

a-tarasyuk marked this pull request as ready for review

January 17, 2020 15:13

DanielRosenwasser requested changes

Jan 17, 2020

View reviewed changes

tests/baselines/reference/exportLocalSpellingSuggestion.errors.txt OutdatedShow resolvedHide resolved

a-tarasyuk closed this

Jan 19, 2020

a-tarasyuk reopened this

Jan 21, 2020

a-tarasyuk force-pushed thefeature/29624 branch from275c3e3 toe315436Compare

January 21, 2020 13:10

feat(29624): improve errors for non-exported types

122caf3

a-tarasyuk force-pushed thefeature/29624 branch frome315436 to122caf3Compare

January 21, 2020 13:40

a-tarasyuk requested a review fromDanielRosenwasser

January 21, 2020 14:11

Copy link

Member

DanielRosenwasser commentedJan 21, 2020

@typescript-bot pack this

Copy link

Collaborator

typescript-bot commentedJan 21, 2020•
edited
Loading

Heya@DanielRosenwasser, I've started to run the tarball bundle task on this PR at122caf3. You can monitor the buildhere. It should now contribute to this PR's status checks.

DanielRosenwasser approved these changes

Jan 21, 2020

View reviewed changes

a-tarasyuk changed the title~~WIP feat(29624): better errors for non-exported types~~feat(29624): better errors for non-exported types

Jan 21, 2020

Copy link

Member

DanielRosenwasser commentedJan 21, 2020

@typescript-bot pack this

Copy link

Collaborator

typescript-bot commentedJan 21, 2020•
edited
Loading

Heya@DanielRosenwasser, I've started to run the tarball bundle task on this PR at122caf3. You can monitor the buildhere. It should now contribute to this PR's status checks.