- Notifications
You must be signed in to change notification settings - Fork13.2k
Better typings for Promise.resolve(), like #31117#33074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d5b8656 toed55bc5Compare3523d88 to8607e69Compare4aee6f8 toe6f14d6Compare0b9b4e6 to51538c3Comparea65e8c7 toacd3105Compare6a7c26e tob68a1baCompareab032d7 to3222ba5Compare7aefd80 to29b3adaComparesandersn commentedJun 1, 2022
@rbuckton Is this ready to merge now? |
rbuckton commentedAug 1, 2022
I'd like to run the RWC and user tests once more to be sure. |
rbuckton commentedAug 1, 2022
@typescript-bot run dt |
typescript-bot commentedAug 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Heya@rbuckton, I've started to run the diff-based user code test suite on this PR at915863f. You can monitor the buildhere. Update:The results are in! |
typescript-bot commentedAug 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
typescript-bot commentedAug 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
typescript-bot commentedAug 1, 2022
typescript-bot commentedAug 1, 2022
@rbuckton |
rbuckton commentedAug 2, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This still causes a build break in older versions of firebase-sdk, but since this only occurs in an outdated snapshot of firebase in our RWC tests and not in the most recent version of firebase, this change seems acceptable. |
sandersn commentedAug 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Note that this breaks declareconstUNDEFINED_VOID_ONLY:unique symbol;exportfunctionact(callback:()=>void|{[UNDEFINED_VOID_ONLY]:never}):DebugPromiseLike;// Intentionally doesn't extend PromiseLike<never>.// Ideally this should be as hard to accidentally use as possible.exportinterfaceDebugPromiseLike{// the actual then() in here is 1-ary, but that doesn't count as a PromiseLike.then(onfulfilled:(value:never)=>never,onrejected:(reason:never)=>never):never;}//@ts-expect-error <-- this is no longer an errorPromise.resolve(act(()=>{})); I think this change is still OK, I just wanted to report on the break. |
sandersn commentedAug 8, 2022
This breaks vscode in a few places too, so we're going to revert it for 4.8 to give us a chance to figure out what to do. |
Component commits:c28ee65 Revert "Better typings for Promise.resolve(), likemicrosoft#31117 (microsoft#33074)"This reverts commit040c121.
Component commits:c28ee65 Revert "Better typings for Promise.resolve(), likemicrosoft#31117 (microsoft#33074)"This reverts commit040c121.Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
No description provided.