NotificationsYou must be signed in to change notification settings
Fork13k
Star106k

Commit6ba7d35

authored

Consistently resolve to theerrorType onarguments with error (#62549)

1 parentd0d675a commit6ba7d35Copy full SHA for 6ba7d35

File tree

2 files changed

+33

-33

lines changed

src/compiler
- checker.ts
tests/baselines/reference
- argumentsUsedInClassFieldInitializerOrStaticInitializationBlock.types

2 files changed

+33

-33

lines changed

`‎src/compiler/checker.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30975,7 +30975,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`30975`	`30975`	`checkIdentifierCalculateNodeCheckFlags(node, symbol);`
`30976`	`30976`
`30977`	`30977`	`if (symbol === argumentsSymbol) {`
`30978`		`- if (isInPropertyInitializerOrClassStaticBlock(node)) {`
	`30978`	`+ if (isInPropertyInitializerOrClassStaticBlock(node, /ignoreArrowFunctions/ true)) {`
`30979`	`30979`	`return errorType;`
`30980`	`30980`	`}`
`30981`	`30981`	`return getTypeOfSymbol(symbol);`

`‎tests/baselines/reference/argumentsUsedInClassFieldInitializerOrStaticInitializationBlock.types‎`

Lines changed: 32 additions & 32 deletions

Original file line number	Diff line number	Diff line change
`@@ -116,12 +116,12 @@ function D() {`
`116`	`116`	`> : ^^^^^^^^`
`117`	`117`
`118`	`118`	`a = () => arguments // should error`
`119`		`->a : () =>IArguments`
`120`		`-> : ^^^^^^^^^^^^^^^^`
`121`		`->() => arguments : () =>IArguments`
`122`		`-> : ^^^^^^^^^^^^^^^^`
`123`		`->arguments :IArguments`
`124`		`-> : ^^^^^^^^^^`
	`119`	`+>a : () =>any`
	`120`	`+> : ^^^^^^^^^`
	`121`	`+>() => arguments : () =>any`
	`122`	`+> : ^^^^^^^^^`
	`123`	`+>arguments :any`
	`124`	`+> : ^^^`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`
`@@ -142,18 +142,18 @@ function D1() {`
`142`	`142`	`> : ^^^^^^^^^^`
`143`	`143`
`144`	`144`	`arguments; // should error`
`145`		`->arguments :IArguments`
`146`		`-> : ^^^^^^^^^^`
	`145`	`+>arguments :any`
	`146`	`+> : ^^^`
`147`	`147`
`148`	`148`	`const b = () => {`
`149`		`->b : () =>IArguments`
`150`		`-> : ^^^^^^^^^^^^^^^^`
`151`		`->() => { return arguments; // should error } : () =>IArguments`
`152`		`-> : ^^^^^^^^^^^^^^^^`
	`149`	`+>b : () =>any`
	`150`	`+> : ^^^^^^^^^`
	`151`	`+>() => { return arguments; // should error } : () =>any`
	`152`	`+> : ^^^^^^^^^`
`153`	`153`
`154`	`154`	`return arguments; // should error`
`155`		`->arguments :IArguments`
`156`		`-> : ^^^^^^^^^^`
	`155`	`+>arguments :any`
	`156`	`+> : ^^^`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`function f() {`
`@@ -286,16 +286,16 @@ function D5() {`
`286`	`286`	`> : ^^^^^^^^`
`287`	`287`
`288`	`288`	`a = (() => { return arguments; })() // should error`
`289`		`->a :IArguments`
`290`		`-> : ^^^^^^^^^^`
`291`		`->(() => { return arguments; })() :IArguments`
`292`		`-> : ^^^^^^^^^^`
`293`		`->(() => { return arguments; }) : () =>IArguments`
`294`		`-> : ^^^^^^^^^^^^^^^^`
`295`		`->() => { return arguments; } : () =>IArguments`
`296`		`-> : ^^^^^^^^^^^^^^^^`
`297`		`->arguments :IArguments`
`298`		`-> : ^^^^^^^^^^`
	`289`	`+>a :any`
	`290`	`+> : ^^^`
	`291`	`+>(() => { return arguments; })() :any`
	`292`	`+> : ^^^`
	`293`	`+>(() => { return arguments; }) : () =>any`
	`294`	`+> : ^^^^^^^^^`
	`295`	`+>() => { return arguments; } : () =>any`
	`296`	`+> : ^^^^^^^^^`
	`297`	`+>arguments :any`
	`298`	`+> : ^^^`
`299`	`299`	`}`
`300`	`300`	`}`
`301`	`301`
`@@ -310,14 +310,14 @@ function D6() {`
`310`	`310`	`> : ^^^^^^^^`
`311`	`311`
`312`	`312`	`a = (x = arguments) => {} // should error`
`313`		`->a : (x?:IArguments) => void`
`314`		`-> : ^ ^^^^^^^^^^^^^^^^^^^^^^`
`315`		`->(x = arguments) => {} : (x?:IArguments) => void`
`316`		`-> : ^ ^^^^^^^^^^^^^^^^^^^^^^`
`317`		`->x :IArguments`
`318`		`-> : ^^^^^^^^^^`
`319`		`->arguments :IArguments`
`320`		`-> : ^^^^^^^^^^`
	`313`	`+>a : (x?:any) => void`
	`314`	`+> : ^ ^^^^^^^^^^^^^^^`
	`315`	`+>(x = arguments) => {} : (x?:any) => void`
	`316`	`+> : ^ ^^^^^^^^^^^^^^^`
	`317`	`+>x :any`
	`318`	`+> : ^^^`
	`319`	`+>arguments :any`
	`320`	`+> : ^^^`
`321`	`321`	`}`
`322`	`322`	`}`
`323`	`323`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6ba7d35

File tree

2 files changed

2 files changed

`‎src/compiler/checker.ts‎`

`‎tests/baselines/reference/argumentsUsedInClassFieldInitializerOrStaticInitializationBlock.types‎`

0 commit comments