Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Neon implementations of std::reverse, std::reverse_copy#5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfromhazzlim:reverse-neon-pr
Nov 19, 2025

Conversation

@hazzlim
Copy link
Contributor

Benchmark numbers (relative performance compared to current baseline, > 1 is better)

nameMSVC SpeedupClang Speedup
rstd::uint8_t/344912.1714.00
rstd::uint8_t/634.355.69
rstd::uint8_t/312.222.85
rstd::uint8_t/151.241.48
rstd::uint8_t/70.590.82
rstd::uint16_t/34496.247.00
rstd::uint16_t/633.014.07
rstd::uint16_t/312.322.85
rstd::uint16_t/151.241.55
rstd::uint16_t/70.610.75
rstd::uint32_t/34492.472.18
rstd::uint32_t/632.583.20
rstd::uint32_t/311.982.41
rstd::uint32_t/151.221.48
rstd::uint32_t/70.60.85
rstd::uint64_t/34491.361.22
rstd::uint64_t/632.162.28
rstd::uint64_t/311.852.15
rstd::uint64_t/151.161.65
rstd::uint64_t/70.91.24
rcstd::uint8_t/344913.070.99
rcstd::uint8_t/633.991.27
rcstd::uint8_t/312.181.18
rcstd::uint8_t/151.150.97
rcstd::uint8_t/70.570.65
rcstd::uint16_t/34496.391.00
rcstd::uint16_t/633.991.41
rcstd::uint16_t/312.721.44
rcstd::uint16_t/151.611.38
rcstd::uint16_t/70.881.20
rcstd::uint32_t/34493.260.98
rcstd::uint32_t/6331.34
rcstd::uint32_t/312.231.55
rcstd::uint32_t/151.651.83
rcstd::uint32_t/71.081.29
rcstd::uint64_t/34492.661.24
rcstd::uint64_t/632.221.31
rcstd::uint64_t/311.811.27
rcstd::uint64_t/151.361.29
rcstd::uint64_t/711.41

StephanTLavavej reacted with heart emoji
@AlexGuteniev
Copy link
Contributor

Benchmark numbers

clang-cl appears to auto-vectorizereverse_copy, but notreverse

hazzlim and StephanTLavavej reacted with thumbs up emoji

@StephanTLavavejStephanTLavavej added performanceMust go faster ARM64Related to the ARM64 architecture labelsNov 14, 2025
@StephanTLavavejStephanTLavavej self-assigned thisNov 14, 2025
- Add comments to overlapping case in _Reverse_impl- Remove redundant _Advance_bytes call- Use if constexpr to guard otherwise dead code
@StephanTLavavejStephanTLavavej removed their assignmentNov 18, 2025
@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsNov 18, 2025
@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsNov 19, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavejStephanTLavavej merged commitee05a89 intomicrosoft:mainNov 19, 2025
44 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsNov 19, 2025
@StephanTLavavej
Copy link
Member

😻 !uoy knahT

hazzlim reacted with heart emoji

@hazzlim
Copy link
ContributorAuthor

Thanks for reviewing@AlexGuteniev and@StephanTLavavej 🐈‍⬛

StephanTLavavej and AlexGuteniev reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

+1 more reviewer

@AlexGutenievAlexGutenievAlexGuteniev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ARM64Related to the ARM64 architectureperformanceMust go faster

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hazzlim@AlexGuteniev@StephanTLavavej
[8]ページ先頭
©2009-2025 Movatter.jp