Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix GH_001923_filesystem_long_path_support/custombuild.pl for the MSVC-internal test harness#5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@StephanTLavavej
Copy link
Member

In toolset update#5783 I added test coverage for<filesystem> long path support. This requires a manifest to be embedded into the executable with a special linker option. The MSVC-internal test harness uses Perl for this, and I used a singlecl command. It turns out that in certain configurations (of course only run in CI checks, not in PR checks where I would have discovered this earlier), the MSVC-internal test harness adds/FastFailDump. When compiling with Clang, that gets sent to lld-link, which emits

lld-link: error: could not open '/FastFailDump': no such file or directory

I should have followed precedent and used separate compile and link commands, which avoids confusing lld-link (as in this case I believe we invoke MSVC link.exe):

Run::ExecuteCL("Test.cpp /c");
Run::ExecuteLink("/machine:$machine /out:$cwd.exe Test.obj");

@StephanTLavavejStephanTLavavej requested a review froma team as acode ownerOctober 23, 2025 07:00
@StephanTLavavejStephanTLavavej added testRelated to test code filesystemC++17 filesystem labelsOct 23, 2025
@StephanTLavavejStephanTLavavej moved this fromInitial Review toFinal Review inSTL Code ReviewsOct 23, 2025
@StephanTLavavejStephanTLavavej merged commiteb024e0 intomicrosoft:mainOct 23, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromFinal Review toDone inSTL Code ReviewsOct 23, 2025
@StephanTLavavejStephanTLavavej deleted the fix-fs-perl branchOctober 23, 2025 13:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zacklj89zacklj89zacklj89 approved these changes

Assignees

No one assigned

Labels

filesystemC++17 filesystemtestRelated to test code

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StephanTLavavej@zacklj89

[8]ページ先頭

©2009-2025 Movatter.jp