- Notifications
You must be signed in to change notification settings - Fork1.6k
Add missing Mandates forresize_and_overwrite#5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfromfrederick-vs-ja:resize_and_overwrite-integer-likeSep 10, 2025
Merged
Add missing Mandates forresize_and_overwrite#5695
StephanTLavavej merged 4 commits intomicrosoft:mainfromfrederick-vs-ja:resize_and_overwrite-integer-likeSep 10, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
e233688 toc761d14CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
StephanTLavavej approved these changesSep 6, 2025
Member
StephanTLavavej commentedSep 6, 2025
Thanks! 😻 I pushed very minor changes. |
Member
StephanTLavavej commentedSep 10, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
a0239a5 intomicrosoft:main 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Member
StephanTLavavej commentedSep 10, 2025
Thanks for noticing and fixing this missing enforcement! 🎉 🚀 🐱 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, MSVC STL hasn't implemented theMandates in[string.capacity]/8:
As a result, the following ill-formed program is accepted (Godbolt link):
This PR adds the missing
static_assertand expands coverage forGH-2524 to all supported (cv-unqualified) integer-like types.