Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Dev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20#5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfromYexuanXiao:nfi-fs-guard
Aug 8, 2025

Conversation

@YexuanXiao
Copy link
Contributor

The merged PR#117387 in Clang warnings when a parameter of memcpy is pointer to non-trivial-copyable types. This PR suppress the warning to avoid test failures.

Also, the<filesystem> and<span> headers were not properly guarded, and this PR guards them as seen in L166 and L182. The above two issues would cause this test to fail.

#if _HAS_CXX20
test_iterator<span<int>::iterator>();
#endif// _HAS_CXX20

bianyukun1213 reacted with thumbs up emoji
@StephanTLavavejStephanTLavavej changed the titleAdd header guard for tests/Dev11_0000000_null_forward_iterators and suppress Clang warningsDev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20Aug 2, 2025
@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsAug 2, 2025
@StephanTLavavejStephanTLavavej added the testRelated to test code labelAug 2, 2025
@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsAug 7, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavejStephanTLavavej merged commiteadd3be intomicrosoft:mainAug 8, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsAug 8, 2025
@StephanTLavavej
Copy link
Member

⚠️ 😸⚠️

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

+1 more reviewer

@frederick-vs-jafrederick-vs-jafrederick-vs-ja left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testRelated to test code

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YexuanXiao@StephanTLavavej@frederick-vs-ja
[8]ページ先頭
©2009-2025 Movatter.jp