As a result of DR-backingP3223R2, the new overload is templated, and thus this PR happens to "constrain the new overload to prevent ambiguities" and keepsin.ignore(100, -1L) well-formed.

frederick-vs-ja requested a review froma team as acode owner

June 22, 2025 14:32

github-project-automationbot added this toSTL Code Reviews

Jun 22, 2025

github-project-automationbot moved this toInitial Review inSTL Code Reviews

Jun 22, 2025

frederick-vs-ja changed the title~~Implement P3223R2 Makingstd::istream::ignore Less Surprising~~Implement P3223R2 Makingstd::istream::ignore() Less Surprising

Jun 23, 2025

frederick-vs-ja force-pushed thep3223r2 branch from1e3c9eb to5bddf8aCompare

June 23, 2025 16:24

frederick-vs-ja changed the title~~Implement P3223R2 Makingstd::istream::ignore() Less Surprising~~Implement P3223R2 Makingistream::ignore() Less Surprising

Jun 23, 2025

Implement WG21-P3223R2

f8b86d6

frederick-vs-ja force-pushed thep3223r2 branch from5bddf8a tof8b86d6Compare

June 23, 2025 17:05

frederick-vs-ja closed this

Jun 23, 2025

github-project-automationbot moved this fromInitial Review toDone inSTL Code Reviews

Jun 23, 2025

frederick-vs-ja reopened this

Jun 23, 2025

github-project-automationbot moved this fromDone toInitial Review inSTL Code Reviews

Jun 23, 2025

StephanTLavavej added the cxx26C++26 feature label

Jun 24, 2025

StephanTLavavej self-assigned this

Jun 24, 2025

Copy link

Contributor

Zingam commentedJul 7, 2025

@frederick-vs-ja (This is not a review. Just a couple of questions.) Was the paper voted in as DR? I guess not. My reading of the Standard is that resolving the ambiguity is not required is that so?
I made an attempt to implement the paper in libc++ but Windows is giving me troublesllvm/llvm-project#147007

Copy link

ContributorAuthor

frederick-vs-ja commentedJul 8, 2025•
edited
Loading

Was the paper voted in as DR? I guess not.

I guess not, either. But according to thepaper issue I think it should be treated as a DR.

My reading of the Standard is that resolving the ambiguity is not required is that so?

Yes. In this PR the ambiguity is resolved "by accident", which is a consequence of backporting. I don't think the ambiguity resolution is disallowed, either.