- Notifications
You must be signed in to change notification settings - Fork1.6k
<regex>: Limit recursion in the parser#5588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrommuellerj2:regex-limit-recursion-in-parserJul 15, 2025
Merged
<regex>: Limit recursion in the parser#5588
StephanTLavavej merged 1 commit intomicrosoft:mainfrommuellerj2:regex-limit-recursion-in-parserJul 15, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
StephanTLavavej approved these changesJun 14, 2025
Member
StephanTLavavej commentedJul 14, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
a1f193d intomicrosoft:main 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Member
StephanTLavavej commentedJul 15, 2025
Thanks for closing this potential avenue to stack overflows! 🛑 ❌ ⛔ |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4451 limited recursion for capture groups in the parser. However, unlimited recursion in the parser is still possible for regexes that use non-capturing groups or lookahead assertions. This PR similarly limits the recursion for such constructs by using the parser's pre-existing internal recursion counter,
_Disj_count.This supersedes the capture group limit introduced by#4451 as a way to prevent stack overflows. But I'm leaving it in because regexes using more than 1000 capture groups strike me as bogus anyway. (I think the error code
error_spacewould be more appropriate in this case now, since the limit is no longer about preventing recursion, but it's probably not worth introducing a minor behavior difference just for this reason. One could even argue thaterror_spaceis more appropriate for the new stack limit introduced by this PR, too, becauseerror_spaceis about regex construction, whileerror_stackis about regex matching.)I also fix a mistake in
_Matcher2::_Skip()'s recursion limitation: In#5576, I accidentally missed to pass the recursion counter as an argument to one of the recursive calls.