- Notifications
You must be signed in to change notification settings - Fork1.6k
Updatesource_location tests for upcoming EDG changes#5551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
StephanTLavavej commentedMay 28, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Uh oh!
There was an error while loading.Please reload this page.
davidmrdavid approved these changesMay 28, 2025
Member
davidmrdavid left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚢 it
7841cf8 intomicrosoft:main 48 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDG is changing their
source_locationbuiltins to produce output that more closely resembles C1XX's. To keep our tests passing as these changes are introduced into VS, I'm updating the tests to accept either the old output or the new output. After the changes have shipped and we can update the toolset on GitHub, I can remove the old expected outputs.@jgoshi has validated that this passes with the upcoming changes.