Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Uselower_bound instead offind_if to lookuptime_zones.#5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
StephanTLavavej merged 8 commits intomicrosoft:mainfromYexuanXiao:locate-zone
May 28, 2025
Merged

Uselower_bound instead offind_if to lookuptime_zones.#5548

StephanTLavavej merged 8 commits intomicrosoft:mainfromYexuanXiao:locate-zone
May 28, 2025

Conversation

@YexuanXiao
Copy link
Contributor

Fix#5547.

frederick-vs-ja, cpplearner, bianyukun1213, ShelpAm, and doomlaur reacted with thumbs up emoji
@AlexGuteniev

This comment was marked as resolved.

@YexuanXiao

This comment was marked as resolved.

@StephanTLavavejStephanTLavavej self-assigned thisMay 27, 2025
@StephanTLavavejStephanTLavavej added performanceMust go faster chronoC++20 chrono labelsMay 27, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😻 On my 5950X this results in an excellent 6.7x speedup, as I have 477zones and 157links:

BenchmarkBeforeAfterSpeedup
locate_zone135443 ns20203 ns6.70

@StephanTLavavejStephanTLavavej removed their assignmentMay 28, 2025
@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsMay 28, 2025
@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsMay 28, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavejStephanTLavavej merged commitfa1448d intomicrosoft:mainMay 28, 2025
48 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsMay 28, 2025
@StephanTLavavej
Copy link
Member

🌏 🕥 🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

+2 more reviewers

@AlexGutenievAlexGutenievAlexGuteniev left review comments

@frederick-vs-jafrederick-vs-jafrederick-vs-ja left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chronoC++20 chronoperformanceMust go faster

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<chrono>:std::chrono::locate_zone should use binary search

4 participants

@YexuanXiao@AlexGuteniev@StephanTLavavej@frederick-vs-ja
[8]ページ先頭
©2009-2025 Movatter.jp