Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update_MSVC_STL_UPDATE to May 2025 and update_MSVC_STL_VERSION to 145#5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@vinay-852
Copy link
Contributor

@vinay-852vinay-852 commentedMay 2, 2025•
edited
Loading

This PR updates the _MSVC_STL_VERSION macro in yvals_core.h from 143 to 145 to reflect the beginning of work on Visual Studio 18, whose toolset will identify itself as "v145".

Updated line:
#define _MSVC_STL_VERSION 143 →#define _MSVC_STL_VERSION 145

#define _MSVC_STL_UPDATE 202504L→#define _MSVC_STL_UPDATE 202505L

This change ensures consistency with the new toolset versioning and aligns with the guidelines mentioned in issue#5461.

Closes#5461 .

@StephanTLavavejStephanTLavavej added the enhancementSomething can be improved labelMay 2, 2025
@StephanTLavavej
Copy link
Member

Thanks! There's a typo in your PR description - it says it's changing_MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsMay 2, 2025
@vinay-852
Copy link
ContributorAuthor

Thanks! There's a typo in your PR description - it says it's changing_MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

Thanks for the clarification, Stephan! I’ll update the description and keep your suggestions in mind for future PRs.

StephanTLavavej, vinay-852, and frederick-vs-ja reacted with thumbs up emoji

@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsMay 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull requestMay 9, 2025
@StephanTLavavejStephanTLavavej changed the titleUpdate _MSVC_STL_VERSION from 143 to 145 for Visual Studio 18 toolsetUpdate_MSVC_STL_UPDATE to May 2025 and update_MSVC_STL_VERSION to 145May 9, 2025
@StephanTLavavejStephanTLavavej merged commit3a06698 intomicrosoft:mainMay 10, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsMay 10, 2025
@StephanTLavavej
Copy link
Member

Thanks for updating these version macros and congratulations on your first microsoft/STL commit! 🎉 😻 🐈

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

Assignees

No one assigned

Labels

enhancementSomething can be improved

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update_MSVC_STL_UPDATE to May 2025 and update_MSVC_STL_VERSION to 145

2 participants

@vinay-852@StephanTLavavej
[8]ページ先頭
©2009-2025 Movatter.jp