- Notifications
You must be signed in to change notification settings - Fork1.6k
vector_algorithms.cpp: cleanup#5429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AlexGuteniev commentedApr 24, 2025
Added another commit with |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
StephanTLavavej commentedApr 24, 2025
Thanks, these changes are great - especially the count-in-bytes and unsigned long mask changes! 😻 I pushed a syntax nitpick and a comment fix. STL SEES ALL. |
StephanTLavavej commentedApr 25, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
116ee9a intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
StephanTLavavej commentedApr 29, 2025
🧹 🚀 😸 |
Fix accumulated inconsistencies in
vector_algorithms.cpp, separate commit each:const, lately I've been trying to addconsteverywhere, but there is missing one in older code_CSTD, the C run time things used unqualified in this file in some other places_Avx2_tail_mask_32now takes bytes count. It is odd from the perspective of the function itself, but almost every call site has bytes, and even for the ones that don't, the lack of multiplication by 4 and multiplication by 2 instead of by 8 look odd.Deliberately skipped namespace as per#5418 for now. These look more controversial, so I'd do just clean stuff first.