Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

vector_algorithms.cpp: cleanup#5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
StephanTLavavej merged 7 commits intomicrosoft:mainfromAlexGuteniev:cleanup
Apr 29, 2025

Conversation

@AlexGuteniev
Copy link
Contributor

Fix accumulated inconsistencies invector_algorithms.cpp, separate commit each:

  • Moreconst, lately I've been trying to addconst everywhere, but there is missing one in older code
  • Use the same type for a variable as in the other similar branch. Unsigned type is selected, as we do bitwise thing with it
  • Drop_CSTD, the C run time things used unqualified in this file in some other places
  • _Avx2_tail_mask_32 now takes bytes count. It is odd from the perspective of the function itself, but almost every call site has bytes, and even for the ones that don't, the lack of multiplication by 4 and multiplication by 2 instead of by 8 look odd.

Deliberately skipped namespace as per#5418 for now. These look more controversial, so I'd do just clean stuff first.

frederick-vs-ja reacted with thumbs up emoji
@github-project-automationgithub-project-automationbot moved this fromDone toInitial Review inSTL Code ReviewsApr 24, 2025
@AlexGuteniev
Copy link
ContributorAuthor

Added another commit withnoexcept lambdas.
This is still consistency.noexcept isn't useful there.

@StephanTLavavejStephanTLavavej added the enhancementSomething can be improved labelApr 24, 2025
@StephanTLavavejStephanTLavavej self-assigned thisApr 24, 2025
@StephanTLavavejStephanTLavavej added the unchartedExcluded from the Status Chart labelApr 24, 2025
@StephanTLavavejStephanTLavavej removed their assignmentApr 24, 2025
@StephanTLavavej
Copy link
Member

Thanks, these changes are great - especially the count-in-bytes and unsigned long mask changes! 😻 I pushed a syntax nitpick and a comment fix. STL SEES ALL.

@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsApr 24, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsApr 25, 2025
@StephanTLavavejStephanTLavavej merged commit116ee9a intomicrosoft:mainApr 29, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsApr 29, 2025
@StephanTLavavej
Copy link
Member

🧹 🚀 😸

@AlexGutenievAlexGuteniev deleted the cleanup branchApril 29, 2025 12:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

Assignees

No one assigned

Labels

enhancementSomething can be improvedunchartedExcluded from the Status Chart

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexGuteniev@StephanTLavavej

[8]ページ先頭

©2009-2025 Movatter.jp