Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

<regex>: Allow initial] to start character ranges in POSIX regular expressions#5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@muellerj2
Copy link
Contributor

Fixes a regex miscompilation noticed in#5165.

The POSIX standard says that the right bracket ] is not special at the beginning of a bracketed character class (https://pubs.opengroup.org/onlinepubs/009696699/basedefs/xbd_chap09.html#tag_09_03_05). This means that an initial ] behaves like any other character, so it may also be the start of a character range.

@muellerj2muellerj2 requested a review froma team as acode ownerMarch 25, 2025 22:13
@StephanTLavavejStephanTLavavej added bugSomething isn't working regexmeow is a substring of homeowner labelsMar 25, 2025
@StephanTLavavejStephanTLavavej self-assigned thisMar 25, 2025
@StephanTLavavejStephanTLavavej changed the title<regex>: Allow initial ] to start character ranges in POSIX regular expressions<regex>: Allow initial] to start character ranges in POSIX regular expressionsMar 25, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😻 I pushed changes to significantly expand the test coverage.

@StephanTLavavejStephanTLavavej removed their assignmentApr 2, 2025
@StephanTLavavejStephanTLavavej moved this fromInitial Review toReady To Merge inSTL Code ReviewsApr 2, 2025
@StephanTLavavejStephanTLavavej moved this fromReady To Merge toMerging inSTL Code ReviewsApr 9, 2025
@StephanTLavavejStephanTLavavej self-assigned thisApr 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

Resolved adjacent-add conflict inVSO_0000000_regex_use.

@StephanTLavavejStephanTLavavej merged commit5a1cbde intomicrosoft:mainApr 10, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerging toDone inSTL Code ReviewsApr 10, 2025
@StephanTLavavej
Copy link
Member

🥕 💵 ⭐

@muellerj2muellerj2 deleted the regex-fix-initial-right-bracket-in-posix-regexes branchApril 13, 2025 13:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StephanTLavavejStephanTLavavejStephanTLavavej approved these changes

Assignees

@StephanTLavavejStephanTLavavej

Labels

bugSomething isn't workingregexmeow is a substring of homeowner

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@muellerj2@StephanTLavavej
[8]ページ先頭
©2009-2025 Movatter.jp