Based on@skottmckay 's explanation, it is reasonable to filter out duplicate EPs. Given this, the version detection logic appears to be redundant and can be safely removed.

Checklist before requesting a review

Add unit tests for this change.
Make sure all tests can pass.
Update documents if necessary.
Lint and apply fixes to your code by runninglintrunner -a
Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
Is this PR including examples changes? If yes, please remember to updateexample documentation in a follow-up PR.

(Optional) Issue link

remove version check when add_provider_for_devices

4b2f2a2

fangyangci marked this pull request as ready for review

July 16, 2025 07:20

fangyangci requested review fromskottmckay,shaahji,xieofxie andchinazhangchao

July 16, 2025 10:22

fangyangci marked this pull request as draft

July 16, 2025 10:28

Copy link

Contributor

shaahji commentedJul 16, 2025

AFAIK, theort.get_ep_devices() wasn't introduced until after 1.22.0 so I don't think this will work for older releases. You might want to confirm with either 1.22.0 or a slightly older release.

Copy link

Contributor

xieofxie commentedJul 17, 2025

AFAIK, theort.get_ep_devices() wasn't introduced until after 1.22.0 so I don't think this will work for older releases. You might want to confirm with either 1.22.0 or a slightly older release.

Hi, this is part of revert of this prhttps://github.com/microsoft/Olive/pull/1963/files it looks previously there is no check forort.get_ep_devices()

fangyangci marked this pull request as ready for review

July 17, 2025 02:14

Copy link

Contributor

shaahji commentedJul 17, 2025

AFAIK, theort.get_ep_devices() wasn't introduced until after 1.22.0 so I don't think this will work for older releases. You might want to confirm with either 1.22.0 or a slightly older release.
Hi, this is part of revert of this prhttps://github.com/microsoft/Olive/pull/1963/files it looks previously there is no check forort.get_ep_devices()

I guess, I missed the version check in the previous commit/review. This code will not work forort <= 1.22.0 since theort.get_ep_devices() API doesn't exist. In your previous commit, only the else part was valid.

I recommend creating a local environment with both versions (<=1.22.0 & >1.22.0) and trying it out to confirm.