- Notifications
You must be signed in to change notification settings - Fork227
Add IODataTypeConverter surgeon to GraphSurgeries pass#1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intomainChoose a base branch fromcopilot/fix-1928
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: devang-ml <47577486+devang-ml@users.noreply.github.com>
Copilot finished work on behalf ofdevang-mlJune 23, 2025 19:24
roboman-tech commentedJun 30, 2025
@devang-ml, It doesn't remove |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a new
IODataTypeConverter
surgeon to theGraphSurgeries
pass, providing the same functionality as the standaloneOnnxIODataTypeConverter
pass but integrated into the graph surgeries framework.Changes Made
New Surgeon Implementation
IODataTypeConverter
class inheriting fromProtoSurgeon
Key Features
OnnxIODataTypeConverter
:source_dtype
: Source datatype integer valuetarget_dtype
: Target datatype integer valuename_pattern
: Regex pattern for selective conversion (default: "logits")Usage Example
This converts all inputs/outputs matching "logits" from FLOAT16 (10) to FLOAT (1).
Documentation and Testing
OnnxIODataTypeConverter
passThis implementation provides a migration path for users to move from the standalone pass to the more flexible GraphSurgeries framework, supporting the long-term goal of consolidating ONNX transformations.
Fixes#1928.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Clickhere to start the survey.